[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added CC||roan.katt...@gmail.com --- Comment #10 from Roan Kattouw roan.katt...@gmail.com 2012-02-08 16:53:26 UTC --- http://en.wikisource.beta.wmflabs.org/wiki/Page:Wind_in_the_Willows_%281913%29.djvu/28 works for me now in the sense that I don't get any JS errors when I view it; I'm not familiar with ProofreadPage so maybe there are missing features I'm not aware of? Is this still broken, and if so, how do I reproduce? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 --- Comment #11 from Zaran zaran.krl...@gmail.com 2012-02-08 17:29:27 UTC --- It is still broken: in the proofreadpage extension, you're supposed to see the image of the page on the right side of the text. See for example on fr.wikisource: http://fr.wikisource.org/wiki/Page:Leblanc_-_L’Île_aux_trente_cercueils.djvu/8 or on the wikisource instance on labs: http://wikisource-dev.wmflabs.org/w/index.php/Page:Bloy_-_Sueur_de_sang.djvu/227 Note that currently the bug doesn't show up when you test locally or on the wikisource instance on labs. But on the deployment instance, the proofreadpage specific javascript simply doesn't load without any error. Note also that with debug=true the bug disappears. But looking at the compressed javascript with debug=false, it looks like the javascript of the extension is not even included. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Roan Kattouw roan.katt...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #12 from Roan Kattouw roan.katt...@gmail.com 2012-02-08 19:22:44 UTC --- Fixed in r110949 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Sumana Harihareswara suma...@panix.com changed: What|Removed |Added CC||suma...@panix.com --- Comment #9 from Sumana Harihareswara suma...@panix.com 2012-02-06 21:26:47 UTC --- By Feb 10th Mark is going to get someone to agree to fix this. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Ryan Kaldari rkald...@wikimedia.org changed: What|Removed |Added CC||rkald...@wikimedia.org --- Comment #8 from Ryan Kaldari rkald...@wikimedia.org 2012-02-04 00:34:27 UTC --- Patch was applied, but apparently it's still not working on labs. I also committed r110691, but this didn't seem to fix it on labs either. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 --- Comment #6 from Zaran zaran.krl...@gmail.com 2012-02-02 21:55:40 UTC --- Created attachment 9951 -- https://bugzilla.wikimedia.org/attachment.cgi?id=9951 add wikibits as a dependency of ProofreadPage extension -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 --- Comment #7 from Zaran zaran.krl...@gmail.com 2012-02-02 21:58:18 UTC --- Yes I'm on IRC (Zaran on #mediawiki). I've started working on it yesterday. There are two ways to solve the problem : * set $wgIncludeLegacyJavascript = true in the config * add mediawiki.legacy.wikibits as a dependency of the extension (see patch above). I don't know if the option $wgIncludeLegacyJavascript is planned to be set to true on the deployment servers. But in all cases, it's probably better to add the dependency to wikibits, because the current javascript code of the extension relies on some deprecated functions (hookEvent for example). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 --- Comment #5 from Mark A. Hershberger m...@everybody.org 2012-02-01 15:18:37 UTC --- (In reply to comment #4) yes, I'm going to take a look at it some time this week Are you on IRC? Could you ping me (hexmode on #mediawiki) if you start to work on this? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added AssignedTo|thoma...@gmx.de |wikibugs-l@lists.wikimedia. ||org --- Comment #3 from Mark A. Hershberger m...@everybody.org 2012-01-30 19:25:44 UTC --- Zaran, could you look at this? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 --- Comment #4 from Zaran zaran.krl...@gmail.com 2012-01-30 20:10:34 UTC --- yes, I'm going to take a look at it some time this week. As Derk-Jan pointed out, it is only a problem of wikibits dependency, and the time at which it is loaded. It seems to work on the lab server by adding wikibits as a dependency of the ProofreadPage extension (it is currently not the case in the code in the SVN repository). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added Keywords||javascript -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added Priority|Normal |High CC||ro...@wikimedia.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 --- Comment #2 from Mark A. Hershberger m...@everybody.org 2012-01-25 19:30:41 UTC --- I think this is included now, right? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added CC||m...@everybody.org Blocks|29097 | Target Milestone|--- |1.19wmf deployment -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added Priority|Unprioritized |Normal -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 --- Comment #1 from Derk-Jan Hartman hart...@videolan.org 2012-01-22 22:53:37 UTC --- dependency in proofread, to force loading of wikibits in debug mode (due to async bug in debug mode that Krinkle pointed out to Catrope). With that, we might be able to figure out why it's not working in production, since no console errors are shown. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Derk-Jan Hartman hart...@videolan.org changed: What|Removed |Added URL||http://en.wikisource.beta.w ||mflabs.org/w/index.php?titl ||e=Page:Wind_in_the_Willows_ ||(1913).djvu/28action=edit ||redlink=1debug=true -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33873] Proofread extension JS loading fully broken on 1.19
https://bugzilla.wikimedia.org/show_bug.cgi?id=33873 Derk-Jan Hartman hart...@videolan.org changed: What|Removed |Added Blocks||29097 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
