[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

--- Comment #14 from Antoine hashar Musso has...@free.fr 2012-02-11 
09:56:50 UTC ---
That was fast :-)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Antoine hashar Musso has...@free.fr changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||has...@free.fr
 AssignedTo|j...@compwhizii.net |has...@free.fr

--- Comment #10 from Antoine hashar Musso has...@free.fr 2012-02-10 
18:04:59 UTC ---
Will give a look at that extension Monday under my 20% time. Will try to fix
the PHP part / migrate to API usage if that is possible.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

bs...@wikimedia.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||bs...@wikimedia.org
 Resolution||FIXED

--- Comment #11 from bs...@wikimedia.org 2012-02-10 23:54:47 UTC ---
fixed in r111218

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

--- Comment #12 from Sam Reed (reedy) s...@reedyboy.net 2012-02-11 00:09:52 
UTC ---
(In reply to comment #11)
 fixed in r111218

Aha! Nice one Benny.

Confirmed fixed :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Sam Reed (reedy) s...@reedyboy.net changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

--- Comment #13 from Mark A. Hershberger m...@everybody.org 2012-02-11 
02:25:07 UTC ---
yay! 20% time success!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

 AssignedTo|wikibugs-l@lists.wikimedia. |j...@compwhizii.net
   |org |

--- Comment #8 from Rob Lanphier ro...@wikimedia.org 2012-02-10 00:33:21 UTC 
---
We think this was introduced in r98500.  That had a fixme on it, but was
converted back to new, I think for unrelated reasons.  John, what's the status
on this?  Do you need help getting this one figured out?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

--- Comment #9 from Sam Reed (reedy) s...@reedyboy.net 2012-02-10 01:28:52 
UTC ---
It seems reverting back to r98499 isn't enough, it seems to break other parts
of it (which isn't actually unexpected with all the JS overhauling)...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Daniel Kinzler daniel.kinz...@wikimedia.de changed:

   What|Removed |Added

 CC||daniel.kinz...@wikimedia.de

--- Comment #4 from Daniel Kinzler daniel.kinz...@wikimedia.de 2012-02-07 
09:58:39 UTC ---
i'll have a look now, but I can't spend a lot of time on this. According to svn
blame, the interesting bits have been rewritten by siebrand and tstarling. And
the change by johnduhart Sam mentioned is pretty massive, too. Not sure I
understand the code any more :)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Bawolff bawolff...@gmail.com changed:

   What|Removed |Added

 CC||bawolff...@gmail.com

--- Comment #5 from Bawolff bawolff...@gmail.com 2012-02-07 10:05:06 UTC ---
in my test, the page always made requests that had json looking like:
{mode:0,hideprefix:20,showcount:true,namespaces:false}

regardless of what mode was selected, so probably something with the js not
reading the select dropdown properly.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

--- Comment #6 from Daniel Kinzler daniel.kinz...@wikimedia.de 2012-02-07 
10:46:52 UTC ---
Yes, I foudn the same thing:

mode is 0, which means categories only. So no regular pages are
returned.

The code that generates the link that is used to expand the node was all
jquery-fied, and I wan't able to dig into it yet. Will looks some more later.

However, this has nothing to do with the dropdown - the dropdown only exists on
Special:CategoryTree, but the JS code has to work also on category pages and
any wiki page that embeds a category tree inline.

Basically: whatever code generates the parameters to be used in the ajax call
for
retrieving the categories content must use the mode that was used to generate
the parent node. When I first wrote this, the code that generated the HTML(!)
that represents a category's content would include the HTML code for the expand
bullets, which contained the javascript function call that would retrieve the
node's content with the appropriate parameters (that is, the same mode, etc,
used to generate the present output).

If the node's content is now returned as json, not html (as I think it is, if I
understd the new code correctly), that json has to contain the full option set
to be used to retrieve the content of further sub-categories. I suspect that
this is not the case.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Daniel Kinzler daniel.kinz...@wikimedia.de changed:

   What|Removed |Added

 AssignedTo|daniel.kinz...@wikimedia.de |wikibugs-l@lists.wikimedia.
   ||org

--- Comment #7 from Daniel Kinzler daniel.kinz...@wikimedia.de 2012-02-07 
11:33:36 UTC ---
So, it's somehow related to ctOptions on the parent tag not being what they
should be. 

At some point, the PHP code generates a first, static, category tree node.
ctOptions would have to be set on the HTML for that static node somehow by the
PHP code, so it can be picked up from jQuery later, to be used when loading
further (sub)nodes. I couldn't find any PHP code that does this. In stead, it
seems that the jQuery code always falls back to mw.config.get(
'wgCategoryTreePageCategoryOptions' ) (line 93 in ext.categoryTree.js).

My impression is that johnduhart's work to make CategoryTree use jQuery is
incomplete in that respect. I don't know jQuery or the resource loader
framework well enough to really find out how exactly. 

So, I give up and assign the bug to the list.

Generally: action=ajax should be deprecated and CategoryTree should be
rewritten using the API.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-02-02 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 AssignedTo|wikibugs-l@lists.wikimedia. |daniel.kinz...@wikimedia.de
   |org |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-01-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||m...@everybody.org
   Target Milestone|--- |1.19wmf deployment

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-01-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

Rob Lanphier ro...@wikimedia.org changed:

   What|Removed |Added

   Keywords||javascript
 CC||ro...@wikimedia.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

--- Comment #1 from Sam Reed (reedy) s...@reedyboy.net 2012-01-27 15:36:14 
UTC ---
Created attachment 9917
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=9917
Image showing test as a subcat, showing any pages when selected and expanded

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

--- Comment #2 from Sam Reed (reedy) s...@reedyboy.net 2012-01-27 15:36:43 
UTC ---
Created attachment 9918
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=9918
Image showing test at top level, showing pages fine

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33989] Trunk CategoryTree doesn't list pages of sub categories

2012-01-27 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33989

--- Comment #3 from Sam Reed (reedy) s...@reedyboy.net 2012-01-27 15:37:22 
UTC ---
Created attachment 9919
  -- https://bugzilla.wikimedia.org/attachment.cgi?id=9919
And shown on 1.18wmf1

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l