[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 Amir E. Aharoni changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #9 from Amir E. Aharoni 2012-04-03 05:48:25 UTC --- The patch was reviewed and approved by Brion. It will probably be deployed on Wikimedia projects next week. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 Amir E. Aharoni changed: What|Removed |Added Severity|minor |normal --- Comment #8 from Amir E. Aharoni 2012-03-29 16:48:46 UTC --- Oh, and thanks a lot for the patch to foma...@googlemail.com. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 Amir E. Aharoni changed: What|Removed |Added Priority|Low |Normal Status|NEW |ASSIGNED AssignedTo|wikibugs-l@lists.wikimedia. |amir.ahar...@mail.huji.ac.i |org |l Severity|trivial |minor --- Comment #7 from Amir E. Aharoni 2012-03-29 16:47:45 UTC --- I applied a patch based on the first comment in https://gerrit.wikimedia.org/r/#change,3920 Edit section links for the opening section are done using gadgets and user scripts today, so gadgets should care about their directionality. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 Mark A. Hershberger changed: What|Removed |Added Priority|Unprioritized |Low -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 foma...@googlemail.com changed: What|Removed |Added CC||krinklem...@gmail.com Component|User login |User interface --- Comment #6 from foma...@googlemail.com 2012-02-19 15:09:06 UTC --- I created Bug 34514 for a first heading in page content language and direction. When this Bug is fixed I don't see any situations with a edit section button outside of a mw-content-ltr/mw-content-rtl container. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470
--- Comment #5 from foma...@googlemail.com 2012-02-19 12:59:10 UTC ---
Ok, there is one situation for a edit section button outside of the
mw-content-ltr or mw-content-rtl container when you create a edit section
button for the first heading as a gadget like
[[de:MediaWiki:Gadget-Einleitung-bearbeiten.js]]. For this situation the
automatic user interface based flipped definition is necessary:
.editsection {
float: right;
margin-left: 5px;
}
For edit section buttons inside the mw-content-ltr/mw-content-rtl container
should not flipped and should depend mw-content-ltr/mw-content-rtl.
- new -
/* Edit section links */
/* outside of mw-content-ltr/mw-content-rtl */
.editsection {
float: right;
margin-left: 5px;
}
/* Correct directionality when page dir is different from site/user dir */
/* @noflip */
.mw-content-ltr .editsection,
.mw-content-rtl .mw-content-ltr .editsection {
float: right;
margin-left: 5px;
}
/* @noflip */
.mw-content-rtl .editsection,
.mw-content-ltr .mw-content-rtl .editsection {
float: left;
margin-right: 5px;
}
-
LTR wikis with RTL user interface have the same problem with the margin. The
float definition and the margin definition must kept together.
Why depends the language and the direction of the first heading on the user
interface language and not on the page content language? I think the language
and the direction of the first heading should also depend on the page content
language.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470
--- Comment #4 from foma...@googlemail.com 2012-02-19 10:58:06 UTC ---
The annoying left margin for the edit section buttons on RTL wikis with LTR
user interface was my reason to open the bug.
The definition
.editsection {
float: right;
}
is useless because it is always overwritten by one of the more specific
definitions with class mw-content-ltr or class mw-content-rtl in the selector.
Or is there still a situation for a edit section button without class
mw-content-ltr or mw-content-rtl?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 --- Comment #3 from Robin Pepermans (SPQRobin) 2012-02-19 02:25:39 UTC --- (In reply to comment #2) > margin: 0 5px is wrong because it generates an additional margin at the end. Yes, but I meant, if there is no problem with having a margin at the end (I don't see any problem), then it's better to do it that way because that's simpler. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 foma...@googlemail.com changed: What|Removed |Added Priority|Low |Unprioritized --- Comment #2 from foma...@googlemail.com 2012-02-18 21:57:22 UTC --- margin: 0 5px is wrong because it generates an additional margin at the end. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 Mark A. Hershberger changed: What|Removed |Added Priority|Unprioritized |Low CC||m...@everybody.org -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 --- Comment #1 from Robin Pepermans (SPQRobin) 2012-02-18 12:54:34 UTC --- The margin is so small that I didn't notice it when developing mw-content-ltr/rtl. We can do the above fix (the exact patch doesn't work but it can be adapted), or another solution could be to simply change it to margin: 0 5px; so it would be 5px on both sides regardless of LTR/RTL. I don't know if that would be OK or if there's a reason to have no margin at the end. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 34470] margin for edit section button on RTL wikis with LTR user interface is on the wrong side
https://bugzilla.wikimedia.org/show_bug.cgi?id=34470 Derk-Jan Hartman changed: What|Removed |Added CC||hart...@videolan.org Blocks||745 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
