[Bug 34785] Internal api error reported

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

Mark A. Hershberger  changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||m...@everybody.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

Rob Lanphier  changed:

   What|Removed |Added

 CC||ro...@wikimedia.org
 AssignedTo|wikibugs-l@lists.wikimedia. |aschulz4...@gmail.com
   |org |

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

Bawolff  changed:

   What|Removed |Added

 CC||bawolff...@gmail.com
Summary|Internal api error reported |Internal api error reported
   ||(
   ||UploadStashFileNotFoundExce
   ||ption )

--- Comment #1 from Bawolff  2012-03-01 00:20:42 UTC ---
Including actual error message in bug title (  UploadStashFileNotFoundException
) for easier searching and for people too lazy to look at image ;)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

--- Comment #2 from Aaron Schulz  2012-03-01 00:33:21 
UTC ---
How often does this occur?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

Mark A. Hershberger  changed:

   What|Removed |Added

   Priority|High|Low
   Target Milestone|1.19wmf deployment  |Mysterious future

--- Comment #3 from Mark A. Hershberger  2012-03-01 
21:44:15 UTC ---
resetting milestone till we figure out that this is more dependably replicable

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

Rob Lanphier  changed:

   What|Removed |Added

   Priority|Low |Normal
 AssignedTo|aschulz4...@gmail.com   |roan.katt...@gmail.com

--- Comment #4 from Rob Lanphier  2012-03-01 22:56:48 UTC 
---
Roan has been working on this one.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

--- Comment #5 from ineuw  2012-03-17 05:54:55 UTC ---
Just completed the upload of 19 greyscale images, total size 7.1MB and two
reported the same bug, although the images were in fact uploaded and not
rejected. Unfortunately I can't provide any technical data.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

Max Semenik  changed:

   What|Removed |Added

 CC||maxsem.w...@gmail.com
   Severity|minor   |normal

--- Comment #6 from Max Semenik  2012-03-18 23:04:39 UTC 
---
Just encountered it, upping severity:

== Request ==

POST /w/api.php HTTP/1.1 
User-Agent: Opera/9.80 (Windows NT 6.1; U; ru) Presto/2.10.229 Version/11.61
Host: commons.wikimedia.org
Accept-Language: ru,en;q=0.9
Accept-Encoding: gzip, deflate
Referer: https://commons.wikimedia.org/wiki/Special:UploadWizard
Cookie: *
Connection: Keep-Alive
Content-Length: 955
Content-Type: application/x-www-form-urlencoded
Accept: application/json, text/javascript, */*; q=0.01
X-Requested-With: XMLHttpRequest
Content-Transfer-Encoding: binary

== POST variables ==

actionupload
formatjson
filekey10firwjkg56g.caqj15.20471.jpg
filenameVladislav_Kovalyov_execution_notice.jpg
text=={{int:filedesc}}== {{Information |description={{en|1=Notice sent to
the mother of the excuted 2011 Minsk metro bombing perpetrator Vladislav
Kovalyov}} |date=2012-03-16
|source=http://charter97.org/photos/20120317_prigovor.jpg |author=Belarussian
Supreme Court |permission= |other_versions= |other_fields= }}
=={{int:license-header}}== {{subst:Custom license marker added by UW}}
{{PD-BY-exempt}} [[Category:Uploaded with UploadWizard]] [[Category:Death
penalty]] [[Category:2012 in Belarus]] [[Category:2011 Minsk Metro bombing]] 
summaryUser created page with UploadWizard (alpha)
token9bf46413397017ca89f840746cf1dcc2+\

== Response ==
HTTP/1.1 200 OK 
Server: nginx/0.7.65
Date: Sat, 17 Mar 2012 10:48:26 GMT
Content-Type: application/json; charset=utf-8
Connection: keep-alive
X-Content-Type-Options: nosniff
Cache-Control: private
MediaWiki-API-Error: internal_api_error_UploadStashFileNotFoundException
Content-Encoding: gzip
Vary: Accept-Encoding
X-Vary-Options: Accept-Encoding;list-contains=gzip
Content-Length: 452
X-Cache: MISS from sq62.wikimedia.org
X-Cache-Lookup: MISS from sq62.wikimedia.org:3128
X-Cache: MISS from amssq38.esams.wikimedia.org
X-Cache-Lookup: MISS from amssq38.esams.wikimedia.org:3128
X-Cache: MISS from amssq33.esams.wikimedia.org
X-Cache-Lookup: MISS from amssq33.esams.wikimedia.org:80
Via: 1.1 sq62.wikimedia.org:3128 (squid/2.7.STABLE9), 1.0
amssq38.esams.wikimedia.org:3128 (squid/2.7.STABLE9), 1.0
amssq33.esams.wikimedia.org:80 (squid/2.7.STABLE9)

== Body ==

{"servedby":"srv195","error":{"code":"internal_api_error_UploadStashFileNotFoundException","info":"Exception
Caught: key '10firwjkg56g.caqj15.20471.jpg' not found in stash","*":"\n\n#0
\/usr\/local\/apache\/common-local\/php-1.19\/includes\/upload\/UploadStash.php(135):
UploadStash->getFile('10firwjkg56g.ca...')\n#1
\/usr\/local\/apache\/common-local\/php-1.19\/includes\/upload\/UploadFromStash.php(79):
UploadStash->getMetadata('10firwjkg56g.ca...')\n#2
\/usr\/local\/apache\/common-local\/php-1.19\/includes\/api\/ApiUpload.php(308):
UploadFromStash->initialize('10firwjkg56g.ca...', 'Vladislav_Koval...')\n#3
\/usr\/local\/apache\/common-local\/php-1.19\/includes\/api\/ApiUpload.php(64):
ApiUpload->selectUploadModule()\n#4
\/usr\/local\/apache\/common-local\/php-1.19\/includes\/api\/ApiMain.php(706):
ApiUpload->execute()\n#5
\/usr\/local\/apache\/common-local\/php-1.19\/includes\/api\/ApiMain.php(360):
ApiMain->executeAction()\n#6
\/usr\/local\/apache\/common-local\/php-1.19\/includes\/api\/ApiMain.php(344):
ApiMain->executeActionWithErrorHandling()\n#7
\/usr\/local\/apache\/common-local\/php-1.19\/api.php(117):
ApiMain->execute()\n#8
\/usr\/local\/apache\/common-local\/live-1.5\/api.php(3):
require('\/usr\/local\/apac...')\n#9 {main}\n\n"}}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

Erik Moeller  changed:

   What|Removed |Added

   Priority|Normal  |High
 CC||aschulz4...@gmail.com,
   ||e...@wikimedia.org
   Severity|normal  |major

--- Comment #7 from Erik Moeller  2012-05-08 05:31:42 UTC 
---
Here's an example of this bug from user-testing:

https://accounts.usertesting.com/ViewVideo.aspx?file=t0uwDTLDpas%3d

Firefox 12 user. File first fails with "unknown error", then on retry with the
stash error. What's noticeable is that the final step takes a long time before
it errors out. These are just image files, albeit large ones.

This is definitely a high priority bug that needs some deeper investigation,
probably by Aaron as well since it might be FileBackend/SWIFT related. I'll
poke at it as well to see if I can produce it at all in local testing.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

--- Comment #8 from Erik Moeller  2012-05-08 05:43:42 UTC 
---
I should note that the above user actually successfully uploaded the balloon
picture which reported the error. (I deleted the file, so you can no longer see
it.) The timing was the same as the other uploads. So UW apparently correctly
uploaded the file but reported an API error.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

Rob Lanphier  changed:

   What|Removed |Added

   Keywords||platformeng

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

--- Comment #9 from Erik Moeller  2012-05-09 06:27:00 UTC 
---
Here's what appears to be happening. The MediaWiki API JavaScript convenience
functions in core (resources/mediawiki.api/mediawiki.api.js) have a default
timeout of 30 seconds. This causes uploads to report an error if the final step
runs longer than 30 seconds. The uploads should be successfully going through,
regardless, which is why the "Retry" shows a stash error (at that point the
file has been successfully removed from the stash). 

We can "fix" this by overriding the default timeout, but we should determine
why the action=upload for a file (even one of just a few hundred KB) in the
stash takes upwards of 30 seconds. This is a severe performance regression that
seems to have started around the 1.19 deployment.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

--- Comment #10 from Erik Moeller  2012-05-10 02:06:08 UTC 
---
We deployed the timeout increase; please report if you still see this problem
in production. We're further investigating the reasons for the slow API
response. site_stats contention issues are currently a prime suspect.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

--- Comment #11 from Nemo_bis  2012-05-10 10:12:06 UTC 
---
Now I managed to upload
,
so I suppose the timeout increase worked for me.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

--- Comment #12 from Erik Moeller  2012-05-11 10:00:06 UTC 
---
Sorry, the previous patch was broken and actually had no effect on the timeout.
This one should do the trick once deployed:
https://gerrit.wikimedia.org/r/#/c/3808/

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 34785] Internal api error reported ( UploadStashFileNotFoundException )

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=34785

--- Comment #13 from Erik Moeller  2012-05-11 18:19:08 UTC 
---
Deployed. Confirmed that the timeout issue is fixed and users should no longer
see the error message in the last step. 

However, we still need to figure out why the last step is taking so long.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l