[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Nemo  changed:

   What|Removed |Added

 Resolution|LATER   |WONTFIX

--- Comment #19 from Nemo  2012-11-14 12:15:31 UTC ---
Switching from LATER to the second most relevant resolution for fear of
information loss.
http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/65116

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #18 from Antoine "hashar" Musso  2012-06-05 
19:57:31 UTC ---
I still think it is better in the hook but I guess the command line is an
acceptable workaround, even for long term :-]

Good to see that long lasting issue finally solved !

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #17 from Chad H.  2012-06-05 01:14:25 UTC 
---
(In reply to comment #16)
> Don't care anymore. This does the trick and was added to the translatewiki.net
> repocommit script:
> 
> for i in `ssh l10n-...@gerrit.wikimedia.org -p 29418 gerrit query 
> --format=TEXT
> owner:l10n-bot status:open |grep "  url:" |cut -d/ -f5`
> do
>   echo "Merging ${i}..."
>   ssh l10n-...@gerrit.wikimedia.org -p 29418 gerrit review $i,1 --code-review 
> 2
> --verified 1 --submit
> done

For what it's worth, that's what I suggested Antoine do originally when he was
overhauling the Translatewiki scripts--but he seemed to think doing it via a
hook was better.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Siebrand  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||LATER

--- Comment #16 from Siebrand  2012-06-05 01:00:08 UTC ---
Don't care anymore. This does the trick and was added to the translatewiki.net
repocommit script:

for i in `ssh l10n-...@gerrit.wikimedia.org -p 29418 gerrit query --format=TEXT
owner:l10n-bot status:open |grep "  url:" |cut -d/ -f5`
do
  echo "Merging ${i}..."
  ssh l10n-...@gerrit.wikimedia.org -p 29418 gerrit review $i,1 --code-review 2
--verified 1 --submit
done

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #15 from Chad H.  2012-05-22 18:43:13 UTC 
---
This should be fixed now since gerrit change 8037 was merged. Will know for
sure later today.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Siebrand  changed:

   What|Removed |Added

 Status|VERIFIED|REOPENED
 CC||ro...@wikimedia.org
 Resolution|FIXED   |

--- Comment #14 from Siebrand  2012-04-30 07:53:58 UTC ---
This broke again for an unknown reason last week. See
. These all had to be accepted
manually.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Antoine "hashar" Musso  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #13 from Antoine "hashar" Musso  2012-04-16 
14:37:55 UTC ---
The actual fix is https://gerrit.wikimedia.org/r/4792 . The options.uploader is
a user + email address field.

4804 prove the fix worked.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Chad H.  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #12 from Chad H.  2012-04-12 20:52:08 UTC 
---
We fixed this today \o/

https://gerrit.wikimedia.org/r/#change,4804

Long story short, I should've debugged the options.uploader a week ago. A
couple of minor things to adjust (like spam, etc) but those have their own
bugs.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #11 from Niklas Laxström  2012-04-12 
10:13:37 UTC ---
Chad, can you add the update I asked yesterday?

The week is nearing its end and I am planning to start i18n commits next week,
even if it means that somebody has to waste time clicking through all of the
commits and chasing someone else to accept the ones he can't.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #10 from Chad H.  2012-04-04 12:13:34 UTC 
---
I *believe* fixed this last night. I forgot that the hook is running as
gerrit[2] and the user lacked the rights to do the approve+submit. We can try
again.

Questions regarding whether or not to set verified or to wait for jenkins to do
that can be discussed afterwords.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #9 from Niklas Laxström  2012-04-04 
11:35:21 UTC ---
I would prefer to have this one fixed as soon as possible and improve it after
that.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #8 from Antoine "hashar" Musso  2012-04-04 11:26:36 
UTC ---
I would prefer us to run the tests and merge automatically upon success. Just
to be safe.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Niklas Laxström  changed:

   What|Removed |Added

 CC||aloli...@gmail.com,
   ||s.mazel...@xs4all.nl

--- Comment #7 from Niklas Laxström  2012-04-04 
11:24:35 UTC ---
(In reply to comment #6)
> Will the change get merged even if the Jenkins build fail ? :-D

It should never fail. We have been doing these exports for years without much
trouble.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #6 from Antoine "hashar" Musso  2012-04-04 09:19:27 
UTC ---
Will the change get merged even if the Jenkins build fail ? :-D

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #5 from Chad H.  2012-04-03 21:20:00 UTC 
---
(In reply to comment #3)
> Ok, we fixed and deployed this today. Attempted it for Gerrit change #4206, 
> did not
> work. Logs from around the time of the push are included (probably a lot of
> noise)[0].
> 
> Possible causes to investigate:
> * Logic bug in hook
> * Lack of permissions for user to auto-merge (this is done as Gerrit change 
> #2, right?)

Forgot the logs: http://p.defau.lt/?Xk0msgRkG9zibfacU40A2g

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #4 from Chad H.  2012-04-03 21:19:22 UTC 
---
(In reply to comment #3)
> * Lack of permissions for user to auto-merge (this is done as Gerrit change 
> #2, right?)

Silly auto-formatting. I meant that as the user gerrit[2]

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

--- Comment #3 from Chad H.  2012-04-03 21:18:27 UTC 
---
Ok, we fixed and deployed this today. Attempted it for gerrit 4206, did not
work. Logs from around the time of the push are included (probably a lot of
noise)[0].

Possible causes to investigate:
* Logic bug in hook
* Lack of permissions for user to auto-merge (this is done as gerrit2, right?)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Chad H.  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #2 from Chad H.  2012-03-30 19:32:33 UTC 
---
Submitted this in gerrit change 4020

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Antoine "hashar" Musso  changed:

   What|Removed |Added

 CC||has...@free.fr

--- Comment #1 from Antoine "hashar" Musso  2012-03-28 20:15:47 
UTC ---
The auto merge can be handled in the gerrit hook  "patchset-created"  which is
in operations/puppet.git : files/gerrit/hooks/patchset-created

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 35537] Commits from the l10n-bot should be merged immediately

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=35537

Chad H.  changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 AssignedTo|wikibugs-l@lists.wikimedia. |innocentkil...@gmail.com
   |org |
   Severity|normal  |critical

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l