[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 Dereckson changed: What|Removed |Added CC||dereck...@espace-win.org --- Comment #3 from Dereckson --- The parameter deprecation should be documented in RELEASE-NOTES-1.21 (section 1.20). Please take this opportunity to fix a delay, per Reedy suggestion ("say we'll remove it in X", you haven't set this X yet). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 --- Comment #4 from Dereckson --- Done, Gerrit change 40566. Do we maintain old versions RELEASE-NOTES files? I know FreeBSD project use RL errata for this purpose, e.g. http://www.freebsd.org/releases/9.0R/errata.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 Yuri Astrakhan changed: What|Removed |Added CC||yuriastrak...@gmail.com --- Comment #5 from Yuri Astrakhan --- A bit confused by the tokens implementation - there is a needsToken() which appears useless except to generate some help string, and yet many modules diligently override it. Also, in ApiMain.php / setupModule() has this line if ( $salt !== false && !$gettoken ) ... doesn't php give false when gettoken is ''? Lastly, the isset( $moduleParams['token'] ) - wouldn't that be always true even if the user didn't pass value (will be equal to null). Thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 --- Comment #6 from Yuri Astrakhan --- merged the HISTORY file - Gerrit change #40566 (even though was a bit reluctant - changing history is not the best way to do it). But its better to have it than not to mention it at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 Yuri Astrakhan changed: What|Removed |Added Status|NEW |RESOLVED Depends on||45199 Resolution|--- |FIXED --- Comment #7 from Yuri Astrakhan --- Closing as resolved. There is a relevant discussion in bug 45199 about restructuring tokens. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 Mark A. Hershberger changed: What|Removed |Added Priority|Unprioritized |Low CC||m...@everybody.org Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 --- Comment #1 from Beau 2012-04-25 16:57:26 UTC --- I think we should get rid of that. It is very confusing bug feature... -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 --- Comment #2 from Beau 2012-05-06 14:50:41 UTC --- I have submitted gerrit #6730 for review. This change marks gettoken parameter as deprecated. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 35993] gettoken should go die in a fire
https://bugzilla.wikimedia.org/show_bug.cgi?id=35993 Bug 35993 depends on bug 45199, which changed state. Bug 45199 Summary: API token handling needs to be less special-cased and hard-coded https://bugzilla.wikimedia.org/show_bug.cgi?id=45199 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l