https://bugzilla.wikimedia.org/show_bug.cgi?id=37484

       Web browser: ---
             Bug #: 37484
           Summary: [regression] Toolbar API to remove buttons is broken
           Product: MediaWiki extensions
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: WikiEditor
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: listenle...@gmail.com
                CC: kn.bugzi...@gmail.com, roan.katt...@gmail.com,
                    tpars...@wikimedia.org
    Classification: Unclassified
   Mobile Platform: ---


Steps to reproduce:

1. Open a page for editing.
2. Execute (copied from [1])
    /* Remove Search & Replace */
    $( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
            'section': 'advanced',
            'group': 'search',
            'tool': 'replace'
    });

Result in 1.20wmf4: The button for search&replace is removed.
Result in 1.20wmf5: Nothing happens.

https://gerrit.wikimedia.org/r/#/c/9751/ changed the wrapping for buttons from
<span> to <a> without changing it in the removeFromToolbar method, too.

[1]
https://www.mediawiki.org/wiki/Extension:WikiEditor/Toolbar_customization#Removing_things

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to