[Bug 38190] API help docs should document "token" as param-required for modules that use tokens
https://bugzilla.wikimedia.org/show_bug.cgi?id=38190 Umherirrender changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #6 from Umherirrender 2012-07-21 14:49:36 UTC --- successfully merged for core (under that this bug was filled) Please create seperate bugs for extensions. Thanks. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38190] API help docs should document "token" as param-required for modules that use tokens
https://bugzilla.wikimedia.org/show_bug.cgi?id=38190 --- Comment #5 from Umherirrender 2012-07-13 14:25:32 UTC --- (In reply to comment #4) > So it looks like this isn't working properly? It works (you have to set the user param, but it works), you get the token and a warning about "The gettoken parameter has been deprecated.". You code snap is from method ApiBase::getPossibleErrors which only gets all possible errors for action=paraminfo. it will never trigger the error. In ApiMain::setupModule the check for the token param exist. It looks like needsToken is superseeded by getTokenSalt. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38190] API help docs should document "token" as param-required for modules that use tokens
https://bugzilla.wikimedia.org/show_bug.cgi?id=38190
--- Comment #4 from Krinkle 2012-07-08 22:46:17 UTC ---
(In reply to comment #2)
> Sounds like a good idea, but you cannot set it for all modules with a token,
> because modules with "gettoken" (like block/unblock) needs a optional token
> param.
The modules have needsToken: return true;
And ApiBase:
if ( $params ) {
foreach ( $params as $paramName => $paramSettings ) {
if ( isset( $paramSettings[ApiBase::PARAM_REQUIRED] ) ) {
$ret[] = array( 'missingparam', $paramName );
}
}
}
/* .. */
if ( $this->needsToken() ) {
$ret[] = array( 'missingparam', 'token' );
/* .. */
So it looks like this isn't working properly?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38190] API help docs should document "token" as param-required for modules that use tokens
https://bugzilla.wikimedia.org/show_bug.cgi?id=38190 --- Comment #3 from Umherirrender 2012-07-07 06:29:36 UTC --- Done for core with gerrit 14608 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38190] API help docs should document "token" as param-required for modules that use tokens
https://bugzilla.wikimedia.org/show_bug.cgi?id=38190 Umherirrender changed: What|Removed |Added CC||umherirrender_de...@web.de --- Comment #2 from Umherirrender 2012-07-05 16:06:38 UTC --- Sounds like a good idea, but you cannot set it for all modules with a token, because modules with "gettoken" (like block/unblock) needs a optional token param. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38190] API help docs should document "token" as param-required for modules that use tokens
https://bugzilla.wikimedia.org/show_bug.cgi?id=38190 Krinkle changed: What|Removed |Added Summary|API help docs should set|API help docs should |"token" to param-required |document "token" as |for modules that use|param-required for modules |"token" and have|that use tokens |needsToken(), | |getTokenSalt() etc. set | -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
