[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Derk-Jan Hartman hartman.w...@gmail.com changed: What|Removed |Added CC||dann...@email.cz --- Comment #11 from Derk-Jan Hartman hartman.w...@gmail.com --- *** Bug 24488 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 --- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 53010 abandoned by Bartosz Dziewoński: (Bug 38487) Replaced the big with span in jquery.wikiEditor.toolbar.config.js Reason: Per consensus on the bug. https://gerrit.wikimedia.org/r/53010 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW Assignee|rahul14...@gmail.com|wikibugs-l@lists.wikimedia. ||org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords|patch-in-gerrit | Status|UNCONFIRMED |PATCH_TO_REVIEW Ever confirmed|0 |1 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Daniel Friesen mediawiki-b...@nadir-seen-fire.com changed: What|Removed |Added CC||mediawiki-bugs@nadir-seen-f ||ire.com Blocks|19719 |209 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 MZMcBride b...@mzmcbride.com changed: What|Removed |Added CC||b...@mzmcbride.com -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 --- Comment #8 from Michael M. listenle...@gmail.com --- (In reply to comment #5) [...] I'm not sure people actually want uglier wikitext. My suggestion was to remove big completely, not to replace it with (I agree with you) ugly HTML. I can only see to reasons to user bigger font size than usual: * headlines, these should use == ... ==, not big * texts in other scripts that are hard to read in normal font size (like Arabic), these should have a lang=... attribute, handle bidi correctly, etc. Adding some CSS to make them a bit bigger doesn't make things worse (it's inside a template in most cases anyway) This seems to be not only my opinion: en.wikipedia adds a button for small to the old toolbar, but not one for big [1], the same is true for a gadget on de.wikipedia [2] [1] [[MediaWiki:Common.js/edit.js]] [2] [[de:Wikipedia:Helferlein/Extra-Editbuttons]] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Siebrand s.mazel...@xs4all.nl changed: What|Removed |Added Keywords||patch-in-gerrit CC||s.mazel...@xs4all.nl Assignee|wikibugs-l@lists.wikimedia. |rahul14...@gmail.com |org | --- Comment #9 from Siebrand s.mazel...@xs4all.nl --- Gerrit 53010 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Niklas Laxström niklas.laxst...@gmail.com changed: What|Removed |Added CC||niklas.laxst...@gmail.com --- Comment #5 from Niklas Laxström niklas.laxst...@gmail.com --- Wikitext is not HTML. I'm not sure people actually want uglier wikitext. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Nemo federicol...@tiscali.it changed: What|Removed |Added Status|NEW |UNCONFIRMED CC||federicol...@tiscali.it Ever confirmed|1 |0 --- Comment #6 from Nemo federicol...@tiscali.it --- (In reply to comment #5) Wikitext is not HTML. I'm not sure people actually want uglier wikitext. Indeed, this should probably be rejected: I suggest WONTFIX. (Sorry Rahul for the unclear status of this bug.) For instance, I know some Wikimedia wikis where attempts at replacing simple markup with more correct HTML by bot were soundly and consistently rejected and forbidden. Wikis which want uglier wikitext can use Helder's solutions above, or bots. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Nemo federicol...@tiscali.it changed: What|Removed |Added Keywords|easy| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 --- Comment #7 from Rahul Maliakkal rahul14...@gmail.com --- (In reply to comment #6) Its okay,i am happy to contribute in any form! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Rahul Maliakkal rahul14...@gmail.com changed: What|Removed |Added CC||rahul14...@gmail.com --- Comment #4 from Rahul Maliakkal rahul14...@gmail.com --- Gerrit Change #53010 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Helder mybugs.m...@gmail.com changed: What|Removed |Added Keywords||easy --- Comment #1 from Helder mybugs.m...@gmail.com --- FYI, the button code is defined at https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/WikiEditor.git;a=blob;f=modules/jquery.wikiEditor.toolbar.config.js;hb=7adaa5434045fba764688fedb20820e7f2be4283#l359 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487
--- Comment #2 from Helder mybugs.m...@gmail.com ---
Instead of removing the button, its code could be changed to this:
--
'big': {
'labelMsg': 'wikieditor-toolbar-tool-big',
'type': 'button',
'icon': 'format-big.png',
'offset': [2, 2],
'action': {
'type': 'encapsulate',
'options': {
'pre': span style=\font-size: larger;\,
'periMsg': 'wikieditor-toolbar-tool-big-example',
'post': /span
}
}
},
--
A gadget could try to do this until the bug is fixed, but
--
$( '#wpTextbox1' ).wikiEditor( 'removeFromToolbar', {
'section': 'advanced',
'group': 'size',
'tool': 'big'
} ).wikiEditor( 'addToToolbar', {
'section': 'advanced',
'group': 'size',
'tools': {
'big': {
'labelMsg': 'wikieditor-toolbar-tool-big',
'type': 'button',
'icon': 'format-big.png',
'offset': [2, 2],
'action': {
'type': 'encapsulate',
'options': {
'pre': span style=\font-size: larger;\,
'periMsg': 'wikieditor-toolbar-tool-big-example',
'post': /span
}
}
}
}
} );
--
would put the button in the wrong position...
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487
--- Comment #3 from Helder mybugs.m...@gmail.com ---
(In reply to comment #2)
A gadget could try to do this until the bug is fixed
Here is another way:
--
// Workaround for [[bugzilla:38487]]
function fixBigButton(){
$( '.tool-button[rel=big]' )
.off( 'click' )
.on( 'click', function( e ){
e.preventDefault();
$( '#wpTextbox1' ).textSelection(
'encapsulateSelection', {
'pre': 'span style=font-size: larger;',
'peri': mw.msg( 'wikieditor-toolbar-tool-big-example' ),
'post': '/span'
}
);
} );
}
if ( $.inArray( mw.config.get( 'wgAction' ), ['edit', 'submit'] ) !== -1 ) {
mw.loader.using( 'user.options', function () {
if ( mw.user.options.get('usebetatoolbar') ) {
mw.loader.using( [ 'jquery.textSelection', 'ext.wikiEditor.toolbar' ],
function () {
$( fixBigButton );
} );
}
} );
}
--
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 mybugs.m...@gmail.com changed: What|Removed |Added Keywords||javascript CC||mybugs.m...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 38487] Remove button for big from toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=38487 Michael M. listenle...@gmail.com changed: What|Removed |Added Blocks||19719 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
