[Bug 40820] Call to undefined method CreditsAction::getCredits()

2012-10-07 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40820

Krenair  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED

--- Comment #7 from Krenair  2012-10-07 21:05:16 UTC ---
Merged by Reedy.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40820] Call to undefined method CreditsAction::getCredits()

2012-10-07 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40820

Thomas Bleher  changed:

   What|Removed |Added

 CC||thomasble...@gmx.de

--- Comment #6 from Thomas Bleher  2012-10-07 08:40:57 UTC 
---
This change also breaks the DumpHTML extension for me. It errors out with the
same message:
PHP Fatal error:  Call to undefined method CreditsAction::getCredits() in
/srv/www/mediawiki/core/includes/SkinTemplate.php on line 339

I did a git bisect to narrow the error down to this commit. Reverting it makes
DumpHTML work again. Please fix this error!

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40820] Call to undefined method CreditsAction::getCredits()

2012-10-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40820

--- Comment #5 from Tim Landscheidt  2012-10-06 
16:15:27 UTC ---
(In reply to comment #1)
> > Obviously, includes/actions/CreditsAction.php has 
> > CreditsAction::getCredits(),
> > but I haven't tracked this down further yet.

> No it doesn't, as of the revision you suggested
> [...]

Confused two directories with different checkouts; you're right, of course.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40820] Call to undefined method CreditsAction::getCredits()

2012-10-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40820

--- Comment #4 from Tim Landscheidt  2012-10-06 
16:12:27 UTC ---
(In reply to comment #2)
> [...]
> I guess you've got a max credits value of > 0

Yes, it was set to 1.  Setting it to 0 works.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40820] Call to undefined method CreditsAction::getCredits()

2012-10-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40820

Krenair  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #3 from Krenair  2012-10-06 15:56:51 UTC ---
Gerrit change 26945

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40820] Call to undefined method CreditsAction::getCredits()

2012-10-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40820

--- Comment #2 from Sam Reed (reedy)  2012-10-06 15:49:55 
UTC ---
/**
 * Set this to the number of authors that you want to be credited below an
 * article text. Set it to zero to hide the attribution block, and a negative
 * number (like -1) to show all authors. Note that this will require 2-3 extra
 * database hits, which can have a not insignificant impact on performance for
 * large wikis.
 */
$wgMaxCredits = 0;

/** If there are more than $wgMaxCredits authors, show $wgMaxCredits of them.
 * Otherwise, link to a separate credits page. */
$wgShowCreditsIfMax = true;


I guess you've got a max credits value of > 0

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40820] Call to undefined method CreditsAction::getCredits()

2012-10-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=40820

Sam Reed (reedy)  changed:

   What|Removed |Added

 AssignedTo|wikibugs-l@lists.wikimedia. |kren...@gmail.com
   |org |

--- Comment #1 from Sam Reed (reedy)  2012-10-06 15:48:52 
UTC ---
The somewhat obfuscated usage doesn't help:

$tpl->set( 'credits', Action::factory( 'credits', $this->getWikiPage(),
$this->getContext() )->getCredits( $wgMaxCredits,
$wgShowCreditsIfMax ) );



My dev wiki is working fine though

(In reply to comment #0)
> Obviously, includes/actions/CreditsAction.php has CreditsAction::getCredits(),
> but I haven't tracked this down further yet.

No it doesn't, as of the revision you suggested

class CreditsAction extends FormlessAction {

public function getName() {
return 'credits';
}

/**
 * This is largely cadged from PageHistory::history
 *
 * @return String HTML
 */
public function onView() {
$this->getOutput()->redirect( $this->getTitle()->getLocalURL(
"action=info" ) );
}
}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l