[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #22 from wiki.pe...@icloud.com 2012-11-07 08:21:28 UTC ---
OK, many thanks for that.  I shall get around to that when I have some more
spare moments (and meanwhile try to remember to visually double-check the box
to see if it's appropriately ticked or not!)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #23 from wiki.pe...@icloud.com 2012-11-08 05:41:35 UTC ---
I've removed a ton of scripts, but it still seems to be doing it (I missed a
couple this morning).  Any m ore ideas?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #10 from wiki.pe...@icloud.com 2012-11-06 09:17:17 UTC ---
I'm sorry, I don't quite understand which html you're referring to, and where;
could you please clarify?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #11 from Liangent liang...@gmail.com 2012-11-06 09:19:30 UTC ---
(In reply to comment #10)
 I'm sorry, I don't quite understand which html you're referring to, and where;
 could you please clarify?

Page source of the editing interface.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #12 from wiki.pe...@icloud.com 2012-11-06 14:54:06 UTC ---
I haz minordefault:0 in the html, but (as I suspected, on the page I
checked on) the minor edit box was checked.  Is that helpful?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #13 from Brad Jorsch bjor...@wikimedia.org 2012-11-06 17:39:50 
UTC ---
Depending on your browser, there should be a View Source or View Page
Source somewhere; Google for how to view page source in $BROWSER for the
appropriate value of $BROWSER.

Somewhere in all the HTML code you see, there should be something that
resembles this:

  input name=wpMinoredit type=checkbox value=1 tabindex=3
accesskey=i id=wpMinoredit /

What you're looking for begins with 'input', ends with '', and has
'name=wpMinoredit' in the middle. If you just copy and paste that tag in
here, that will answer the question.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #14 from wiki.pe...@icloud.com 2012-11-06 18:53:29 UTC ---
Aha!  It has input name=wpMinoredit type=checkbox value=1 tabindex=3
accesskey=i id=wpMinoredit /, and the minor edit box is ticked (I tried
the same page I tried before, on which my previous edit had been marked as
minor).

Aaaand ... on another page , it says input name=wpMinoredit type=checkbox
value=1 tabindex=3 accesskey=i id=wpMinoredit /, but the minor edit
checkbox is NOT ticked. Hmm.  So what does that mean, then?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #15 from Brad Jorsch bjor...@wikimedia.org 2012-11-06 18:59:00 
UTC ---
It means that the checkbox is not being served as checked in the HTML; either
your browser is pre-filling it or some JavaScript on the page is checking it.

You could try removing all your user scripts and see if the problem goes away,
then add them back one by one until it reappears.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #16 from wiki.pe...@icloud.com 2012-11-06 19:08:22 UTC ---
I can try (bummer, though ) removing all my user scripts.  Why would a user
script make it mark edits as minor ONLY on pages where the previous edit had
been minor?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #17 from Brad Jorsch bjor...@wikimedia.org 2012-11-06 20:23:53 
UTC ---
Because whoever wrote it thought that would be a feature?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

Liangent liang...@gmail.com changed:

   What|Removed |Added

   See Also|https://bugzilla.wikimedia. |
   |org/show_bug.cgi?id=24313   |
 Depends on|24313   |

--- Comment #18 from Liangent liang...@gmail.com 2012-11-07 05:24:05 UTC ---
Then unrelated to bug 24313...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 CC||federicol...@tiscali.it

--- Comment #19 from Nemo federicol...@tiscali.it 2012-11-07 05:52:54 UTC ---
Can you please tell us your user name?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #20 from wiki.pe...@icloud.com 2012-11-07 06:36:46 UTC ---
ThatPeskyCommoner (enwiki)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||INVALID

--- Comment #21 from Nemo federicol...@tiscali.it 2012-11-07 07:15:28 UTC ---
Ah, ok, I saw that one and its contributions but got lost on Jimbo-talk muds
while looking for false minor edits in vain.
Then you must be using monobook and
https://en.wikipedia.org/?diff=457283933oldid=454508994 explains it, you're
importing a ton of stuff for wikignomes including 

function Ohc_edit_summary1(){
//Add a tag to the summary box
setoptions(minor='true'); //removed ,watch='false' in response to
user notification 13 Nov. 2010
setreason('[[User:Ohconfucius/script|script]]-assisted [[WP:MOS|style]]
audit, incl. [[WP:MOSDATES|dates]], [[MOS:LINK]] and [[MOS:TEXT]]', 'append');
doaction('diff');
}

function Ohc_edit_summary2(){
// Add a tag to the summary box
setoptions(minor='true'); //removed ,watch='false' in response to
user notification 13 Nov. 2010
setreason('[[User:Ohconfucius/script|script]]-assisted [[WP:MOS|style]]
audit, incl. [[WP:ENGVAR|English variants]], [[WP:MOSDATES|dates]],
[[MOS:LINK]] and [[MOS:TEXT]]', 'append');
doaction('diff');
}

[the latter two times, on your monobook.js and in the script you import].
You have to remove all the stuff you're unsure of/you don't need, check if
there are changes to other scripts you import etc. Nothing to do here on
bugzilla.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #8 from wiki.pe...@icloud.com 2012-11-05 21:48:42 UTC ---
If the edit form has sections capable of being pre-filled by a browser,
something should be put in place to prevent that from happening, ideally.  It
shouldn't be a pre-fillable field.  Having said that, my browser doesn't
pre-fill edit summaries, for example (though it does make suggestions, which I
have, once or twice, inadvertently used just by not noticing that it had added
bits I didn't intend to add!)

I don't think I have any user scripts which would check it on some occasions
but not on others.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #9 from Liangent liang...@gmail.com 2012-11-06 01:48:27 UTC ---
(In reply to comment #8)
 If the edit form has sections capable of being pre-filled by a browser,
 something should be put in place to prevent that from happening, ideally.  It
 shouldn't be a pre-fillable field.  Having said that, my browser doesn't
 pre-fill edit summaries, for example (though it does make suggestions, which I
 have, once or twice, inadvertently used just by not noticing that it had added
 bits I didn't intend to add!)
 
 I don't think I have any user scripts which would check it on some occasions
 but not on others.

Can you confirm whether it's already ticked in HTML sent to you?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

Liangent liang...@gmail.com changed:

   What|Removed |Added

 CC||liang...@gmail.com

--- Comment #1 from Liangent liang...@gmail.com 2012-11-04 09:06:11 UTC ---
Most likely you checked Mark all edits minor by default in your preferences.
If you can't find that item now try to reset your preferences
([[Special:Preferences/reset]]).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #2 from wiki.pe...@icloud.com 2012-11-04 11:22:10 UTC ---
Oh!  Can't someone just make it possible to reset just that one preference?  I
looked for it, but it wasn't there - and I certainly don't want to reset ALL my
preferences!  Also, it's not marking all of them as minor by default - only
those ones where the previous edit was marked as minor.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #3 from Liangent liang...@gmail.com 2012-11-04 11:39:03 UTC ---
(In reply to comment #2)
 Oh!  Can't someone just make it possible to reset just that one preference?  I
 looked for it, but it wasn't there - and I certainly don't want to reset ALL 
 my
 preferences!

But to reset only one, you have to tell the system which preference you want to
reset -- but if you can find that preference you can simply flip its setting...

To help you find and confirm it: it should be located in the Advanced options
section in Editing tab.

 Also, it's not marking all of them as minor by default - only
 those ones where the previous edit was marked as minor.

Is your browser pre-filling it from previously submitted form?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

Jesús Martínez Novo (Ciencia Al Poder) martinezn...@gmail.com changed:

   What|Removed |Added

 CC||martinezn...@gmail.com

--- Comment #4 from Jesús Martínez Novo (Ciencia Al Poder) 
martinezn...@gmail.com 2012-11-04 11:53:58 UTC ---
On the english wikipedia that option isn't appearing in [[Special:Preferences]]
for me, and it's not hidden by CSS or removed by JS.

That option is appearing using the API (search for minordefault):

http://en.wikipedia.org/w/api.php?action=querymeta=userinfouiprop=optionsformat=jsonfm

So you probably can change it with the API:

http://en.wikipedia.org/w/api.php?action=helpmodules=options

If some options are hidden (
http://www.mediawiki.org/wiki/Manual:$wgHiddenPrefs ), they should probably do
not apply at all instead of still being applied to users that changed them.

Note that some edits are not allowed to be minor, like new section creation or
the creation of a new page. That would explain the randomness.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #5 from Liangent liang...@gmail.com 2012-11-04 12:07:18 UTC ---
(In reply to comment #4)
 On the english wikipedia that option isn't appearing in 
 [[Special:Preferences]]
 for me, and it's not hidden by CSS or removed by JS.

Hmm it was turned off in bug 24313.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

Liangent liang...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=24313

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

--- Comment #6 from Liangent liang...@gmail.com 2012-11-04 12:09:41 UTC ---
(In reply to comment #4)
 If some options are hidden (
 http://www.mediawiki.org/wiki/Manual:$wgHiddenPrefs ), they should probably do
 not apply at all instead of still being applied to users that changed them.

I guess this can be a valid bug. Should this bug be used to track this
$wgHiddenPrefs issue, or create a new bug for it?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

Liangent liang...@gmail.com changed:

   What|Removed |Added

 Depends on||24313

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41760] Minor edit checkbox seems to be ticked as default sometimes!

2012-11-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41760

Brad Jorsch bjor...@wikimedia.org changed:

   What|Removed |Added

 CC||bjor...@wikimedia.org

--- Comment #7 from Brad Jorsch bjor...@wikimedia.org 2012-11-04 16:49:00 UTC 
---
(In reply to comment #4)
 If some options are hidden (
 http://www.mediawiki.org/wiki/Manual:$wgHiddenPrefs ), they should probably do
 not apply at all instead of still being applied to users that changed them.

They don't. See includes/User.php, every pref that is hidden is automatically
reset to the default when accessed in both getOption() and getOptions().

(In reply to comment #3)
 Is your browser pre-filling it from previously submitted form?

This is probably what's going on here. Or else they have a user script
installed that remembers the setting of the checkbox and changes it.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l