[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Nischay Nahata changed: What|Removed |Added Keywords|patch-in-gerrit,| |patch-need-review | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Andre Klapper changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #14 from Andre Klapper --- https://gerrit.wikimedia.org/r/#/c/32189/ was merged on December 23, 2012. Hence I'm closing this as FIXED as I cannot see anything left to do for this request. Please reopen if I'm wrong, and elaborate what's left. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Krenair changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #13 from Krenair --- Everything in Bugzilla is a 'bug', even when it's actually an enhancement request. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 --- Comment #12 from Victor Danilchenko --- I am not sure why it's a bug... it's an improvement. The functionality prior to this patch was not broken, merely absent. yea, new enhancement should be the proper classification for this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 --- Comment #11 from Nischay Nahata --- (In reply to comment #10) > There's nothing in the history about it, must've always been unconfirmed. New+enhancement sounds better to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Krenair changed: What|Removed |Added CC||kren...@gmail.com --- Comment #10 from Krenair --- (In reply to comment #9) > Also not sure why this bug is now marked Unconfirmed There's nothing in the history about it, must've always been unconfirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 --- Comment #9 from Nischay Nahata --- (In reply to comment #7) > I already received commit privileges, but frankly I simply don't feel > qualified > to make commits directly yet. You don't have to be qualified for this, you won't be changing the code directly but putting up code for review for other "qualified" developers. Also not sure why this bug is now marked Unconfirmed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 --- Comment #8 from Andre Klapper --- Victor: Gerrit is not about committing directly. It's also a review tool for patches, that's why I asked if you could put patches there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 --- Comment #7 from Victor Danilchenko --- I already received commit privileges, but frankly I simply don't feel qualified to make commits directly yet. I will likely do so at some point in the future, but for now I feel it safest to let those far more qualified than I handle the logistics around getting the code into the codebase. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 --- Comment #6 from Andre Klapper --- Victor: Thanks for the updated patch! Did you have time / are you interested in getting developer access? See http://www.mediawiki.org/wiki/Developer_access -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Victor Danilchenko changed: What|Removed |Added Attachment #11318|0 |1 is obsolete|| --- Comment #5 from Victor Danilchenko --- Created attachment 11468 --> https://bugzilla.wikimedia.org/attachment.cgi?id=11468&action=edit The FIXED patch to add a new hook, 'ThumbnailBeforeProduceHTML', to ThumbnailImage::toHtml method, in order to permit the user to manipulate the image attributes before the HTML is rendered I removed the cargo-cult wrap around the hook call. Due to the nature of the hook, no special processing is needed in case one of the hook calls fails. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 --- Comment #4 from Nischay Nahata 2012-12-02 15:00:00 UTC --- (In reply to comment #0) I already made a gerrit patch for you, but your patch seems to have some errors which I don't know how to fix. Please see https://gerrit.wikimedia.org/r/#/c/32189/ -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Nischay Nahata changed: What|Removed |Added Keywords||patch-in-gerrit CC||nischay...@gmail.com --- Comment #3 from Nischay Nahata 2012-11-07 05:35:30 UTC --- I made a patchset for you https://gerrit.wikimedia.org/r/#/c/32189/ Please consider making an account on gerrit so you can do this yourself in future, it enables you to get code review faster. http://www.mediawiki.org/wiki/Developer_access -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 --- Comment #2 from Victor Danilchenko 2012-11-06 21:35:46 UTC --- Created attachment 11319 --> https://bugzilla.wikimedia.org/attachment.cgi?id=11319 The documentation patch for the ThumbnailBeforeProduceHTML hook As requested, the patch for the docs/hooks.txt file. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Sam Reed (reedy) changed: What|Removed |Added Keywords||patch-need-review --- Comment #1 from Sam Reed (reedy) 2012-11-06 21:23:25 UTC --- You should also add some documentation for this hook to docs/hooks.txt -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Sam Reed (reedy) changed: What|Removed |Added CC||bawolff...@gmail.com Component|API |File management Severity|normal |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 41835] Requesting a new hook to allow manipulation of image data (e.g. src attribute) before the image is rendered
https://bugzilla.wikimedia.org/show_bug.cgi?id=41835 Sam Reed (reedy) changed: What|Removed |Added Attachment #11318|0 |1 is patch|| Attachment #11318|application/octet-stream|text/plain mime type|| -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
