[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

Brad Jorsch  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED

--- Comment #15 from Brad Jorsch  2012-11-26 16:30:11 
UTC ---
Since 1 and 2 are both merged now, I'm going to close this bug. Bug 41889 is
still open for that issue.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

--- Comment #14 from Andre Klapper  2012-11-26 16:27:04 
UTC ---
Brad: Thanks for the analysis!

The patches for 1. and 2. are merged, so only Icb674f7e for bug 41889 is left.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

--- Comment #13 from Brad Jorsch  2012-11-19 17:54:01 
UTC ---
(In reply to comment #12)
> Actually, not fixed yet; sorry for the confusion.
> 
> This bug would be fixed by change I89766c96 (mine), which isn't yet merged; 
> the
> merged one, Ibe4cc7e9 (Brad's), fixes bug 41889 (which was split from this
> one).

There are actually three issues mentioned here:
1. The original bug reported here, that tablesorter was exploding rowspans on
page load instead of on first sort. That is fixed by Ibe4cc7e9.
2. The bug this transformed into, that tablesorter doesn't sort correctly when
headers are colspanned. That is fixed by I89766c96, once someone merges it.
3. Bug 41889, that tablesorter gets cells out of order when row header cells
are involved. I just submitted Icb674f7e to fix that one.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

Bartosz Dziewoński  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |

--- Comment #12 from Bartosz Dziewoński  2012-11-16 
22:00:12 UTC ---
Actually, not fixed yet; sorry for the confusion.

This bug would be fixed by change I89766c96 (mine), which isn't yet merged; the
merged one, Ibe4cc7e9 (Brad's), fixes bug 41889 (which was split from this
one).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-16 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

Bartosz Dziewoński  changed:

   What|Removed |Added

   Keywords|need-unittest,  |
   |patch-in-gerrit |
 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #11 from Bartosz Dziewoński  2012-11-16 
21:45:35 UTC ---
Change merged.

Should this be backported and deployed, maybe?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

--- Comment #10 from Andre Klapper  2012-11-14 13:46:55 
UTC ---
This hasn't gotten in yet - could anybody do a review in gerrit?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

--- Comment #9 from Brad Jorsch  2012-11-09 19:51:25 UTC 
---
Gerrit changeset 32593 fixes the original bug reported here (rowspans being
exploded automatically).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

Andre Klapper  changed:

   What|Removed |Added

   Keywords||need-unittest

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

Bartosz Dziewoński  changed:

   What|Removed |Added

   Keywords||patch-in-gerrit

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

--- Comment #8 from Bartosz Dziewoński  2012-11-09 
16:54:11 UTC ---
Fixed in I89766c96. The headers now sort on all the columns they span over.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 41886] [regression] tablesorter doesn't handle headers with colspan properly

2012-11-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=41886

Bartosz Dziewoński  changed:

   What|Removed |Added

Summary|[regression] tablesorter|[regression] tablesorter
   |explodes rowspans now   |doesn't handle headers with
   |before ever clicking sort   |colspan properly

--- Comment #7 from Bartosz Dziewoński  2012-11-09 
15:58:04 UTC ---
Changing description from "tablesorter explodes rowspans now before ever
clicking sort" to "tablesorter doesn't handle headers with colspan properly",
as I understand that this is the real problem.

I'll try to look into it.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l