[Bug 43269] memcached keys too long

2012-12-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=43269

Yuvi Panda yuvipa...@gmail.com changed:

   What|Removed |Added

   Keywords||easy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 43269] memcached keys too long

2012-12-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=43269

Niklas Laxström niklas.laxst...@gmail.com changed:

   What|Removed |Added

 CC||niklas.laxst...@gmail.com

--- Comment #1 from Niklas Laxström niklas.laxst...@gmail.com ---
What's the maximum length?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 43269] memcached keys too long

2012-12-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=43269

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

 CC||aklap...@wikimedia.org

--- Comment #2 from Andre Klapper aklap...@wikimedia.org ---
What's the practical influence of this? Asking as
http://ta.wikisource.org/wiki/திருவிவிலியம்/இணைத்_திருமுறை_நூல்கள்/பாரூக்கு_(எரேமியாவின்_மடல்)/அதிகாரங்கள்_5_முதல்_6_வரை
still shows and offers http://ta.wikisource.org/s/30q as a ShortURL which
works...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 43269] memcached keys too long

2012-12-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=43269

--- Comment #3 from Yuvi Panda yuvipa...@gmail.com ---
It hits the database everytime that is queried, so not as performant as it
should be. Plus of course, not the 'right' thing to do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 43269] memcached keys too long

2012-12-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=43269

--- Comment #4 from Ori Livneh o...@wikimedia.org ---
(In reply to comment #1)
 What's the maximum length?

The maximum length is 250 *bytes*:
https://github.com/memcached/memcached/blob/master/doc/protocol.txt

(In reply to comment #2)
 What's the practical influence of this? Asking as
 http://ta.wikisource.org/wiki/திருவிவிலியம்/இணைத்_திருமுறை_நூல்கள்/
 பாரூக்கு_(எரேமியாவின்_மடல்)/அதிகாரங்கள்_5_முதல்_6_வரை
 still shows and offers http://ta.wikisource.org/s/30q as a ShortURL which
 works...

You could have overlapping keys if the difference between them exists beyond
the 250 character mark.

There's a simple solution to this, and it's to hash the title before using it
in a key. sha1($title) will give you a 40-byte string.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l