[Bug 44907] ResourceLoader: Invalid argument supplied for foreach

2014-06-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=44907

Mark A. Hershberger m...@everybody.org changed:

   What|Removed |Added

 CC||m...@everybody.org
   Target Milestone|1.21.x release  |---

--- Comment #4 from Mark A. Hershberger m...@everybody.org ---
Removing target milestone that was in the past.

If you want this in a specific release, have a good reason AND you are willing
to find resources to fix this bug, feel free to change it to something
appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 44907] ResourceLoader: Invalid argument supplied for foreach

2013-05-25 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=44907

Nemo federicol...@tiscali.it changed:

   What|Removed |Added

   Target Milestone|1.21.0 release  |1.21.x release

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 44907] ResourceLoader: Invalid argument supplied for foreach

2013-04-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=44907

Tyler Romeo tylerro...@gmail.com changed:

   What|Removed |Added

 CC||tylerro...@gmail.com

--- Comment #3 from Tyler Romeo tylerro...@gmail.com ---
So I did a quick grep on the core, and $db-ignoreErrors() is not called
anywhere. The function is literally unused. The only reason I can think of for
this error occurring is if DBO_IGNORE is set in the flags for starting the
database connection.

On that note, is it really sane to be returning false from $dbr-select()? If
the ignore errors flag was set, it means the caller doesn't give a damn about
errors whatsoever. I feel like the correct behavior would be to return some
sort of empty fake result wrapper.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 44907] ResourceLoader: Invalid argument supplied for foreach

2013-03-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=44907

Umherirrender umherirrender_de...@web.de changed:

   What|Removed |Added

 CC||umherirrender_de...@web.de

--- Comment #2 from Umherirrender umherirrender_de...@web.de ---
Database::select
 * @return ResultWrapper. If the query returned no rows, a ResultWrapper
 *   with no rows in it will be returned. If there was a query error, a
 *   DBQueryError exception will be thrown, except if the ignore errors
 *   option was set, in which case false will be returned.


Someone leaks the ignore error option here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 44907] ResourceLoader: Invalid argument supplied for foreach

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=44907

--- Comment #1 from Krinkle krinklem...@gmail.com ---
--- class ResourceLoaderWikiModule
--- protected function getTitleMtimes
if ( !$batch-isEmpty() ) {
$res = $dbr-select( 'page',
array( 'page_namespace', 'page_title', 'page_touched' ),
$batch-constructSet( 'page', $dbr ),
__METHOD__
);
foreach ( $res as $row ) {

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 44907] ResourceLoader: Invalid argument supplied for foreach

2013-02-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=44907

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 Blocks||700
   Target Milestone|--- |1.21.0 release

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l