[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

MZMcBride  changed:

   What|Removed |Added

 CC||b...@mzmcbride.com

--- Comment #1 from MZMcBride  ---
From
:

---
-- Name/value pairs indexed by page_id
CREATE TABLE /*_*/page_props (
  pp_page int NOT NULL,
  pp_propname varbinary(60) NOT NULL,
  pp_value blob NOT NULL
) /*$wgDBTableOptions*/;

CREATE UNIQUE INDEX /*i*/pp_page_propname ON /*_*/page_props
(pp_page,pp_propname);
---

What index are you proposing, exactly?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

Daniel Friesen  changed:

   What|Removed |Added

 CC||mediawiki-bugs@nadir-seen-f
   ||ire.com

--- Comment #2 from Daniel Friesen  ---
Presumably:
CREATE UNIQUE INDEX /*i*/pp_propname ON /*_*/page_props
(pp_propname);

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

--- Comment #3 from Daniel Friesen  ---
Sorry, drop the 'UNIQUE'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

--- Comment #4 from jeb...@gmail.com ---
Yes, exactly! :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

MZMcBride  changed:

   What|Removed |Added

   Keywords||schema-change
 CC||afeld...@wikimedia.org

--- Comment #5 from MZMcBride  ---
> CREATE INDEX /*i*/pp_propname ON /*_*/page_props(pp_propname);

This bug can probably be marked "easy" then, once a database person (like
Asher) signs off, then?

I believe "schema-change" already applies, so I'm adding that keyword now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

--- Comment #6 from jeb...@gmail.com ---
The change is easy, but the load right after the change could create problems.
That should be given consideration, but I don't think the load will be very
high after the index is created.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

--- Comment #7 from Daniel Friesen  ---
(In reply to comment #6)
> The change is easy, but the load right after the change could create
> problems.
> That should be given consideration, but I don't think the load will be very
> high after the index is created.

Last I checked large installations apply schema updates manually and they
rotate slaves out in batches only upgrading part of the cluster at a time while
the rest of the cluster keeps taking care of the load.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
Version|unspecified |1.21-git

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

Umherirrender  changed:

   What|Removed |Added

 CC||umherirrender_de...@web.de

--- Comment #8 from Umherirrender  ---
Sounds like fixed with gerrit 44260

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 45316] Column pp_propname in table PageProps should have an index

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=45316

Bartosz Dziewoński  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||bjor...@wikimedia.org,
   ||matma@gmail.com
 Resolution|--- |FIXED
   Target Milestone|--- |1.22.0 release

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l