[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Brad Jorsch changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Brad Jorsch --- Change merged. Note the fix should be deployed on WMF wikis with 1.22wmf3; see https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap for the schedule. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 --- Comment #10 from Gerrit Notification Bot --- https://gerrit.wikimedia.org/r/58306 (Gerrit Change I27203c767d1d3f2f0999b1b1d8a06e8cf68c19ed) | change APPROVED and MERGED [by Tim Starling] -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 --- Comment #9 from Michael M. --- *** Bug 29677 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Brad Jorsch changed: What|Removed |Added CC||h...@online.de --- Comment #8 from Brad Jorsch --- *** Bug 45953 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Brad Jorsch changed: What|Removed |Added CC||listenle...@gmail.com --- Comment #7 from Brad Jorsch --- *** Bug 39498 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 --- Comment #6 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/58306 (Gerrit Change I27203c767d1d3f2f0999b1b1d8a06e8cf68c19ed) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 --- Comment #5 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/58306 (Gerrit Change I27203c767d1d3f2f0999b1b1d8a06e8cf68c19ed) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Brad Jorsch changed: What|Removed |Added Keywords||upstream --- Comment #4 from Brad Jorsch --- Bug filed upstream at https://sourceforge.net/p/geshi/bugs/223/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Brad Jorsch changed: What|Removed |Added CC||mrstradivarius.bugzilla@gma ||il.com --- Comment #3 from Brad Jorsch --- *** Bug 47026 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Brad Jorsch changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=36839 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Brad Jorsch changed: What|Removed |Added CC||yper...@in2p3.fr --- Comment #2 from Brad Jorsch --- *** Bug 46753 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Andre Klapper changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 45669] GeSHi uses a highly recursive regex for number highlighting
https://bugzilla.wikimedia.org/show_bug.cgi?id=45669 Brad Jorsch changed: What|Removed |Added Keywords||code-update-regression CC||bjor...@wikimedia.org, ||o...@wikimedia.org Summary|Module page truncates very |GeSHi uses a highly |large modules |recursive regex for number ||highlighting --- Comment #1 from Brad Jorsch --- This seems to be due to Gerrit change 49985, which also explains why it suddenly screwed up upon crossing 200K. For number highlighting, GeSHi uses a regex that includes "(?!(?:|(?>[^\<]))+>)". If there is too long of a run in the text without anything being highlighted other than numbers, this can easily exceed the pcre recursion limit (which is currently set very low on WMF wikis, see bug 36839 for a similar issue) and causes GeSHi to lose the entire chunk. Possible fixes include changing that regex (defined on geshi/geshi.php line 2135) to "(?!(?:|(?>[^\<]+))+>)" which is much less likely to hit the recursion limit or disabling number highlighting along with string highlighting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
