[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 abraham.taheriv...@wikimedia.de changed: What|Removed |Added Status|RESOLVED|VERIFIED CC||abraham.taherivand@wikimedi ||a.de --- Comment #7 from abraham.taheriv...@wikimedia.de --- Verified in Wikidata demo July 31th. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 73942 merged by jenkins-bot: (bug 46352) Implement EntityHandler::getUndoContent https://gerrit.wikimedia.org/r/73942 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 73942 had a related patch set uploaded by Daniel Kinzler: (bug 46352) Implement EntityHandler::getUndoContent https://gerrit.wikimedia.org/r/73942 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 denny vrandecic denny.vrande...@wikimedia.de changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352
--- Comment #4 from Daniel Kinzler daniel.kinz...@wikimedia.de ---
I poked at this a bit; as it turns out, ApiEditPage has it's own undo logic. So
instead of diverting that (as suggested above) into Wikibase\EditEntityAction
somehow, we should implement EntityContent::getUndoContent() based on
EntityDiffer.
Note that WikibaseHooks::onApiCheckCanExecute currently prevents ApiEditPage
from working on wikibase entities. We'll need to make an exception there:
if ( isset( $params['undo'] ) $params['undo'] 0 ) {
// We don't allow direct editing, but direct undoing is ok!
return true;
}
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 denny vrandecic denny.vrande...@wikimedia.de changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 denny vrandecic denny.vrande...@wikimedia.de changed: What|Removed |Added Keywords||need-volunteer Priority|Unprioritized |Low CC||denny.vrandecic@wikimedia.d ||e Severity|normal |enhancement --- Comment #2 from denny vrandecic denny.vrande...@wikimedia.de --- Investigate whether the API action edit works with the undo and undoafter parameters does already work or not. This might already be working. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added Priority|Low |Unprioritized CC||daniel.kinz...@wikimedia.de Severity|enhancement |normal --- Comment #3 from Daniel Kinzler daniel.kinz...@wikimedia.de --- Specifically, the API should be using the EditEntityAction class to perform these actions on Wikibase entitites. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 db duplicate...@googlemail.com changed: What|Removed |Added CC||duplicate...@googlemail.com --- Comment #1 from db duplicate...@googlemail.com --- The line based diff is only a problem, when the undo rev needs merge. But it works for gui, so there should not be a problem to have it in api -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46352] Undo operations in the Wikibase API
https://bugzilla.wikimedia.org/show_bug.cgi?id=46352 jeb...@gmail.com changed: What|Removed |Added Summary|Undo operations in the API |Undo operations in the ||Wikibase API -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
