[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Mark A. Hershberger m...@everybody.org changed: What|Removed |Added CC||m...@everybody.org Flags|Backport_to_Stable? |Backport_to_Stable- --- Comment #15 from Mark A. Hershberger m...@everybody.org --- Doesn't cleanly cherry pick. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added CC||hexm...@gmail.com --- Comment #14 from Andre Klapper aklap...@wikimedia.org --- (In reply to comment #13) -- Backport_to_Stable flag set to ? hexmode: ping? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Ori Livneh o...@wikimedia.org changed: What|Removed |Added CC||o...@wikimedia.org --- Comment #12 from Ori Livneh o...@wikimedia.org --- This patch should be back-ported to the release branch. A user just logged on IRC to report that this issue broke his/her MediaWiki instance after upgrading to RHEL_1_21. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Flags||Backport_to_Stable? --- Comment #13 from Andre Klapper aklap...@wikimedia.org --- (In reply to comment #12) This patch should be back-ported to the release branch. -- Backport_to_Stable flag set to ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Priority|High|Normal --- Comment #11 from Antoine hashar Musso has...@free.fr --- The patch has been reimplemented with https://gerrit.wikimedia.org/r/55695 :-] I still have to test it out but beta is no more broken so I am lowering the priority for this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 --- Comment #1 from Antoine hashar Musso has...@free.fr --- I guess the root cause is https://gerrit.wikimedia.org/r/#/c/52913/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Antoine hashar Musso has...@free.fr changed: What|Removed |Added CC||mwal...@wikimedia.org -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Blocks||46382 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 --- Comment #2 from Antoine hashar Musso has...@free.fr --- Once per hour, Jenkins will run update.php on the 'enwiki' database of the beta cluster. The job dashboard is https://integration.wikimedia.org/ci/job/beta-updatedb-enwiki/ It started breaking on March 21st https://integration.wikimedia.org/ci/job/beta-updatedb-enwiki/42/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 --- Comment #3 from Antoine hashar Musso has...@free.fr --- -$wgHooks[ 'LoadExtensionSchemaUpdates' ][ ] = array( 'CNDatabasePatcher', 'applyUpdates' ); +$wgHooks[ 'LoadExtensionSchemaUpdates' ][ ] = 'CNDatabasePatcher::applyUpdates'; That fix it on my install. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|wikibugs-l@lists.wikimedia. |has...@free.fr |org | --- Comment #4 from Antoine hashar Musso has...@free.fr --- https://gerrit.wikimedia.org/r/55567 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #5 from Antoine hashar Musso has...@free.fr --- Bah I did my test on sqlite, not mysql. Reopening. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 --- Comment #6 from Antoine hashar Musso has...@free.fr --- Did some cleanup on beta and now I got: Creating cn_controller_mixins table ...A database query syntax error has occurred. The last attempted database query was: ALTER TABLE `cn_notices` DROP COLUMN `not_language`, DROP COLUMN `not_project`, ADD COLUMN `not_weight` int(11) NOT NULL DEFAULT '100', ADD COLUMN `not_mobile_carrier` tinyint(1) NOT NULL DEFAULT '0', ADD COLUMN `not_archived` tinyint(1) NOT NULL DEFAULT '0' from within function DatabaseBase::sourceFile( /data/project/apache/common-local/php-master/extensions/CentralNotice/patches/patch-centralnotice-2_3.sql ). Database returned error 1091: Can't DROP 'not_language'; check that column/key exists (10.4.0.53) -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 --- Comment #7 from Antoine hashar Musso has...@free.fr --- When bootstrapping a new wiki CentralNotice.sql does not create: - table cn_controller_mixins - cn_notices.not_language and cn_notices.not_project The absence of table cn_controller_mixins triggers the run of patches/patch-centralnotice-2_3.sql which attempt drop the two non existent columns, hence the stack trace. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 --- Comment #8 from Antoine hashar Musso has...@free.fr --- For the column bug, see https://gerrit.wikimedia.org/r/55579 -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 --- Comment #9 from Antoine hashar Musso has...@free.fr --- Next issue: The last attempted database query was: ALTER TABLE `cn_notices` DROP COLUMN `not_language`, DROP COLUMN `not_project`, ADD COLUMN `not_weight` int(11) NOT NULL DEFAULT '100', ADD COLUMN `not_mobile_carrier` tinyint(1) NOT NULL DEFAULT '0', ADD COLUMN `not_archived` tinyint(1) NOT NULL DEFAULT '0' from within function DatabaseBase::sourceFile( /data/project/apache/common-local/php-master/extensions/CentralNotice/patches/patch-centralnotice-2_3.sql ). Database returned error 1060: Duplicate column name 'not_weight' (10.4.0.53) Wich is a similar issue: the patch attempt to add columns which have already been populated by the main patch. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46533] CentralNotice has a broken database updater
https://bugzilla.wikimedia.org/show_bug.cgi?id=46533 --- Comment #10 from Antoine hashar Musso has...@free.fr --- I have reverted the whole patchset with https://gerrit.wikimedia.org/r/#/c/55587/ . Pinging authors by email. -- You are receiving this mail because: You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
