[Bug 48420] Jenkins: overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #1 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/63571 (Gerrit Change Ia3cbaddf698eac558d2390a4be5d8c0817bf6317) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #2 from Antoine "hashar" Musso --- mwext-Translate-phpcs-HEAD is no more testing i18n files, making it REALLY faster: https://integration.wikimedia.org/ci/job/mwext-Translate-phpcs-HEAD/1286/console -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #3 from Antoine "hashar" Musso --- Deployed the i18n ignore for all extensions. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #4 from Krinkle --- Can this be marked as fixed now? I think this is good enough. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Krinkle changed: What|Removed |Added Summary|Jenkins: overhaul the phpcs |Jenkins: Overhaul the phpcs |macro |macro -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #5 from Antoine "hashar" Musso --- Gerrit change #63571 added in the i18n.php fliter, I still have to adapt phpcs-HEAD macro to rely on /var/lib/jenkins/bin/git-changed-in-head instead of the huge shell script :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Antoine "hashar" Musso changed: What|Removed |Added Priority|Unprioritized |High Assignee|wikibugs-l@lists.wikimedia. |has...@free.fr |org | Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #6 from Gerrit Notification Bot --- Related URL: https://gerrit.wikimedia.org/r/69863 (Gerrit Change I7862b0b628748f23fb29c063c3e530f60bbaa795) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Antoine "hashar" Musso changed: What|Removed |Added Blocks||46500 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #7 from Antoine "hashar" Musso --- Lame matrix: par files head strict || HEAD head loose | -n | . full strict || HEAD full loose | -n | . -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #8 from Gerrit Notification Bot --- Change 77279 had a related patch set uploaded by Hashar: run-phpcs-mw: wrapper around phpcs for CI needs https://gerrit.wikimedia.org/r/77279 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #9 from Antoine "hashar" Musso --- Shell wrapper for the win :-] -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #10 from Gerrit Notification Bot --- Change 77279 merged by Hashar: run-phpcs-mw.sh: wrapper around phpcs for CI needs https://gerrit.wikimedia.org/r/77279 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #11 from Gerrit Notification Bot --- Change 77281 had a related patch set uploaded by Hashar: new phpcs builder macros https://gerrit.wikimedia.org/r/77281 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #12 from Gerrit Notification Bot --- Change 77282 had a related patch set uploaded by Hashar: new phpcs jobs for mw/ext/Translate https://gerrit.wikimedia.org/r/77282 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #13 from Gerrit Notification Bot --- Change 77283 had a related patch set uploaded by Hashar: new phpcs jobs for mw/ext/Translate https://gerrit.wikimedia.org/r/77283 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #14 from Gerrit Notification Bot --- Change 77283 merged by jenkins-bot: new phpcs jobs for mw/ext/Translate (non voting) https://gerrit.wikimedia.org/r/77283 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #15 from Antoine "hashar" Musso --- An example run is https://gerrit.wikimedia.org/r/#/c/77284/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #16 from Antoine "hashar" Musso --- Reports for the example: Lenient: https://integration.wikimedia.org/ci/job/mwext-Translate-phpcs-lenient/1/violations/? Strict: https://integration.wikimedia.org/ci/job/mwext-Translate-phpcs-strict/1/violations/? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #17 from Gerrit Notification Bot --- Change 77281 merged by jenkins-bot: new phpcs builders and job templates https://gerrit.wikimedia.org/r/77281 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #18 from Gerrit Notification Bot --- Change 77282 merged by jenkins-bot: new phpcs jobs for mw/ext/Translate https://gerrit.wikimedia.org/r/77282 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #19 from Gerrit Notification Bot --- Change 81184 had a related patch set uploaded by Hashar: new phpcs jobs for mediawiki/core (non voting) https://gerrit.wikimedia.org/r/81184 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #20 from Gerrit Notification Bot --- Change 81184 merged by jenkins-bot: new phpcs jobs for mediawiki/core (non voting) https://gerrit.wikimedia.org/r/81184 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #21 from Antoine "hashar" Musso --- I still have to get rid of the old macros in Jenkins Job Builder and to always ends up using the shell wrapper introduced by https://gerrit.wikimedia.org/r/77279 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Andre Klapper changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Antoine "hashar" Musso changed: What|Removed |Added Priority|High|Normal --- Comment #22 from Antoine "hashar" Musso --- Lowering priority, I am working on other things right now. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Siebrand Mazeland changed: What|Removed |Added CC||s.mazel...@xs4all.nl --- Comment #23 from Siebrand Mazeland --- Translate extension now passes PHPCS strict since gerrit 88616. Will be made voting soon for Translate. Use the following to ignore coding standards on for example false positives and lib files: // @codingStandardsIgnoreStart [Code part that is ignored. // @codingStandardsIgnoreStart // @codingStandardsIgnoreFile Will ignore complete file. More information at: http://pear.php.net/manual/en/package.php.php-codesniffer.advanced-usage.php -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #29 from Gerrit Notification Bot --- Change 161763 abandoned by Hashar: Significantly simplify phpcs job configuration Reason: The continuous integration configuration files are now held in integration/config.git with Zuul layout files being under /zuul/layout.yaml If there still is an interest in this patch, please port it to the new repository integration/config.git https://gerrit.wikimedia.org/r/161763 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #30 from Gerrit Notification Bot --- Change 161757 abandoned by Hashar: Remove unused distinction between phpcs-strict and phpcs-lenient Reason: The continuous integration configuration files are now held in integration/config.git with JJB layout files being under /jjb/ If there still is an interest in this patch, please port it to the new repository integration/config.git https://gerrit.wikimedia.org/r/161757 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #31 from Gerrit Notification Bot --- Change 166071 had a related patch set uploaded by Jforrester: Clean up phpcs usage, removing -strict/-lenient distinction https://gerrit.wikimedia.org/r/166071 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #27 from Gerrit Notification Bot --- Change 161763 had a related patch set uploaded by Jforrester: Significantly simply phpcs job configuration https://gerrit.wikimedia.org/r/161763 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #28 from Gerrit Notification Bot --- Change 161757 had a related patch set uploaded by Krinkle: Remove unused distinction between phpcs-strict and phpcs-lenient https://gerrit.wikimedia.org/r/161757 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Addshore changed: What|Removed |Added CC||addshorew...@gmail.com --- Comment #25 from Addshore --- Is there anything else to overhaul here? It looks pretty good to me :) (although I might add a few more options in the coming weeks! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 --- Comment #26 from Antoine "hashar" Musso --- I have kept this bug around as per Comment #21: > I still have to get rid of the old macros in Jenkins Job Builder and to > always ends up using the shell wrapper introduced by > https://gerrit.wikimedia.org/r/77279 We have two different set of phpcs jobs. The Jenkins Job builder config needs to be adjust for all repositories using the old set (the new one are the templates applied to Translate and have 'lenient' and 'strict'). Then adjust the Zuul triggers to reflect the change. If strict pass (i.e. warning+errors), the lenient one (warning only) can be removed from Zuul configuration since it is redundant. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 48420] Jenkins: Overhaul the phpcs macro
https://bugzilla.wikimedia.org/show_bug.cgi?id=48420 Greg Grossmeier changed: What|Removed |Added CC||g...@wikimedia.org Assignee|has...@free.fr |wikibugs-l@lists.wikimedia. ||org --- Comment #24 from Greg Grossmeier --- Almost a year since Antoine has worked on this, unassigning. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
