[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 This, that and the other changed: What|Removed |Added CC||at.li...@live.com.au Component|Echo|Thanks -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Legoktm changed: What|Removed |Added CC||legoktm.wikipe...@gmail.com See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=46690 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Quiddity changed: What|Removed |Added Severity|trivial |normal --- Comment #1 from Quiddity --- Yikes. See the thread linked in first comment (permalink: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Notifications&oldid=564293462#Thanked_twice ) for an update. One user has discovered how to accidentally "thank" a multitude of times, for the same edit, via "control-clicking" on any link in the "revision history" page, after a thank has been sent/confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 --- Comment #2 from bs...@wikimedia.org --- After a quick review on the code, the fix should be pretty straight forward. The state of 'Thanks' is saved into user's web session. Before sending a thanks notification, just skip sending 'Thanks' notification if a previous 'Thanks' has been sent for the revision -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 --- Comment #3 from Gerrit Notification Bot --- Change 73732 had a related patch set uploaded by Bsitu: (bug 51303) Do not send duplicate thanks notification https://gerrit.wikimedia.org/r/73732 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 --- Comment #4 from Gerrit Notification Bot --- Change 73732 merged by jenkins-bot: (bug 51303) Do not send duplicate thanks notification https://gerrit.wikimedia.org/r/73732 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 MZMcBride changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from MZMcBride --- (In reply to comment #4) > Change 73732 merged by jenkins-bot: > (bug 51303) Do not send duplicate thanks notification > > https://gerrit.wikimedia.org/r/73732 I'm marking this bug resolved/fixed accordingly. Please feel free to re-open this bug if you continue to see this issue (duplicate thanks) in a few days after this change is deployed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Kunal Mehta (Legoktm) changed: What|Removed |Added Priority|Unprioritized |High --- Comment #8 from Kunal Mehta (Legoktm) --- The problem is that we store Thanks in session data, which shouldn't be and isn't a persistent cache. We can either create our own database table for storage, or maybe use wfGetCache( CACHE_DB )? Not sure what our options for persistent storage on the WMF cluster are. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Ricordisamoa changed: What|Removed |Added CC||ricordisa...@live.it --- Comment #9 from Ricordisamoa --- See also: https://www.wikidata.org/w/index.php?title=Special:Log&type=thanks&user=Ricordisamoa&page=User:Lydia_Pintscher_%28WMDE%29&year=2014&month=1&limit=5 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 --- Comment #10 from Ricordisamoa --- (In reply to comment #8) > The problem is that we store Thanks in session data, which shouldn't be and > isn't a persistent cache. > > We can either create our own database table for storage, or maybe use > wfGetCache( CACHE_DB )? Not sure what our options for persistent storage on > the > WMF cluster are. Making thanks log public (Bug 49087) would solve the issue. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Redrose64 changed: What|Removed |Added CC||m...@redrose64.plus.com --- Comment #11 from Redrose64 --- Still happening. These two thanks https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=thanks&user=Malikhpur&page=User%3ARedrose64 were both for the same edit https://en.wikipedia.org/w/index.php?title=Category:Punjabi_folk_religion&oldid=prev&diff=594057858 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Quiddity changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #6 from Quiddity --- Re-opening, per fresh report of a doublethank (with a many hour time-gap between them) from Redrose64 at https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications/Thanks#Doublethank -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Quiddity changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=56378 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Elitre changed: What|Removed |Added CC||elitr...@gmail.com --- Comment #7 from Elitre --- *** Bug 57584 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Kunal Mehta (Legoktm) changed: What|Removed |Added CC||technical...@yahoo.com --- Comment #12 from Kunal Mehta (Legoktm) --- *** Bug 61883 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 --- Comment #13 from Kunal Mehta (Legoktm) --- *** Bug 61883 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 Kunal Mehta (Legoktm) changed: What|Removed |Added CC||automati...@yahoo.fr --- Comment #15 from Kunal Mehta (Legoktm) --- *** Bug 70100 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 51303] Notifications: Getting two "Thank"s from one user for the same edit is possible
https://bugzilla.wikimedia.org/show_bug.cgi?id=51303 --- Comment #14 from Elitre --- Still happens to me regularly (le sigh). The history for a given page forgets I already thanked a bunch of people. Apparently the Thanks are correctly mentioned in the relevant Log though, so there's this workaround. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
