[Bug 52840] ParserService.js needs express.js > 3.x.x, but 2.5.x is set in package.json
https://bugzilla.wikimedia.org/show_bug.cgi?id=52840 --- Comment #3 from C. Scott Ananian --- I think the problem is actually with connect (which provides the bodyParser middleware). We're using connect version 1.9.2, but express only requires connect '1.x'. As far as I can tell from https://github.com/senchalabs/connect/blob/master/History.md, the latest stable 1.x version was 1.8.5, and bodyParser was added/extended in connect 2.0.0. I'm guessing that connect 1.9.2 is a "prerelease 2.0" and so contains some connect 2.0.0 features, like bodyParser. If someone can reproduce this bug, I'd like to see what happens if they edit node_modules/express/package.json to depend on connect 1.9.x instead of 1.x, and then npm install from the node_modules/express directory. Alternatively, we might suggest that people clone mediawiki/extensions/Parsoid/js/contrib.git instead of using npm install? Probably the best way to solve this issue is to go ahead and migrate to express 3.0. See https://github.com/visionmedia/express/wiki/Migrating-from-2.x-to-3.x and https://github.com/visionmedia/express/wiki/New-features-in-3.x. Anyone want to tackle this? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52840] ParserService.js needs express.js > 3.x.x, but 2.5.x is set in package.json
https://bugzilla.wikimedia.org/show_bug.cgi?id=52840 --- Comment #2 from Marc Ordinas i Llopis --- This is a traceback of the problem, as reported by an user on IRC: TypeError: Cannot read property 'oldid' of undefined at app.post.cb (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/api/ParserService.js:635:28) at getParserServiceEnv (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/api/ParserService.js:376:4) at MWParserEnvironment.getParserEnv (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/lib/mediawiki.parser.environment.js:279:3) at MWParserEnvironment.switchToConfig (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/lib/mediawiki.parser.environment.js:324:3) at Function.MWParserEnvironment.getParserEnv (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/lib/mediawiki.parser.environment.js:278:6) at getParserServiceEnv (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/api/ParserService.js:365:22) at /opt/bitnami/apache2/htdocs/extensions/Parsoid/js/api/ParserService.js:663:2 at callbacks (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/node_modules/express/lib/router/index.js:272:11) at param (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/node_modules/express/lib/router/index.js:246:11) at pass (/opt/bitnami/apache2/htdocs/extensions/Parsoid/js/node_modules/express/lib/router/index.js:253:5) From further debugging (http://pastebin.com/DbBhJdEE), it seemed like the version of express the user had installed didn't provide req.body. Maybe 3.x.x isn't necessary, but 2.5.11 is? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 52840] ParserService.js needs express.js > 3.x.x, but 2.5.x is set in package.json
https://bugzilla.wikimedia.org/show_bug.cgi?id=52840 C. Scott Ananian changed: What|Removed |Added CC||canan...@wikimedia.org --- Comment #1 from C. Scott Ananian --- Express 3.x.x is a major version change, it probably breaks lots of stuff. I'm running with 2.5.11 on my machine (and I suspect the rest of the developers are, too). Can you provide more details on the problem you're seeing? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
