[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529 Krinkle changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #26 from Krinkle 2011-01-26 01:29:47 UTC --- Reverted in r81012. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529
Happy-melon changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution||FIXED
--- Comment #25 from Happy-melon 2011-01-17
10:37:42 UTC ---
Resolved in r80430. The first line of a wikitable cell is now treated as a
linestart context, so structures like
{|
| Foo
| * Bar
| {|
| Look I'm nested!
|}
|}
Will all work, and regardless of whether they were added via a template or
directly.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529
--- Comment #24 from Felix Pahl 2011-01-15 16:36:55 UTC ---
(In reply to comment #23)
> (In reply to comment #22)
> Leading whitespace is probably trimmed from the ExpandTemplates output, but
> the
> newline is added. Try expanding
>
> Foo{{fr-conj-1|abaiss|
> |'=oui
> |pron=a.bɛ
> |pc=s
> }}bar
>
> You'll see that in the output the table start has been moved onto a new line.
I see. In that case, that seems like a bug in ExpandTemplates -- it's supposed
to let you see how templates are expanded; it has no business trimming leading
whitespace :-)
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529
--- Comment #23 from Happy-melon 2011-01-15
16:20:46 UTC ---
(In reply to comment #22)
> Now go to
> http://fr.wiktionary.org/w/index.php?title=Annexe:Conjugaison_française:abaisser&action=raw&templates=expand.
> You get the same expansion, but with a newline at the top.
Leading whitespace is probably trimmed from the ExpandTemplates output, but the
newline is added. Try expanding
Foo{{fr-conj-1|abaiss|
|'=oui
|pron=a.bɛ
|pc=s
}}bar
You'll see that in the output the table start has been moved onto a new line.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529 --- Comment #22 from Felix Pahl 2011-01-15 14:50:37 UTC --- (In reply to comment #21) > (In reply to comment #20) > > BTW, the problem is slightly compounded by the fact that the special > > template > > expansion pages (http://meta.wikimedia.org/wiki/Special:ExpandTemplates, > > http://fr.wiktionary.org/wiki/Spécial:ExpansionDesModèles) *don't* produce > > this > > newline. > > I don't believe this is the case, on 1.16-wmf4 at least. I disagree -- this can be reproduced as follows: Go to http://fr.wiktionary.org/w/index.php?title=Annexe:Conjugaison_française:abaisser&action=edit and copy the content of that page (a template call). Go to http://fr.wiktionary.org/wiki/Spécial:ExpansionDesModèles, paste the page content into the text area and click "OK". You get the expansion of the template, without a newline at the top. Now go to http://fr.wiktionary.org/w/index.php?title=Annexe:Conjugaison_française:abaisser&action=raw&templates=expand. You get the same expansion, but with a newline at the top. The HTML source on that site has the meta tag , so it seems to be using the version you mentioned. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529 Happy-melon changed: What|Removed |Added CC||happy.melon.w...@gmail.com --- Comment #21 from Happy-melon 2011-01-15 14:25:20 UTC --- (In reply to comment #20) > BTW, the problem is slightly compounded by the fact that the special template > expansion pages (http://meta.wikimedia.org/wiki/Special:ExpandTemplates, > http://fr.wiktionary.org/wiki/Spécial:ExpansionDesModèles) *don't* produce > this > newline. I don't believe this is the case, on 1.16-wmf4 at least. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529 --- Comment #20 from Felix Pahl 2010-04-16 06:17:37 UTC --- BTW, the problem is slightly compounded by the fact that the special template expansion pages (http://meta.wikimedia.org/wiki/Special:ExpandTemplates, http://fr.wiktionary.org/wiki/Spécial:ExpansionDesModèles) *don't* produce this newline. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529 Felix Pahl changed: What|Removed |Added CC||fp...@web.de --- Comment #19 from Felix Pahl 2010-04-16 06:11:57 UTC --- A comment that might speak for changing or at least prominently documenting this: I just wrote a MediaWiki template expander in Java -- when I was done implementing all the features I needed, I tested it on a real-life example that uses lots of nested templates (http://fr.wiktionary.org/wiki/Annexe:Conjugaison_française:abaisser) and compared the result with the raw expanded output (http://fr.wiktionary.org/w/index.php?title=Annexe:Conjugaison_française:abaisser&action=raw&templates=expand). Everything was exactly right, including all whitespace, except that I seemed to be missing a newline at the very beginning, and I couldn't figure out where that was supposed to be coming from. The time it cost me to dig into the source code and bug reports to get to the bottom of this one discrepancy was quite a significant fraction of the total time I spent writing the expander. I still haven't found anything outside source code and bug reports that documents this behaviour. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529 Mike.lifeguard changed: What|Removed |Added Keywords|fixed-in-cvs| --- Comment #18 from Mike.lifeguard 2009-05-29 00:47:18 UTC --- removed deprecated keyword fixed-in-cvs -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529 Siebrand changed: What|Removed |Added CC||siebr...@wikipedia.be Blocks||12974 Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #17 from Siebrand 2009-04-25 11:11:23 UTC --- Reopening. Blocks bug 12974. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 529] Templates inside of tables appear incorrectly
https://bugzilla.wikimedia.org/show_bug.cgi?id=529 --- Comment #16 from Mormegil <[EMAIL PROTECTED]> 2008-11-12 21:15:44 UTC --- Yep, this change breaks stuff. Remember that this code applies not only to templates, but also to parser functions. The fact that a parser function output begins with a semicolon definitely does not mean that a was intended. See bug 12974 and http://test.wikipedia.org/wiki/Newline_through_parser_functions I tend to agree with JeLuF’s comment #8 here – if some syntax feature works only at the beginning of a line, it is the responsibility of the person who wrote the syntax feature to ensure that it is really at the beginning of a line. If you are writing a template, add a newline on its top, declare its proper usage in the documentation, or whatever. Anyway: while I believe this feature/fix/… should be removed again, but I believe a compromise is possible: To add the newline only for the table syntax (not for ':', ';', '#', or '*'). Table syntax is rare in other uses than tables (while colons and semicolons are perfectly normal in plain text), and tables seem to be the primary use case for this bug/fix. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
