[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-06-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Helder he7...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=66473

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-01-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #28 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 108329 had a related patch set uploaded by Legoktm:
Properly get timestamp position in DiscussionParser

https://gerrit.wikimedia.org/r/108329

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-01-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #29 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 108329 merged by jenkins-bot:
Properly get timestamp position in DiscussionParser

https://gerrit.wikimedia.org/r/108329

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-01-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #30 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Patch should go out with 1.23wmf12, which will reach the Japanese Wiktionary on
February 4th, and all sites by the 6th. See [[wikitech:Deployments]] for all
the details.

Closing for now, please re-open if you notice any other issues related to this
bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-01-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #27 from Yusuke Matsubara w...@whym.org ---
(In reply to comment #26)
 Change 108329 had a related patch set uploaded by Whym:
 (bug 53132) properly get timestamp position in DiscussionParser
 
 https://gerrit.wikimedia.org/r/108329

Just to put this patch in context: unless this patch is applied, the parser
takes timestamp substrings instead of timestamp positions.  Languages that put
the year at the beginning of the timestamp, substrings as 2013 or 2014 were
interpret as the position.  This made some vadility checks fail in the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-01-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|REOPENED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-01-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #26 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 108329 had a related patch set uploaded by Whym:
(bug 53132) properly get timestamp position in DiscussionParser

https://gerrit.wikimedia.org/r/108329

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-01-12 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #25 from Quiddity pandiculat...@gmail.com ---
(In reply to comment #24)
 I presume this edit https://ja.wiktionary.org/w/index.php?oldid=617213
 should
 have invoked a notification towards [[User:Whym]], but it didn't.

Confirmed.  I've been testing it at jpwikt, and cannot get mention
notifications to work. I tried twice with my interface language (for both
accounts) set to Japanese, and to English. Neither worked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2014-01-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Yusuke Matsubara w...@whym.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||w...@whym.org
 Resolution|FIXED   |---

--- Comment #24 from Yusuke Matsubara w...@whym.org ---
I presume this edit https://ja.wiktionary.org/w/index.php?oldid=617213 should
have invoked a notification towards [[User:Whym]], but it didn't.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-12-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #23 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 87477 merged by jenkins-bot:
Support non-English namespace names in DiscussionParser::getUserFromLine

https://gerrit.wikimedia.org/r/87477

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-12-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-11-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

wikif...@gmail.com changed:

   What|Removed |Added

 CC||wikif...@gmail.com

--- Comment #22 from wikif...@gmail.com ---
A) I would support the removal of the need to sign a comment before a ping
works (I wasn't aware of this requirement, and thought that my ping remained
unanswered until JdForrester nicely explained this to me)

but...

B) I have the habit to archive my talk page by using copy-paste, I wouldn't
want people to get unwanted notifications when I do this though. 

I fear that A and B are mutually exclusive requirements...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #20 from Quiddity pandiculat...@gmail.com ---
(In reply to comment #16)
 My recommendation would be that we remove the requirement that a signature be
 included before a mention notification is sent, as stated here:
 [...]

Regarding remove the requirement that a signature be included before a mention
notification is sent, which I'm generally in favour of...

I just saw Bug 54639 (Echo is not triggering notifications when a mention is
made while reorganizing comments in the page) which makes me worry that (if
the signature-requirement is taken away) mass notifications will be
accidentally sent when threads are shuffled/split/merged or archived.

Just worrying out-loud; I might have understood the details incorrectly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #21 from Bartosz Dziewoński matma@gmail.com ---
Good point. Luckily I think we could easily avoid that issue by just counting
the number of mentions for each user in the old and new wikitext and only
sending a notification is the number increased.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

 CC||fantasticfe...@gmail.com

--- Comment #19 from Bartosz Dziewoński matma@gmail.com ---
*** Bug 55915 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #18 from Bartosz Dziewoński matma@gmail.com ---
This also affects signatures with namespaces with spaces replaced with
underscores, like [[User_talk:Matma Rex]].

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #16 from Fabrice Florin fflo...@wikimedia.org ---
Thank you all for bringing this issue to our attention.

My recommendation would be that we remove the requirement that a signature be
included before a mention notification is sent, as stated here:

https://www.mediawiki.org/wiki/Echo/Feature_requirements#User_Mention

When we created this feature, we were being very cautious to not over-spam
users, which is why we put in some of these restrictions. But I don't think
this particular limitation is needed anymore.

I believe this would be an important bug to fix sooner rather than later, given
how many folks are impacted by this restriction.

Thank you for flagging this issue!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #17 from Oliver Keyes oke...@wikimedia.org ---
That would seem to be a Product decision - and one that would involve assigning
E2 engineers back to non-critical Echo bugs, to boot - and so Maryana's
concern.

Lego/MatmaRex's bug fixes the actual problem here: let's stick with that. If
there is a need for a new feature it will both have to wait and have to be
approved of/supervised by the Product Manager for the feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #15 from Helder mybugs.m...@gmail.com ---
For the record, given the current usage of customized signatures on Portuguese
Wikipedia[0], there are at least 741 users who are not able to use Echo to
mention other users, and previous to a change[1] to our
[[pt:MediaWiki:Signature]], the number was over 17000 (female users which
didn't customize their signature).

[0]
https://pt.wikipedia.org/wiki/Project_talk:Notificações#Dados_de_Prefer.C3.AAncias
[1] https://pt.wikipedia.org/w/index.php?diff=36985689oldid=27625950

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 87477 had a related patch set uploaded by Legoktm:
Support non-English namespace names in DicussionParser::getUserFromLine

https://gerrit.wikimedia.org/r/87477

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-10-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 CC||legoktm.wikipe...@gmail.com

--- Comment #14 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
(In reply to comment #13)
 Change 87477 had a related patch set uploaded by Legoktm:
 Support non-English namespace names in DicussionParser::getUserFromLine
 
 https://gerrit.wikimedia.org/r/87477

This is basically MatmaRex's patch fixed up a bit by me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-09-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #12 from sp...@wikimedia.org ---
Prioritization and scheduling of this bug is tracked on Mingle card
https://mingle.corp.wikimedia.org/projects/flow/cards/234

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-09-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #11 from Helder mybugs.m...@gmail.com ---
(In reply to comment #9)
 Maybe we should just remove the text pattern match for signature, It's
 unclear
 to me why it started with the signature requirement from the first place.

I believe that would be useful, since it would also make edits such as
https://pt.wikipedia.org/w/index.php?diff=36939646uselang=endiffonly=1
to trigger notifications as they should.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-09-19 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Oliver Keyes oke...@wikimedia.org changed:

   What|Removed |Added

 CC||oke...@wikimedia.org

--- Comment #10 from Oliver Keyes oke...@wikimedia.org ---
As opposed to just matching on link? I honestly don't know; Kaldari might?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-09-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #9 from bs...@wikimedia.org ---
Maybe we should just remove the text pattern match for signature, It's unclear
to me why it started with the signature requirement from the first place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-08-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Helder mybugs.m...@gmail.com changed:

   What|Removed |Added

Summary|Notifications do not work   |Notifications are not sent
   |for male users  |when a user mentions
   ||another if the signature of
   ||the sender contains
   ||localized namespaces

--- Comment #4 from Helder mybugs.m...@gmail.com ---
I made a more comprehensive set of tests to find out under which circumstances
the I'm able to send notifications by mentioning another user:

* No gender makes [[Special:MyPage]] to show the NS alias Usuário(a) and:
** No custom signature: works (this defaults to a signature using Usuário(a))
** Signature using [[User:: fails
** Signature using [[Usuário(a):: works
** Signature using [[Usuário:: fails
** Signature using [[Usuária:: fails
** Signature using [[Utilizador:: fails

* Gender = male makes [[Special:MyPage]] to show the NS alias Usuário and:
** No custom signature: fails
** Signature using [[User:: fails
** Signature using [[Usuário(a):: works
** Signature using [[Usuário:: fails
** Signature using [[Usuária:: fails
** Signature using [[Utilizador:: fails

* Gender = female makes [[Special:MyPage]] to show the NS alias Usuária
and:
** No custom signature: fails
** Signature using [[User:: fails
** Signature using [[Usuário(a):: works
** Signature using [[Usuário:: fails
** Signature using [[Usuária:: fails
** Signature using [[Utilizador:: fails


FYI: the default file languages/messages/MessagesPt.php[1] has:
-
$namespaceNames = array(
...
NS_USER = 'Utilizador',
...
);

$namespaceAliases = array(
'Usuário'   = NS_USER,
...
);

$namespaceGenderAliases = array(
NS_USER = array( 'male' = 'Utilizador', 'female' = 'Utilizadora' ),
...
);
-

and currently the file wmf-config/InitialiseSettings.php[2] has the following:
-
'wgNamespaceAliases' = array(
...
'+ptwiki' = array(
'Utilizador' = NS_USER,
...
)
...
)

'wgExtraNamespaces' = array(
...
'ptwiki' = array(
NS_USER = 'Usuário(a)'
...
)
...
)

'wgExtraGenderNamespaces' = array(
'default' = array(),
...
'ptwiki' = array(
NS_USER = array( 'male' = 'Usuário', 'female' = 'Usuária' ),
...
),
...
)
-

[1]
https://github.com/wikimedia/mediawiki-core/blob/master/languages/messages/MessagesPt.php#L66
[2]
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-08-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Helder mybugs.m...@gmail.com changed:

   What|Removed |Added

   Keywords||i18n

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-08-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||matma@gmail.com
   Severity|normal  |major

--- Comment #5 from Bartosz Dziewoński matma@gmail.com ---
On man, this, like, really sucks.

Relevant function is EchoDiscussionParser::getUserFromLine(), which currently
only accepts the canonical localized variants of user namespace, user talk
namespace and Special:Contributions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-08-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #6 from Bartosz Dziewoński matma@gmail.com ---
It basically needs an entry for ns 2 and 3 in Language#getNamespaces(), an
entry for each namespace 2 and 3 alias listed in
Language#getNamespaceAliases(), and all that for both English and content
language.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-08-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #7 from Bartosz Dziewoński matma@gmail.com ---
(And probably all aliases for Special:Contributions, too, using
SpecialPageFactory::getAliasList().)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53132] Notifications are not sent when a user mentions another if the signature of the sender contains localized namespaces

2013-08-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53132

--- Comment #8 from Bartosz Dziewoński matma@gmail.com ---
Something like this (untested):

static function getUserFromLine( $line, $timestampPos ) {
  global $wgContLang;
  // Later entries have a higher precedence
  // @todo Handle optional whitespace in links
  $possiblePrefixes = array();

  foreach ( array( $wgContLang, Language::factory( 'en' ) ) as $language ) {
$nsNames = $language-getNamespaces();
$possiblePrefixes[] = '[[' . $nsNames[NS_USER] . ':';
$possiblePrefixes[] = '[[' . $nsNames[NS_USER_TALK] . ':';

$nsAliases = $language-getNamespaceAliases();
foreach ( $nsAliases as $text = $id ) {
  if ( $id == NS_USER || $id == NS_USER_TALK ) {
$possiblePrefixes[] = '[[' . $text . ':';
  }
}
  }

  // @todo Handle possible aliases
  $possiblePrefixes[] = '[[' . SpecialPage::getTitleFor( 'Contributions'
)-getPrefixedText() . '/';

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l