[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 Jesús Martínez Novo (Ciencia Al Poder) changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||martinezn...@gmail.com Resolution|--- |FIXED --- Comment #26 from Jesús Martínez Novo (Ciencia Al Poder) --- Works for me now on mediawiki.org. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #25 from Niklas Laxström --- Is this bug fixed now? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #24 from Gerrit Notification Bot --- Change 89624 merged by jenkins-bot: Edit area monospace font test https://gerrit.wikimedia.org/r/89624 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #23 from Gerrit Notification Bot --- Change 83972 merged by jenkins-bot: Fix monospace font usage for input fields for latin scripts https://gerrit.wikimedia.org/r/83972 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #22 from Gerrit Notification Bot --- Change 89624 restored by Amire80: WIP: Edit area monospace font test Reason: trying to rebase https://gerrit.wikimedia.org/r/89624 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #21 from Gerrit Notification Bot --- Change 89624 abandoned by Amire80: WIP: Edit area monospace font test Reason: Will make another commit. https://gerrit.wikimedia.org/r/89624 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #20 from Gerrit Notification Bot --- Change 89624 had a related patch set uploaded by Amire80: WIP: Edit area monospace font test https://gerrit.wikimedia.org/r/89624 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #19 from Niklas Laxström --- This is being tracked in Mingle: https://mingle.corp.wikimedia.org/projects/internationalization/cards/3719 We have an open patch in Gerrit: https://gerrit.wikimedia.org/r/#/c/83972/ The patch is waiting for more testing and integration tests. The integration test task is currently assigned to Amir, who comes back to work later this week. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #18 from MF-Warburg --- Any estimations as to when this can be fixed? It's quite annoying when editing tables and other stuff where it's desirable to put the correct amount of whitespaces in order to better see through the code. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 Jesús Martínez Novo (Ciencia Al Poder) changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=54453 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #17 from Andrey Kiselev --- (In reply to comment #14) > Andrey: No idea who your problem is directly related to this bug report... > Small testcase welcome (e.g. on a page on test2.wikipedia.org) so others > could > try to reproduce. https://test2.wikipedia.org/wiki/Bug_53734 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #16 from Rainer Rillke @commons.wikimedia --- abc -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734
--- Comment #15 from Rainer Rillke @commons.wikimedia
---
(In reply to comment #13)
A closing doublequote (") is missing in your sample. The correct example:
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #14 from Andre Klapper --- Andrey: No idea who your problem is directly related to this bug report... Small testcase welcome (e.g. on a page on test2.wikipedia.org) so others could try to reproduce. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 Andrey Kiselev changed: What|Removed |Added CC||rum...@pop3.ru --- Comment #13 from Andrey Kiselev --- Parser always replaces font-family to sans-serif for https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 Gerrit Notification Bot changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #11 from Gerrit Notification Bot --- Change 83972 had a related patch set uploaded by Nikerabbit: Fix monospace font usage for input fields for latin scripts https://gerrit.wikimedia.org/r/83972 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 Niklas Laxström changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #12 from Niklas Laxström --- *** Bug 54210 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 Santhosh Thottingal changed: What|Removed |Added Priority|Unprioritized |Normal Status|REOPENED|ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |santhosh.thottingal@gmail.c |org |om -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 --- Comment #10 from Santhosh Thottingal --- The monospace font style applied to the form fields comes from the user agent(browsers) and not from any style sheets. The monospace is undefined for many scripts like non-latin languages. I need to find a solution, that does not affect latin script, but make sure font is actually applied for scripts that does not have monospace defined. Put it in otherwords, if the language is any script where monospace is not defined, what we see is expected result. But surprising to languages with monospace as the bug report says. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734
Ori Livneh changed:
What|Removed |Added
CC||o...@wikimedia.org
--- Comment #9 from Ori Livneh ---
In jquery.webfonts.js:
if ( !fontFamily ) {
// If there is no explicit font for this language, it will
// inherit the webfont for the parent. But that is undesirable here
// since language is different. So inherit the original font of the
// element. Define it explicitly so that inheritance is broken.
// element
fontFamily = webfonts.originalFontFamily;
}
The logic you're seeing is this:
- There's no font to apply for this language.
- If we don't specify a font, the element could inherit a webfont from a
parent.
- So we have to explicitly specify the default font.
- The default font is the font-family for body, which is 'sans-serif'.
The catch is this: most browsers do not apply inherited font-family styles to
form elements by default, as a way of protecting the consistency of input
interfaces.
To prevent this special-casing of form elements, you have to explicitly
specify:
input, select, textarea {
font-family: inherit;
font-size: inherit;
font-weight: inherit;
}
References:
http://www.komodomedia.com/blog/2006/10/css-trickery-part-5-inheritance/
http://stackoverflow.com/questions/6520689/font-family-is-not-inherited-to-the-form-input-fields
The easy way to fix this would be to exempt form elements in the if (
!fontFamily ) { /* ... */ } block in jquery.webfonts.js.
If we move in the direction of explicitly specifying fonts, it would be
arguably better / more correct to specify that form elements should inherit
font styles. But the existence of this bug demonstrates that this would be
surprising to users.
I think it'd be best to fix it in jquery.webfonts.js and then start a separate
bug thread to discuss the second option.
I also note that I think the if ( !fontFamily ) ... check is overzealous; it
should only explicitly apply the default font stylings to elements are
descendants of elements that have a WebFonts specified. DOM manipulation is
expensive, even if it is a no-op from the perspective of the page's appearance.
It should be possible to be a bit cleverer about inheritance and only apply the
defaults when absolutely required.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 db changed: What|Removed |Added CC||rainerril...@hotmail.com --- Comment #8 from db --- *** Bug 53759 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53734] Setting language to anything other than "en" changes default edit-window font from monospaced to sans-serif
https://bugzilla.wikimedia.org/show_bug.cgi?id=53734 Helder changed: What|Removed |Added Summary|Setting language to en-gb |Setting language to |changes default edit-window |anything other than "en" |font from monospaced|changes default edit-window ||font from monospaced to ||sans-serif --- Comment #7 from Helder --- This is not exclusive to "en-gb". If I change the "uselang" parameter to any of "pt", "pt-br", "zh", "ru" or "ml", I get "sans-serif". The only code which seems to result in monospaced font is "en". -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
