[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #13 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Created attachment 13897 -- https://bugzilla.wikimedia.org/attachment.cgi?id=13897action=edit patch to librsvg to change default mask size (In reply to comment #12) bawolff: Understanding that you're busy, could you please share your untested four lines here so someone else would have the chance to test / improve a potential patch? Sorry, I meant to get back to this bug way before now, but I kind of forgot about this. See the relavent section of the svg spec for where the numbers I chose came from. Before submitting this upstream, I wanted to compile the patch on rsvg master (I was having trouble generating the build script, although I haven't put much effort into that. I did test on a modified version of the librsvg-2.39.0 tarball and it seemed to work well). I also wanted to create a minimal test case for this before submitting upstream, which I haven't gotten around to yet. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #12 from Andre Klapper aklap...@wikimedia.org --- bawolff: Understanding that you're busy, could you please share your untested four lines here so someone else would have the chance to test / improve a potential patch? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal --- Comment #10 from Andre Klapper aklap...@wikimedia.org --- (In reply to comment #9) I have a 4 line patch to rsvg that I think fixes the issue (Think being the operative word. I'm a c newb). I just spent 4 hours trying to make the thing compile at all, so I'm going to sleep on it, and then test it a bunch to make sure it actually works like I think it does. If so I'll file a bug/patch upstream and see what happens. bawolff: Did you have time for that? Is there an upstream URL? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #11 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to comment #10) (In reply to comment #9) I have a 4 line patch to rsvg that I think fixes the issue (Think being the operative word. I'm a c newb). I just spent 4 hours trying to make the thing compile at all, so I'm going to sleep on it, and then test it a bunch to make sure it actually works like I think it does. If so I'll file a bug/patch upstream and see what happens. bawolff: Did you have time for that? Is there an upstream URL? Sorry not yet. Ill try to do that soon. My free time to do wiki stuff has somewhat evaporated. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #6 from Andre Klapper aklap...@wikimedia.org --- (In reply to comment #5) Sounds like an Inkscape bug then In that case, upstreaming it with a testcase would be welcome: http://inkscape.org/report_bugs.php -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #7 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Created attachment 13260 -- https://bugzilla.wikimedia.org/attachment.cgi?id=13260action=edit The original test case with default attributes filled in In that case, upstreaming it with a testcase would be welcome: http://inkscape.org/report_bugs.php Re-opening. maskUnits is part of the spec, the fact its broken in rsvg is a bug in rsvg. The fact that in this particular svg, the unit types in use don't make much of a difference doesn't mean this isn't a bug. -- It appears rsvg does not have the correct defaults for the x, y, width and height attribute on mask when using userSpaceOnUse. According to the spec, I believe the correct defaults are -10%, -10%, 120%, 120% respectively. [1] (Assuming I interpreted spec correctly. I'm not really all that familiar with the details of the svg spec) Attaching an svg with these defaults filled in, appears to make the file work fine for rsvg. [1] http://www.w3.org/TR/SVG11/masking.html#MaskElementMaskUnitsAttribute -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #8 from Andre Klapper aklap...@wikimedia.org --- Thanks for correcting. So this should go upstream to https://bugzilla.gnome.org/buglist.cgi?query_format=advanced;bug_status=UNCONFIRMED;bug_status=NEW;bug_status=ASSIGNED;bug_status=REOPENED;bug_status=NEEDINFO;product=librsvg (though keeping bug 51555 in mind)? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #9 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to comment #7) It appears rsvg does not have the correct defaults for the x, y, width and height attribute on mask when using userSpaceOnUse. According to the spec, I believe the correct defaults are -10%, -10%, 120%, 120% respectively. [1] (Assuming I interpreted spec correctly. I'm not really all that familiar with the details of the svg spec) I have a 4 line patch to rsvg that I think fixes the issue (Think being the operative word. I'm a c newb). I just spent 4 hours trying to make the thing compile at all, so I'm going to sleep on it, and then test it a bunch to make sure it actually works like I think it does. If so I'll file a bug/patch upstream and see what happens. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added Component|File management |SVG rendering Product|MediaWiki |Wikimedia --- Comment #1 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Upstream issue with rsvg -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 PRO perheli...@gmail.com changed: What|Removed |Added CC||perheli...@gmail.com --- Comment #2 from PRO perheli...@gmail.com --- Thats not true, RSVG supports simple mask fully. Mask with gradients only partialy. For example https://commons.wikimedia.org/wiki/File:SVG_mask_gradient_bug.svg -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #3 from kelvinson...@gmail.com --- So, the same thing that can be achieved with Clipping paths. The whole point of masks is so you can apply opacity gradients/blurs!!! As it stands, the RSVG-supported masks are useless. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #4 from PRO perheli...@gmail.com --- I removed the maskUnits=userSpaceOnUse (in the mask tag) and the mask is working for this file!? W3C cite: If attribute ‘maskUnits’ is not specified, then the effect is as if a value of 'objectBoundingBox' were specified. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 53899] SVG masks fail to render (or even display)
https://bugzilla.wikimedia.org/show_bug.cgi?id=53899 --- Comment #5 from kelvinson...@gmail.com --- Okay, I tried what you did, and it works!!! (The reason I reverted you at the file is because you didn't fix the mask—you flattened the masks and applied the opacity gradient directly to the pink rectangle). Sounds like an Inkscape bug then, as mask behavior doesn't seem to be seriously affected by removal of this property. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
