[Bug 54248] Clicking VE edit after starting the wikitext 'firstedit' tour produces an incorrect step
https://bugzilla.wikimedia.org/show_bug.cgi?id=54248 Rob Moen rm...@wikimedia.org changed: What|Removed |Added CC||rm...@wikimedia.org --- Comment #4 from Rob Moen rm...@wikimedia.org --- If you look at firstedit tour definition, you'll see that shouldSkip is set to call isEditing() Calling gt.isEditing() checks to see if you are either editing with wikitext or if the VisualEditor is loaded. However the tour step loads before ve is actually loaded. IMO: isEditing needs to return true if VisualEditor is loading or loaded. Locally this fixes the bug for me. I probably will make a patch for this. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54248] Clicking VE edit after starting the wikitext 'firstedit' tour produces an incorrect step
https://bugzilla.wikimedia.org/show_bug.cgi?id=54248 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 84735 had a related patch set uploaded by Mattflaschen: Declare tour as requiring wikitext, but it doesn't work yet. https://gerrit.wikimedia.org/r/84735 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54248] Clicking VE edit after starting the wikitext 'firstedit' tour produces an incorrect step
https://bugzilla.wikimedia.org/show_bug.cgi?id=54248 --- Comment #2 from Matthew Flaschen mflasc...@wikimedia.org --- I was wrong about it being an easy fix. As far as I can tell, this never worked (wikitext tours not being loaded for VisualEditor). There are two different scenarios, which don't work for different reasons. However, it will work in the other direction (which is probably why I didn't catch this bug earlier): If it's a VE tour it will not show in the wikitext editor. I will fix this properly, but it looks like it may require some refactoring to do right. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54248] Clicking VE edit after starting the wikitext 'firstedit' tour produces an incorrect step
https://bugzilla.wikimedia.org/show_bug.cgi?id=54248 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54248] Clicking VE edit after starting the wikitext 'firstedit' tour produces an incorrect step
https://bugzilla.wikimedia.org/show_bug.cgi?id=54248 Steven Walling swall...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low Assignee|wikibugs-l@lists.wikimedia. |mflasc...@wikimedia.org |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
