[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 --- Comment #10 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Patch is live on test. Someone should do the steps to reproduce to make sure bug is actually fixed. (I can't at the moment) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to comment #10) Patch is live on test. Someone should do the steps to reproduce to make sure bug is actually fixed. (I can't at the moment) Tested, it works fine now, both files succesfully uploaded --- However, the API publish request (the action=uploadfilekey=foo... request) for one of the files does time out, eventually returning a squid error Request: POST http://test.wikipedia.org/w/api.php, from 208.80.154.9 via cp1010.eqiad.wmnet (squid/2.7.STABLE9) to 10.64.0.123 (10.64.0.123)br/ Error: ERR_READ_TIMEOUT, errno [No Error] at Fri, 04 Oct 2013 14:52:03 GMT Interestingly enough, the timestamp from that error is precisely when in the log the second version of the file is uploaded (14:52:03), which is kind of odd coincidence if it was just uploading both in sequence took longer than the squid timeout. I wonder if some lock isn't being released for the second one until after the user disconnects. Anyhow, calling this bug fixed. The second part might warrant further investigation, but is a much lower priority issue - splitting to bug 54978 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 Nemo federicol...@tiscali.it changed: What|Removed |Added CC||bryan.tongm...@gmail.com, ||federicol...@tiscali.it Component|Media storage |File management Version|unspecified |1.22-git Product|Wikimedia |MediaWiki Target Milestone|--- |1.22.0 release -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 --- Comment #9 from Andre Klapper aklap...@wikimedia.org --- Patch got merged, can this be closed as RESOLVED FIXED? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 --- Comment #5 from Aaron Schulz aschulz4...@gmail.com --- (In reply to comment #4) Confirmed, if you upload two separate files with the uploadwizard that you say have the same title, bad things happen ( https://test.wikipedia.org/wiki/File:BDavis-test-del.jpg ). At the same time or far apart too? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 --- Comment #6 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to comment #5) (In reply to comment #4) Confirmed, if you upload two separate files with the uploadwizard that you say have the same title, bad things happen ( https://test.wikipedia.org/wiki/File:BDavis-test-del.jpg ). At the same time or far apart too? At the same time. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 87010 had a related patch set uploaded by Aaron Schulz: Make sure LocalFile::lock() works for brand new uploads https://gerrit.wikimedia.org/r/87010 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 87010 merged by jenkins-bot: Make sure LocalFile::lock() works for brand new uploads https://gerrit.wikimedia.org/r/87010 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=54750 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 --- Comment #1 from Bawolff (Brian Wolff) bawolff...@gmail.com --- p.s. Denniss's comment at https://commons.wikimedia.org/w/index.php?title=User_talk:Bawolffoldid=105637956#Storage.2FBackend_issues.3F suggests that this is not just a one-off issue. I'll repeat his original comment here for the record: While monitoring the Rotatebot log I often come around images with storage issues; the first image revision is invalid but not completely broken as the second working image seems to gather wrong rotation info from it, so does Rotatebot and in the end the images gets rotated wrong. Deleting the file and restoring the first working image (usually the first but sometimes the second revision is shown as invalid) shows in most cases an image without rotation problem. Do you have an idea why this data corruption happens? Almost all of these image have the same storage time recorded, maximum one minute difference between the two. Example here. --Denniss (talk) 09:45, 28 September 2013 (UTC) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added Blocks||37883 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 Platonides platoni...@gmail.com changed: What|Removed |Added CC||platoni...@gmail.com --- Comment #2 from Platonides platoni...@gmail.com --- I think the storage problem for two revision of the same file uploaded at the same time is an old, known one. (but should be fixed anyway) The old-version shown 23 hours later looks like a cache problem (not strange given that the two versions had identical timestamps, to the second) The UW is a good theory. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 Denniss ice-k...@gmx.de changed: What|Removed |Added CC||ice-k...@gmx.de --- Comment #3 from Denniss ice-k...@gmx.de --- New file to check: https://commons.wikimedia.org/wiki/File:Cuenca,_casas_colgantes.JPG First image version invalid, second working with thumb upright but fullres rotated. Uploader requested rotation ~100 mins after upload and rotated image is off by 90 degrees. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 54736] Inconsistency bug in file re-upload (possible race condition) potentially causing data loss
https://bugzilla.wikimedia.org/show_bug.cgi?id=54736 --- Comment #4 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Confirmed, if you upload two separate files with the uploadwizard that you say have the same title, bad things happen ( https://test.wikipedia.org/wiki/File:BDavis-test-del.jpg ). Suggested work around for the near term: Have uploadwizard bail out in this situation. Its very unlikely if the user is doing this, that they really want the file. Filed as bug 54750. Additionally we should actually fix the race condition. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
