[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Antoine hashar Musso has...@free.fr --- I have retriggered the original build: https://integration.wikimedia.org/ci/job/mwext-cldr-phpcs-strict/4/console The phpcs command being run is: phpcs -v -s . --encoding=utf-8 \ --standard=/var/lib/jenkins/tools/mwcodesniffer/MediaWiki \ --extensions=php,php5,inc,sample \ '--ignore=languages/messages/Messages,*.i18n.php,*.i18n.alias.php' \ --report-checkstyle=checkstyle-phpcs.xml \ --report-full And the result is a SUCCESS. So the fix was indeed to pass '--encoding=utf-8' to phpcs :-] -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Priority|Unprioritized |Normal Assignee|wikibugs-l@lists.wikimedia. |has...@free.fr |org | Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #6 from Antoine hashar Musso has...@free.fr --- (In reply to comment #5) Have the jobs been pushed? The change is merged but in https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/1524/ console I don't see --encoding being passed. Good catch Timo. Something went wrong when I refreshed the jobs :( Refreshing them: $ grep 'encoding=utf' /var/lib/jenkins/jobs/*phpcs*/config.xml /var/lib/jenkins/jobs/mwext-AbuseFilter-phpcs-HEAD/config.xml: --encoding=utf-8 \ /var/lib/jenkins/jobs/mwext-ActiveAbstract-phpcs-HEAD/config.xml: --encoding=ut-8 \ /var/lib/jenkins/jobs/mwext-AdminLinks-phpcs-HEAD/config.xml: --encoding=utf-8 \ -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #7 from Antoine hashar Musso has...@free.fr --- All jobs got refreshed. That should fix the issue now, if that is actually the case I guess we can close the bug report. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #1 from Antoine hashar Musso has...@free.fr --- phpcs defaults to iso-8859-1 defined in PHP_CODESNIFFER_ENCODING CodeSniffer/Standards/Generic/Sniffs/Files/LineLengthSniff.php uses strlen(), whenever the encoding is not iso-8859-1 it would use: iconv_strlen($lineContent, PHP_CODESNIFFER_ENCODING); So need to pass: --encoding=UTF-8 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 Siebrand Mazeland s.mazel...@xs4all.nl changed: What|Removed |Added CC||s.mazel...@xs4all.nl --- Comment #2 from Siebrand Mazeland s.mazel...@xs4all.nl --- Our PHP files should be UTF-8 encoded, so we should run CodeSniffer in that mode. I'll see if I can submit a patch... -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 88743 had a related patch set uploaded by Siebrand: Specify encoding of source files as utf-8 https://gerrit.wikimedia.org/r/88743 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 88743 merged by jenkins-bot: Specify encoding of source files as utf-8 https://gerrit.wikimedia.org/r/88743 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55508] PHP CodeSniffer reports line length based on bytes, not on characters
https://bugzilla.wikimedia.org/show_bug.cgi?id=55508 --- Comment #5 from Krinkle krinklem...@gmail.com --- Have the jobs been pushed? The change is merged but in https://integration.wikimedia.org/ci/job/mwext-VisualEditor-phpcs-HEAD/1524/console I don't see --encoding being passed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
