[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #23 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 145584 had a related patch set uploaded by Gilles: Load most of TMH and its dependencies on demand https://gerrit.wikimedia.org/r/145584 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #24 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 145583 had a related patch set uploaded by Gilles: Load most of TMH and its dependencies on demand https://gerrit.wikimedia.org/r/145583 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #26 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 145583 merged by jenkins-bot: Load most of TMH and its dependencies on demand https://gerrit.wikimedia.org/r/145583 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #25 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 145584 merged by jenkins-bot: Load most of TMH and its dependencies on demand https://gerrit.wikimedia.org/r/145584 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Bug 0 depends on bug 58086, which changed state. Bug 58086 Summary: mw.MwEmbedSupport.style should only load on the pages that need it https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Priority|Normal |High Status|RESOLVED|REOPENED Resolution|FIXED |--- Assignee|mflasc...@wikimedia.org |wikibugs-l@lists.wikimedia. ||org --- Comment #22 from Ori Livneh o...@wikimedia.org --- Not fixed: MwEmbedSupport.hooks.php still says TODO look into loading this on-demand instead of all pages, as well it should. There is no reason for loading these modules on all pages: 'mw.MwEmbedSupport.style', 'jquery.triggerQueueCallback', 'Spinner', 'jquery.loadingSpinner', 'jquery.mwEmbedUtil', 'mw.MwEmbedSupport'. Re-opening and bumping priority, for two reasons: 1) It's a site performance issue. A longstanding one, but no less severe for it. 2) The hook that it depends on the ResourceLoaderGetStartupModules hook, which is deprecated as of Ic48ad39c6. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #21 from Matthew Flaschen mflasc...@wikimedia.org --- Marking FIXED. If another part is found and we want a bug, someone can re-open or file something more specific. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #20 from Andre Klapper aklap...@wikimedia.org --- All patches merged - resetting status. Is more work planned to do here, or shall this be closed as FIXED? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 99597 merged by jenkins-bot: Only load mw.PopUpMediaTransform on pages that plausibly need it https://gerrit.wikimedia.org/r/99597 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #16 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108649 had a related patch set uploaded by Ori.livneh: Only load mw.PopUpMediaTransform on pages that plausibly need it https://gerrit.wikimedia.org/r/108649 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108650 had a related patch set uploaded by Ori.livneh: Only load mw.PopUpMediaTransform on pages that plausibly need it https://gerrit.wikimedia.org/r/108650 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108649 merged by jenkins-bot: Only load mw.PopUpMediaTransform on pages that plausibly need it https://gerrit.wikimedia.org/r/108649 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 108650 merged by jenkins-bot: Only load mw.PopUpMediaTransform on pages that plausibly need it https://gerrit.wikimedia.org/r/108650 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 99597 had a related patch set uploaded by Ori.livneh: Don't load mw.PopUpMediaTransform unconditionally https://gerrit.wikimedia.org/r/99597 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Blocks||58083 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Depends on||58086 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #13 from Helder mybugs.m...@gmail.com --- See also: https://en.wikipedia.org/wiki/MediaWiki_talk:Common.js#Fixing_Template:clickable_button -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #12 from Krinkle krinklem...@gmail.com --- (In reply to comment #7) Matt, great sleuthing. I agree the $out-addModuleStyles( 'mw.PopUpMediaTransform' ); is redundant, [..] TMH's BeforePageOutput hook loads 'mw.PopUpMediaTransform' [..] I submitted Gerrit change #92052. One thing to keep in mind when fixing issues like this is the styling if non-JavaScript elements (eg. PHP-served HTML output) as, unless position/top is set these modules will load async and would cause a FOUC. Of course, that doesn't justify silly code that loads the stylesheet twice but it isn't always obvious that one can simply be removed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #10 from Matthew Flaschen mflasc...@wikimedia.org --- This will stop jquery.ui from loading by default on some WMF wikis. Specifically, those where only jquery.mwEmbedUtil depends on jquery.ui.dialog, and nothing else depends on the part of jquery.ui in question. For gadgets and user scripts, they just need to declare their dependency, either using the gadget syntax or mw.loader.using. Scripts should do this in general. However, I thought of another issue. If sites are using jquery.ui buttons in regular wikitext, that will also stop working unless jquery.ui.button is loaded some other way (e.g. English Wikipedia has ext.gadget.teahouse loaded by default, and it depends on jquery.ui.button). See https://en.wikipedia.org/wiki/Template:Clickable_button_2 for an example of this in use. This will roll out with 1.23wmf2, which means it hits the first non 'test' wiki on the 4th. I'll also send out an email to wikitech-ambassadors about this. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #11 from Ori Livneh o...@wikimedia.org --- (In reply to comment #10) This will stop jquery.ui from loading by default on some WMF wikis. Specifically, those where only jquery.mwEmbedUtil depends on jquery.ui.dialog, and nothing else depends on the part of jquery.ui in question. Well done! This is fantastic work. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #9 from MZMcBride b...@mzmcbride.com --- It looks like https://gerrit.wikimedia.org/r/88943 and https://gerrit.wikimedia.org/r/88944 have been merged. I suppose we're waiting on https://gerrit.wikimedia.org/r/92052 to be merged in order to mark this bug as resolved/fixed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 sp...@wikimedia.org changed: What|Removed |Added CC||sp...@wikimedia.org --- Comment #7 from sp...@wikimedia.org --- Matt, great sleuthing. I agree the $out-addModuleStyles( 'mw.PopUpMediaTransform' ); is redundant, also probably $out-addModuleStyles( 'mw.PopUpMediaTransform' ); for the similar parser hook. TMH's BeforePageOutput hook loads 'mw.PopUpMediaTransform', which specifies the dependency on 'mw.MwEmbedSupport'. But MwEmbedSupport in addStartupModules() explicitly loads 'mw.MwEmbedSupport' and all the files that it depends on. I think none of that should be necessary with latest MediaWiki, maybe it's there for backward compatibility with 1.17. I submitted gerrit 92052. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 88943 merged by jenkins-bot: Remove dialogFitWindow and jquery.ui.dialog from mwEmbedUtil https://gerrit.wikimedia.org/r/88943 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=47145 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Ori Livneh o...@wikimedia.org changed: What|Removed |Added Blocks||55683 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Blocks||55615 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 88944 merged by Mdale: Correct mw.PopUpMediaTransform dependency https://gerrit.wikimedia.org/r/88944 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Assignee|md...@wikimedia.org |mflasc...@wikimedia.org Summary|Reduce amount of code |Reduce amount of code |loaded in MwEmbedSupport|loaded in MwEmbedSupport |startup modules |and TimedMediaHandler ||startup and ||BeforePageDisplay --- Comment #1 from Matthew Flaschen mflasc...@wikimedia.org --- The same goes for BeforePageDisplay in TimedMediaHandler. BTW, I'm fine with splitting this bug, but there is no component for MwEmbedSupport yet. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 88943 had a related patch set uploaded by Mattflaschen: Remove dialogFitWindow and jquery.ui.dialog from mwEmbedUtil https://gerrit.wikimedia.org/r/88943 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 88944 had a related patch set uploaded by Mattflaschen: Correct mw.PopUpMediaTransform dependency https://gerrit.wikimedia.org/r/88944 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #4 from Matthew Flaschen mflasc...@wikimedia.org --- On my local wiki, those are enough to stop it from loading jquery.ui.dialog (and all of its dependencies, e.g. jquery.ui.core) on unrelated pages (e.g. the Main Page). Thanks to Ori for his new mw.loader.inspect method which led me into checking this out. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 --- Comment #5 from Matthew Flaschen mflasc...@wikimedia.org --- https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTimedMediaHandler.git/af412751c8bea1012f9715c16d49ffa5ca29f7aa/TimedMediaHandler.hooks.php#L350 is also double-loading the mw.PopUpMediaTransform CSS. I'm pretty sure the CSS is useless without the JavaScript. If so, I think the addModuleStyles can be removed. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 55550] Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
https://bugzilla.wikimedia.org/show_bug.cgi?id=0 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Keywords||performance Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
