[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #19 from MZMcBride b...@mzmcbride.com --- (In reply to comment #18) Should this bug be marked resolved/fixed now? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #20 from Tisza Gergő gti...@wikimedia.org --- It should! Thanks for pointing it out. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 102631 merged by jenkins-bot: Added 'Learn more' message https://gerrit.wikimedia.org/r/102631 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Assignee|durgasubramania...@gmail.co |amanpreet.iitr2...@gmail.co |m |m -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #16 from Bawolff (Brian Wolff) bawolff...@gmail.com --- Durga: Are you still interested in pursuing this? If not, I think apsdehal wants to take a crack at it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 102631 had a related patch set uploaded by Apsdehal: Added 'Learn More' message https://gerrit.wikimedia.org/r/102631 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #13 from Durga durgasubramania...@gmail.com --- Could anyone please tell me where the changes are to be made? I thought it has to be done in the i18n.php file -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #14 from Andre Klapper aklap...@wikimedia.org --- Druga: My understanding of this (disclaimer: I am not a developer): Don't redefine the value of the string variable multimediaviewer-repository in MultimediaViewer.i18n.php. Comment 6 here says you need to add another message. Find where in the code (not: MultimediaViewer.i18n.php) multimediaviewer-repository is called and add the if check there. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #15 from Tisza Gergő gti...@wikimedia.org --- As Andre says. Note also that $1 in i18n.php files does not get magically replaced (that only happens with $1 inside a string). The i18n.php file is a normal PHP file (which must return an array of message name = text); your changes would simply result in a syntax error. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #8 from Durga durgasubramania...@gmail.com --- I had submitted the patch, there was an error in the first patch, it was a syntax error, so I had submitted another patch. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #9 from Andre Klapper aklap...@wikimedia.org --- Durga: A link to the submitted patch would be highly welcome. (A link to a patch in Gerrit would get automatically added in Bugzilla when following http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines ) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #10 from Tisza Gergő gti...@wikimedia.org --- Also, please don't start a new patch when you need to modify something. See Amending a change in the Gerrit tutorial [1] on how to modify an existing patch. And when you do discard an old patch, please use the Abandon change button in Gerrit so the system can know that no one intends to work on it anymore. [1] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #11 from Andre Klapper aklap...@wikimedia.org --- For the records, previous patches that need rework: https://gerrit.wikimedia.org/r/#/c/99359/ and https://gerrit.wikimedia.org/r/#/c/99366/ See comment 9 and comment 10 for instructions on Gerrit usage. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #12 from Durga durgasubramania...@gmail.com --- Patch - https://gerrit.wikimedia.org/r/#/c/99359/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #7 from Mark Holmquist mtrac...@member.fsf.org --- Was there any progress on this? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #3 from MZMcBride b...@mzmcbride.com --- (In reply to comment #2) Had a contributor contact me saying they wanted to take a crack - let's watch! :) As did I. The real issue here is bug 40497. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #4 from Andre Klapper aklap...@wikimedia.org --- durgasubramanian94: Please add comments to bug reports instead of sending private emails. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Quim Gil q...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||q...@wikimedia.org --- Comment #5 from Quim Gil q...@wikimedia.org --- Hi Durga, some links to help you finding the pieces needed to fix and test this bug report: About Media Viewer: https://www.mediawiki.org/wiki/Multimedia/Media_Viewer https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FMultimediaViewer.git The Media Viewer as deployed in Wikimedia can be tested by enabling Beta featuresin mediawiki.org https://www.mediawiki.org/wiki/Beta_Features You should install the extension in your development environment and find the problem Tisza is reporting. Then find the string mentioned by Tisza in the extension files and modify it as he is requesting. Test the result in your environment and, if you are happy with the result, propose your patch via Gerrit. https://www.mediawiki.org/wiki/Gerrit You fixed your first report by uploading the path in Bugzilla, which was good enough for a newcomer. Now the next step is to learn to do it the right way through Gerrit. You will like it. :) If you have questions, please ask here in the bug report itself, or in #wikimedia-dev IRC. Thank you for your interest in improving Media Viewer and good luck! -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 --- Comment #6 from Tisza Gergő gti...@gmail.com --- (In reply to comment #5) Then find the string mentioned by Tisza in the extension files and modify it as he is requesting. It should be slightly more complex then that: right now we have a single Learn more on wiki name message, which should be split into a Learn more on wiki name for remotely hosted images and a Learn more for locally hosted images. So you need to add another message, find a way to figure out if the image is local or not (it should be somewhere in the data returned by the API), and select the right message depending on that. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Mark Holmquist mtrac...@member.fsf.org changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |durgasubramania...@gmail.co |org |m --- Comment #2 from Mark Holmquist mtrac...@member.fsf.org --- Had a contributor contact me saying they wanted to take a crack - let's watch! :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Fabrice Florin fflo...@wikimedia.org changed: What|Removed |Added Priority|Low |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 MZMcBride b...@mzmcbride.com changed: What|Removed |Added Keywords||easy CC||b...@mzmcbride.com -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Fabrice Florin fflo...@wikimedia.org changed: What|Removed |Added CC||gti...@gmail.com, ||pgi...@wikimedia.org --- Comment #1 from Fabrice Florin fflo...@wikimedia.org --- Hi Gergo, good suggestion. Yes, let's remove the site name when you are already on that site, and just say 'Learn more', as you propose. Great catch! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Fabrice Florin fflo...@wikimedia.org changed: What|Removed |Added Blocks||56265 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56121] Text of learn more link is awkward for local files
https://bugzilla.wikimedia.org/show_bug.cgi?id=56121 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low Blocks||38638 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
