[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 Bartosz Dziewoński changed: What|Removed |Added CC||yyairr...@gmail.com --- Comment #11 from Bartosz Dziewoński --- *** Bug 61121 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 --- Comment #10 from TMg --- Created attachment 13915 --> https://bugzilla.wikimedia.org/attachment.cgi?id=13915&action=edit Other possible solution for clickable regions (In reply to comment #9) > need some sort of indicator which parts are clickable. In my first screenshot the indicator is the text. Regular text = clickable, smaller text = not clickable. I'm aware that it's not a perfect solution. There are others, see my second screenshot. On non-touch devices the mouse pointer is a very strong indicator. That's the other issue I spoke about: Currently the mouse pointer never changes. Everything is clickable. There is no separation between the individual notifications and no separation between the diff link and the rest of a notification. This is an other issue but can be fixed along with this one. > The original [...] was to handle the "outer" link with JavaScript event > handlers, but that means that middle-click etc. won't work I know. Don't get me wrong. The current solution is much better compared to the JavaScript one. It should not be reverted. However, there must be a solution that does not violates specs. > not a major issue As I said: I understand, but the same time I consider invalid HTML a major issue. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 --- Comment #9 from Bartosz Dziewoński --- I'm not sure about that, I think it'd need some sort of indicator which parts are clickable. We could come up with some cleverer solution that wouldn't need the stupid nesting, maybe. The original one (before I implemented this) was to handle the "outer" link with JavaScript event handlers, but that means that middle-click etc. won't work without some careful separate handling and probably won't be consistent with browsers' behavior anyway. (See bug 52319 for discussion about that.) But anyway, I won't have time to work on this anytime soon, sorry (note that I'm just a volunteer). We could consider reverting my patch, of course, but I believe that would be a step back (since the nesting is not causing any major issues – really, somebody would have complained if the links didn't work! – the only thing I've heard is that middle-click doesn't work well on Opera, and I only heard it from you here and this really is not a major issue :) ). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418
--- Comment #8 from TMg ---
Created attachment 13896
--> https://bugzilla.wikimedia.org/attachment.cgi?id=13896&action=edit
Shrink the clickable regions
Your argument is to be pragmatic. I love pragmatism. But this is going to far.
Nested links are illegal.[1] If fundamental stuff like this is ignored, what's
the point in having a spec?
It may be true that it works in current versions of all major browsers. But I
still remember a time where nested links were completely ignored. Are you sure
these browser versions aren't used any more? It also causes a number of other
problems. For example, simple CSS selectors like
.mw-echo-notifications a { background:red !important; }
cause strange and probably unexpected results. Tooltips become misleading:
Please see my longer comment about the clickable areas in the overlay.[2] My
favorite solution is to shrink the clickable regions as shown in the attached
screenshot. This will solve this bug as well as other issues.
[1]http://www.w3.org/TR/html401/struct/links.html#h-12.2.2
[2]http://en.wikipedia.org/wiki/Wikipedia_talk:Notifications/Archive_4#When_are_we_getting_diffs.2C_Part_Deux
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 Bartosz Dziewoński changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- --- Comment #7 from Bartosz Dziewoński --- Per the report in bug 57432, old Opera 12 has issues when trying to open that link in a new tab; it open correctly when you just click it, however. Not sure if that is really something we should concern ourselves with, but let's reopen. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 Bartosz Dziewoński changed: What|Removed |Added CC||mr.h...@gmx.de --- Comment #6 from Bartosz Dziewoński --- *** Bug 57432 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 Alex Monk changed: What|Removed |Added Status|NEW |RESOLVED CC||kren...@gmail.com Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 --- Comment #5 from Bartosz Dziewoński --- I haven't been able to find a document that would call nesting elements invalid in XHTML, so I presumed it to be valid. And as far as I understand it the DTD does not technically disallow a structure like … (and this is the kind of structure used here), it merely disallows …. Either way, that was just a side point. My main point is that this works. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 --- Comment #4 from Danny B. --- (In reply to comment #1) > c) It is also fully valid XHTML, which likely explains why this works. How it can be valid XHTML, when 's can't be nested in XHTML as well? http://www.w3.org/TR/xhtml1/dtds.html#dtdentry_xhtml1-transitional.dtd_a -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 --- Comment #3 from sp...@wikimedia.org --- The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/394, but people from the community are welcome to contribute here and in Gerrit. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 Bartosz Dziewoński changed: What|Removed |Added CC||ebernhard...@wikimedia.org, ||matma@gmail.com, ||rkald...@wikimedia.org --- Comment #1 from Bartosz Dziewoński --- This was done by me in https://gerrit.wikimedia.org/r/#/c/77824/ as the solution to bug 52319, detailed rationale is included in the commit message. tl;dr: a) This is not HTML markup, but dynamically generated HTML DOM; b) All browsers I know of support this, including IE6; c) It is also fully valid XHTML, which likely explains why this works. I suggest WONTFIXing this bug, but I am ready to be convinced if you come up with irrefutable arguments. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 Bartosz Dziewoński changed: What|Removed |Added Blocks|209, 19719 | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 56418] Invalid HTML in Echo notification list pop-up
https://bugzilla.wikimedia.org/show_bug.cgi?id=56418 --- Comment #2 from Bartosz Dziewoński --- I removed two of the tracking bugs: * bug 209 is about markup only, and this is not markup * bug 19719 is about HTML5, and this is not related to any of the '5' features Bug 700 being about code quality issues is a valid tracker assuming we consider this to be an issue (which I don't). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
