[Bug 56920] wgPageContentLanguage broken on Incubator, returns en always

2014-03-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56920

Robin Pepermans (SPQRobin) robinp.1...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Robin Pepermans (SPQRobin) robinp.1...@gmail.com ---
(In reply to Aravind K N from comment #3)
 Is it the last line which is creating the problem? This is on
 WikimediaIncubator/IncubatorUnitTests.php

Those are unit tests, i.e. meant to test the actual code but is not part of the
actual code so cannot create any problems.


(In reply to Hydriz Scholz from comment #2)
 It seems to me that it is an intended behavior. If the language isn't
 localized in MediaWiki, MediaWiki doesn't know what the language is, it
 wouldn't be able to display wgPageContentLanguage correctly. Do correct me
 if I am wrong.

Indeed, the code tries to make a language object for xyz in Wx/xyz/Title, but
MediaWiki only does that if it recognizes the language. There is some
inconsistency however, because the lang attribute in the mw-content-text div
tag is always set to the language code. E.g. on Wp/grc the page content
language is always grc, but on e.g. Wp/lkt it's en except for the mentioned
attribute (maybe more). Since we expect active languages to be localized, there
shouldn't be any issue.

Closing as WORKSFORME, feel free to reopen if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56920] wgPageContentLanguage broken on Incubator, returns en always

2014-02-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56920

Aravind K N arav...@gmail.com changed:

   What|Removed |Added

 CC||arav...@gmail.com

--- Comment #3 from Aravind K N arav...@gmail.com ---
function testOnPageContentLanguage() {
$title = Title::newFromText( 'Wp/nl/Test' );
$this-assertEquals( $title-getPageLanguage()-getCode(), 'nl');
$title = Title::newFromText( 'Template:Wp/be-tarask/Test' );
  $this-assertEquals($title-getPageLanguage()-getCode()'betarask' );
$title = Title::newFromText( 'Project:Wp/nl/Test' );
$this-assertEquals( $title-getPageLanguage()-getCode(), 'en');
}

Is it the last line which is creating the problem? This is on
WikimediaIncubator/IncubatorUnitTests.php

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56920] wgPageContentLanguage broken on Incubator, returns en always

2014-01-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56920

Hydra hy...@alphacorp.tk changed:

   What|Removed |Added

 CC||hy...@alphacorp.tk

--- Comment #2 from Hydra hy...@alphacorp.tk ---
It seems to me that it is an intended behavior. If the language isn't localized
in MediaWiki, MediaWiki doesn't know what the language is, it wouldn't be able
to display wgPageContentLanguage correctly. Do correct me if I am wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 56920] wgPageContentLanguage broken on Incubator, returns en always

2013-11-13 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=56920

Andre Klapper aklap...@wikimedia.org changed:

   What|Removed |Added

Summary|wgPageContentLanguage   |wgPageContentLanguage
   |broken on Incubator,|broken on Incubator,
   |returns en |returns en always

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l