[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #16 from Tisza Gergő  ---
*** Bug 66652 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Tisza Gergő  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Tisza Gergő  ---
(In reply to Lupo from comment #11)
> This code does _not_ look good. '/^\s+(.*)\s+$/' is wrong. It fails to trim
> if there are no leading blanks (or no trailing blanks). And watch out for
> the greedy (.*), that also looks wrong.

D'oh, that was stupid. Thanks for fixing, Lupo & TheDJ!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #14 from Gerrit Notification Bot  ---
Change 155901 merged by jenkins-bot:
TemplateParser: Fix whitespace trim

https://gerrit.wikimedia.org/r/155901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #13 from Gerrit Notification Bot  ---
Change 155901 had a related patch set uploaded by TheDJ:
TemplateParser: Fix whitespace trim

https://gerrit.wikimedia.org/r/155901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|REOPENED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #12 from Lupo  ---
(In reply to Tisza Gergő from comment #10)
> Also, Lokal_Profil is right that the newline is
> not always present in the HTML code. I'll test locally with the examples
> mentioned here.

Not correct. See

https://commons.wikimedia.org/w/api.php?action=query&prop=imageinfo&iiprop=extmetadata&format=jsonfm&titles=File:Landsort_Lighthouse_August_2013_09.jpg

Returns the same trailing newlines for UsageTerms and LicenseUrl.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #11 from Lupo  ---
This code does _not_ look good. '/^\s+(.*)\s+$/' is wrong. It fails to trim if
there are no leading blanks (or no trailing blanks). And watch out for the
greedy (.*), that also looks wrong.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #10 from Tisza Gergő  ---
The code to remove is in
https://gerrit.wikimedia.org/r/#/c/120948/1/TemplateParser.php which at a
glance seems correct to me. Also, Lokal_Profil is right that the newline is not
always present in the HTML code. I'll test locally with the examples mentioned
here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #9 from Lupo  ---
As stated in bug 69497, these newlines are in the license template, and the
code doing the HTML scraping there had better remove them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Tisza Gergő  changed:

   What|Removed |Added

 CC||lupo.bugzi...@gmail.com

--- Comment #8 from Tisza Gergő  ---
*** Bug 69497 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #7 from Lokal_Profil  ---
Looking at the html source of the example above [1] there is no trace of these
newline characters. Hence it might not be a cleaning/trimming issue in the
TemplateParser but rather inserted by it?

[1]
https://commons.wikimedia.org/wiki/File:Landsort_Lighthouse_August_2013_09.jpg

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Lokal_Profil  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=65573

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Lokal_Profil  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||lokal_pro...@hotmail.com
 Resolution|FIXED   |---

--- Comment #6 from Lokal_Profil  ---
This issue is occurring again. See e.g.
https://commons.wikimedia.org/w/api.php?action=query&prop=imageinfo&format=json&iiprop=commonmetadata|extmetadata&iilimit=1&titles=File%3ALandsort%20Lighthouse%20August%202013%2009.jpg

where
"LicenseShortName": {
"value": "CC-BY-SA-3.0\n",
"source": "commons-desc-page",
"hidden": ""
},
"UsageTerms": {
"value": "Creative Commons Attribution-Share Alike 3.0\n",
"source": "commons-desc-page",
"hidden": ""
},
"LicenseUrl": {
"value": "http://creativecommons.org/licenses/by-sa/3.0\n";,
"source": "commons-desc-page",
"hidden": ""
},

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Tisza Gergő  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #5 from Gerrit Notification Bot  ---
Change 120948 merged by jenkins-bot:
Clean parsed HTML

https://gerrit.wikimedia.org/r/120948

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #4 from Gerrit Notification Bot  ---
Change 120948 had a related patch set uploaded by Gergő Tisza:
Clean parsed HTML

https://gerrit.wikimedia.org/r/120948

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #3 from Gerrit Notification Bot  ---
Change 97743 abandoned by Gergő Tisza:
Trim HTML-based metadata values

Reason:
Abandoning this change since InformationParser has been completely rewritten in
the meantime.

https://gerrit.wikimedia.org/r/97743

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #2 from Gerrit Notification Bot  ---
Change 97743 had a related patch set uploaded by Gergő Tisza:
Trim HTML-based metadata values

https://gerrit.wikimedia.org/r/97743

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Tisza Gergő  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|wikibugs-l@lists.wikimedia. |gti...@wikimedia.org
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

--- Comment #1 from Jean-Fred  ---
Looking more around, '\n' are added to several values:

See

:

"Credit": {
"value": "\nSelf-photographed",
"source": "commons-desc-page",
"hidden": ""
},
"LicenseUrl": {
"value": "http://creativecommons.org/licenses/by-sa/3.0\n";,
"source": "commons-desc-page",
"hidden": ""
},
"LicenseShortName": {
"value": "CC-BY-SA-3.0\n",
"source": "commons-desc-page",
"hidden": ""
},
"UsageTerms": {
"value": "Creative Commons Attribution-Share Alike 3.0\n",
"source": "commons-desc-page",
"hidden": ""
},

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 57458] '\n' are added to various elements in CommonsMetadata output

[bugzilla-daemon]

https://bugzilla.wikimedia.org/show_bug.cgi?id=57458

Jean-Fred  changed:

   What|Removed |Added

Summary|Incorrect URL for CC|'\n' are added to various
   |licence in CommonsMetadata  |elements in CommonsMetadata
   |LicenseUrl  |output

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l