[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 Bryan Davis bda...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #21 from Bryan Davis bda...@wikimedia.org --- I think all of the work for this was completed when Antoine closed bug 58279. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #20 from Antoine hashar Musso has...@free.fr --- (In reply to comment #19) It would be nice if we could add a lint job that validates that the data/i18n/*.json files are valid json. I don't know if jshint could be used to do this validation or if it would require some other lint program. That is now bug 58279 add a JSON linter for CI -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #19 from Bryan Davis bda...@wikimedia.org --- It would be nice if we could add a lint job that validates that the data/i18n/*.json files are valid json. I don't know if jshint could be used to do this validation or if it would require some other lint program. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97728 abandoned by Hashar: Jenkins job validation (DO NOT SUBMIT) https://gerrit.wikimedia.org/r/97728 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 Bryan Davis bda...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW Blocks|57545 | --- Comment #17 from Bryan Davis bda...@wikimedia.org --- Removing block on deploy -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #13 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97728 restored by Hashar: Jenkins job validation (DO NOT SUBMIT) https://gerrit.wikimedia.org/r/97728 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #14 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 98501 had a related patch set uploaded by Hashar: wikimedia-wikimania-scholarships-jslint now voting https://gerrit.wikimedia.org/r/98501 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #15 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 98501 merged by jenkins-bot: wikimedia-wikimania-scholarships-jslint now voting https://gerrit.wikimedia.org/r/98501 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #16 from Antoine hashar Musso has...@free.fr --- still need phpcs jobs -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|wikibugs-l@lists.wikimedia. |has...@free.fr |org | --- Comment #1 from Antoine hashar Musso has...@free.fr --- Need to slightly refactor Jenkins Job Builder configuration to provide basic macro that will make that easy. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97726 had a related patch set uploaded by Hashar: phpunit job + wikimedia/wikimania-scholarships https://gerrit.wikimedia.org/r/97726 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97726 merged by jenkins-bot: phpunit job + wikimedia/wikimania-scholarships https://gerrit.wikimedia.org/r/97726 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97727 had a related patch set uploaded by Hashar: triggers for wikimedia/wikimania-scholarships https://gerrit.wikimedia.org/r/97727 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97727 merged by jenkins-bot: triggers for wikimedia/wikimania-scholarships https://gerrit.wikimedia.org/r/97727 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97728 had a related patch set uploaded by Hashar: Jenkins job validation (DO NOT SUBMIT) https://gerrit.wikimedia.org/r/97728 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97729 had a related patch set uploaded by Hashar: phpunit-junit builder missed full path to phpunit https://gerrit.wikimedia.org/r/97729 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97729 merged by jenkins-bot: phpunit-junit builder missed full path to phpunit https://gerrit.wikimedia.org/r/97729 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 97728 abandoned by Hashar: Jenkins job validation (DO NOT SUBMIT) https://gerrit.wikimedia.org/r/97728 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW Assignee|has...@free.fr |wikibugs-l@lists.wikimedia. ||org --- Comment #10 from Antoine hashar Musso has...@free.fr --- The php jobs have been deployed. Now need to have the project pass jshint, thus you get some changes to review: https://gerrit.wikimedia.org/r/97730 configure jshint https://gerrit.wikimedia.org/r/97731 fix jshint issues -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 Antoine hashar Musso has...@free.fr changed: What|Removed |Added Priority|Unprioritized |Normal Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 Bryan Davis bda...@wikimedia.org changed: What|Removed |Added CC||bda...@wikimedia.org --- Comment #11 from Bryan Davis bda...@wikimedia.org --- jshint fixes are merged. \o/ I think it would be nice to add phpcs to this project too. I'd actually like phpcs lenient to be voting on this code I think but only if the vendor directory can be excluded. I don't want to have folks be tempted to edit code that we pull in via composer. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57572] Setup linting / phpunit tests for wikimedia/wikimania-scholarships
https://bugzilla.wikimedia.org/show_bug.cgi?id=57572 --- Comment #12 from Bryan Davis bda...@wikimedia.org --- Chad also fixed a gerrit permissions problem that was keeping the submit part of gate-and-submit from working. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
