[Bug 58095] wfWarn should not cause unit tests to fail
https://bugzilla.wikimedia.org/show_bug.cgi?id=58095 Marcin Cieślak marcin.cies...@gmail.com changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=57724 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58095] wfWarn should not cause unit tests to fail
https://bugzilla.wikimedia.org/show_bug.cgi?id=58095 Marcin Cieślak marcin.cies...@gmail.com changed: What|Removed |Added Priority|Unprioritized |High -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58095] wfWarn should not cause unit tests to fail
https://bugzilla.wikimedia.org/show_bug.cgi?id=58095 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58095] wfWarn should not cause unit tests to fail
https://bugzilla.wikimedia.org/show_bug.cgi?id=58095 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 99648 had a related patch set uploaded by saper: wfWarn() should NOT cause unit tests to fail https://gerrit.wikimedia.org/r/99648 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58095] wfWarn should not cause unit tests to fail
https://bugzilla.wikimedia.org/show_bug.cgi?id=58095 Marcin Cieślak marcin.cies...@gmail.com changed: What|Removed |Added Blocks||57922 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58095] wfWarn should not cause unit tests to fail
https://bugzilla.wikimedia.org/show_bug.cgi?id=58095 --- Comment #2 from Marcin Cieślak marcin.cies...@gmail.com --- Seems that SpecialPageTest::testInvalidGetTitleFor and SpecialPageTest::testGetTitleFor seem to be affected by this in some way: (1) on one hand they depend on wfWarn() calling trigger_error and PHPUnit catches this (and the test is annotated with @expectedException PHPUnit_Framework_Error_Notice), so disabling $wgDevelopmentWarnings makes PHPUnit to complain that this exception does not occur, (2) on the other hand though further execution is stopped with trigger_error and $this-assertEquals( $expected, $title ); clauses in the test are never executed. I think we could easily have something like @expectWarningString in the PHPUnit test annotations, but the question is how to properly catch warnings in a way that they don't interrupt further execution of the tested code. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
