[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 CC||tobias.gritschacher@wikimed
   ||ia.de
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

Lydia Pintscher lydia.pintsc...@wikimedia.de changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

--- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 106897 merged by Jeroen De Dauw:
Merge References for Statements in wbmergeitems

https://gerrit.wikimedia.org/r/106897

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-17 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

Bene* benestar.wikime...@googlemail.com changed:

   What|Removed |Added

 CC||benestar.wikimedia@googlema
   ||il.com

--- Comment #6 from Bene* benestar.wikime...@googlemail.com ---
Please note that this will be a problem when we want to turn one item into a
redirect after merging because this item *must* be empty after merging so that
no data is lost. Perhaps we need some mechanism where the user has to decide
which statements should be used in question.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 106897 had a related patch set uploaded by Addshore:
Merge References for Statements in wbmergeitems

https://gerrit.wikimedia.org/r/106897

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

--- Comment #1 from Addshore addshorew...@gmail.com ---
This is per a design choice by Denny, I had originally written code that merged
claims as I think you are expecting but the decision was made to not do this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

Marius Hoch h...@online.de changed:

   What|Removed |Added

 CC||vrande...@gmail.com

--- Comment #2 from Marius Hoch h...@online.de ---
(In reply to comment #1)
 This is per a design choice by Denny, I had originally written code that
 merged
 claims as I think you are expecting but the decision was made to not do this.

I feared that would come up as cause... can you remember the exact thing Denny
said? Does it apply to all cases or... (there are quite some different examples
for that, some simpler, some more complex ...) ? If this applies to all cases,
I guess we want to WONTFIX this bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

--- Comment #3 from Addshore addshorew...@gmail.com ---
I seems to remember it applying for all cases but will wait for denny to
respond

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2014-01-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

--- Comment #4 from denny vrandecic vrande...@gmail.com ---
When merging two items, a statement from item 1 and a statement from item 2 can
be merged if the claims are completely identical, i.e. if all qualifiers are
identical and if the main snaks are identical. In particular, if only one claim
has a qualifier and the other one does not, they can not be merged. If the set
of qualifiers is overlapping, but not identical, they cannot be merged.

Merging in this case means that the claim stays, but all references can be
added on the same claim. So if there is a statement with claim X and reference
A on item 1, and a statement with claim X and reference B on item 2, the merged
item can have a statement with claim X and references A and B.

Any difference in the claim though forbids merging, i.e.

population 23
reference A

and

population 23
method counting
reference B

can not be merged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 58850] wbmergeitems isn't merging claims properly

2013-12-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=58850

Lydia Pintscher lydia.pintsc...@wikimedia.de changed:

   What|Removed |Added

   Keywords||need-volunteer
   Priority|Unprioritized   |Highest
 CC||addshorew...@gmail.com,
   ||lydia.pintscher@wikimedia.d
   ||e
 Whiteboard||backlog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l