[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #16 from Matthew Flaschen --- Created attachment 14681 --> https://bugzilla.wikimedia.org/attachment.cgi?id=14681&action=edit GettingStarted two-button modal with nowrap and centering fix in Firefox with French -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #15 from Matthew Flaschen --- Created attachment 14680 --> https://bugzilla.wikimedia.org/attachment.cgi?id=14680&action=edit GettingStarted one-button modal with nowrap and centering fix in Firefox with French -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #14 from Matthew Flaschen --- Yes, after updating piramido core to wmf/1.23wmf15, I get the following screenshots in Firefox. The first is with the category configuration missing (so it's the one-button modal), the second is after I fixed that. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 Steven Walling changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=61922 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 Steven Walling changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #13 from Steven Walling --- This is much better now. Smaller additional changes can be filed in a separate bug. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #12 from Steven Walling --- (In reply to Sam Smith from comment #11) > (In reply to Steven Walling from comment #10) > > Created attachment 14676 [details] > > French single CTA on piramido after centering fix > > It looks as if .mw-ui-button is still styled with white-space: nowrap; Is > mediawiki up to date on piramido? Yes it looks like white-space: normal; is what's in prod, and applying that fixes this issue. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #11 from Sam Smith --- (In reply to Steven Walling from comment #10) > Created attachment 14676 [details] > French single CTA on piramido after centering fix It looks as if .mw-ui-button is still styled with white-space: nowrap; Is mediawiki up to date on piramido? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #10 from Steven Walling --- Created attachment 14676 --> https://bugzilla.wikimedia.org/attachment.cgi?id=14676&action=edit French single CTA on piramido after centering fix -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #9 from Steven Walling --- Tested this on piramido.wmflabs.org and mostly it looks good... but French + the single CTA has the text overflowing. (See attachment). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #8 from Matthew Flaschen --- Created attachment 14659 --> https://bugzilla.wikimedia.org/attachment.cgi?id=14659&action=edit GettingStarted modal after centering fix in Chromium with French -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #7 from Matthew Flaschen --- Created attachment 14658 --> https://bugzilla.wikimedia.org/attachment.cgi?id=14658&action=edit GettingStarted modal after centering fix in Chromium with Ukranian -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #6 from Matthew Flaschen --- That also improves matters somewhat for long text. It doesn't put the buttons on one line (there is an explicit width). However, it does remove the explicit height, which means it expands vertically rather than requiring scrolling. I'll attach new screenshots of those languages. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #5 from Gerrit Notification Bot --- Change 114347 merged by jenkins-bot: Center GettingStarted modal in IE7+ https://gerrit.wikimedia.org/r/114347 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #4 from Gerrit Notification Bot --- Change 114347 had a related patch set uploaded by Mattflaschen: Center GettingStarted modal in IE7+ https://gerrit.wikimedia.org/r/114347 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 Steven Walling changed: What|Removed |Added Priority|Unprioritized |High CC||ms...@wikimedia.org, ||pgi...@wikimedia.org -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #3 from Steven Walling --- The biggest impact on the UI here is when the user has the two calls to action. #mw-gettingstarted-editable-main-fix-pages tends to wrap, even to the point of being pushed to a second line, even after we limited the button's width to 210px. The Wikipedias that will soon have both CTAs, and where the worst wrapping happens, is: * ca * de * es * fr * ru * uk I've attached screenshots of three examples to show you the varying degrees of what can happen. Now, this technically isn't broken, since the user can scroll within the modal. But that's a really crappy experience. If we continue to need to use fixed width rendering, we should consider partially undoing the change that limited the width even more (gerrit 110946). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #1 from Steven Walling --- Created attachment 14541 --> https://bugzilla.wikimedia.org/attachment.cgi?id=14541&action=edit Ukrainian -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 61055] Improve GettingStarted modal rendering with long text
https://bugzilla.wikimedia.org/show_bug.cgi?id=61055 --- Comment #2 from Steven Walling --- Created attachment 14542 --> https://bugzilla.wikimedia.org/attachment.cgi?id=14542&action=edit French -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
