[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #18 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 166155 merged by jenkins-bot: Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) https://gerrit.wikimedia.org/r/166155 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED Target Milestone|--- |VE-deploy-nextup -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #19 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 167055 had a related patch set uploaded by Alex Monk: Replace calls to ve.bind( fn, ... ) with fn.bind( ... ) https://gerrit.wikimedia.org/r/167055 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #20 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 167055 merged by jenkins-bot: Replace calls to ve.bind( fn, ... ) with fn.bind( ... ) https://gerrit.wikimedia.org/r/167055 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Blocks|72156 | Resolution|--- |FIXED Target Milestone|VE-deploy-nextup|VE-deploy-2014-10-23 --- Comment #21 from James Forrester jforres...@wikimedia.org --- Removal of this function is punted to bug 72156. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Blocks||72156 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Blocks||72156 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #16 from James Forrester jforres...@wikimedia.org --- (In reply to Alex Monk from comment #15) (In reply to Krinkle from comment #14) VisualEditor core, and OOjs UI. Me and Krinkle spoke about this and think it would be a better idea to defer this for now. PhantomJS is not implementing Function#bind (like we would expect) and that's necessary for the tests to succeed. In other repos we get around this by loading es5-shim but in these ones we should be able to rely on ES5 properly. With I64a0bd96b in VE-core and If2da01a25 in OOUI this is no longer a blocker. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #17 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 166155 had a related patch set uploaded by Alex Monk: Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... ) https://gerrit.wikimedia.org/r/166155 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 Alex Monk kren...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED --- Comment #15 from Alex Monk kren...@wikimedia.org --- (In reply to Krinkle from comment #14) VisualEditor core, and OOjs UI. Me and Krinkle spoke about this and think it would be a better idea to defer this for now. PhantomJS is not implementing Function#bind (like we would expect) and that's necessary for the tests to succeed. In other repos we get around this by loading es5-shim but in these ones we should be able to rely on ES5 properly. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #12 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 144840 merged by jenkins-bot: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) https://gerrit.wikimedia.org/r/144840 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #13 from Alex Monk kren...@wikimedia.org --- (In reply to Krinkle from comment #7) We now have the polyfill for Function.prototype.bind provided by MediaWiki so this should be easier to do now. Heh. Anyway, is there anything else to do here? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #14 from Krinkle krinklem...@gmail.com --- (In reply to Alex Monk from comment #13) (In reply to Krinkle from comment #7) We now have the polyfill for Function.prototype.bind provided by MediaWiki so this should be easier to do now. Heh. Anyway, is there anything else to do here? VisualEditor core, and OOjs UI. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 Ed Sanders esand...@wikimedia.org changed: What|Removed |Added CC||esand...@wikimedia.org --- Comment #9 from Ed Sanders esand...@wikimedia.org --- If we're going to replace ve.bind it should be done in ve core first so we'll need a polyfill there. In ve-mw we can omit that polyfill as mw loads it's own. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #10 from Krinkle krinklem...@gmail.com --- Why? How is this different from the other ES5 methods we've been using already? VisualEditor nor OOjs UI support ES3 engines afaik. MediaWiki itself does, and OOjs core does (for other consumers of OOjs). But we don't (we user .super which breaks IE's ES3 parser, Array.isArray, Object.keys etc.) mw-ve, ve-core, oojs-ui, and oojs all share a requirement for ES5 environments beyond just the polyfillable methods. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #11 from Krinkle krinklem...@gmail.com --- (In reply to Krinkle from comment #10) Why? How is this different from the other ES5 methods we've been using already? VisualEditor nor OOjs UI support ES3 engines afaik. MediaWiki itself does, and OOjs core does (for other consumers of OOjs). But we don't (we user .super which breaks IE's ES3 parser, Array.isArray, Object.keys etc.) mw-ve, ve-core, oojs-ui, and oojs all share a requirement for ES5 environments beyond just the polyfillable methods. oojs-core supports ES3 engines but requires an ES5 shim. The same would apply to OOjs UI and/or VisualEditor core if and when we decide to support older browsers. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #8 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 144840 had a related patch set uploaded by Alex Monk: Replace ve.bind( fn, ... ) calls with fn.bind( ... ) https://gerrit.wikimedia.org/r/144840 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #7 from Krinkle krinklem...@gmail.com --- We now have the polyfill for Function.prototype.bind provided by MediaWiki so this should be easier to do now. Simply replace all uses of $.proxy(fn..) and ve.bind(fn) in the modules/ directory with calls to fn.bind(..). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Assignee|jforrester+veteambztickets@ |kren...@wikimedia.org |wikimedia.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|01tonytho...@gmail.com |jforrester+veteambztickets@ ||wikimedia.org --- Comment #6 from Tony Thomas 01tonytho...@gmail.com --- Sorry, I got bit busy with my other project. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #5 from James Forrester jforres...@wikimedia.org --- Ping on this bug again – do you need any support/advice/help? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #4 from Krinkle krinklem...@gmail.com --- (In reply to James Forrester from comment #1) Tony, are you planning to take on this bug? I plan to. But is there anything like bind() is only present in modern browsers ? Indeed, Function.prototype.bind is new in ECMAScript 5, which VisualEditor requires. Or rather, VE requires ECMAScript 3 syntax engine and an environment that somehow provides certain ES5 features, which can potentially be polyfilled. We don't yet (and that is by design), adopt any ES5 syntax or ES5 features that can't be polyfilled. This is already guarded against using the feature test in our mw integration init[1], so you can rely on this without having to worry about old browsers. (In reply to Roan Kattouw from comment #3) I'd recommend #2 for consistency (we do the same with other ES5 features we've adopted) and minor performance micro optimisation (extra global and property, extra callstack because it has to be a proxy calling bind, unlike Array.isArray is can't be assigned to ve.bind by reference because bind needs to be bound itself) and because we're already using '.bind' in a few places. But keeping ve.bind with a small wrapper to bind using bind seems fine for backwards compatibility with ve plugins in the wild. But I'd recommend we don't use this in core. [1] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/7e52a1ab2ab514/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js#L74-L93 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 Tony Thomas 01tonytho...@gmail.com changed: What|Removed |Added CC||01tonytho...@gmail.com Assignee|jforrester+veteambztickets@ |01tonytho...@gmail.com |wikimedia.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 James Forrester jforres...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Low Status|NEW |ASSIGNED Severity|normal |enhancement --- Comment #1 from James Forrester jforres...@wikimedia.org --- Tony, are you planning to take on this bug? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #2 from Tony Thomas 01tonytho...@gmail.com --- (In reply to James Forrester from comment #1) Tony, are you planning to take on this bug? I plan to. But is there anything like bind() is only present in modern browsers ? will replacing, say this.$element.on( 'keypress', $.proxy( this.keyup, this ) ) with this.$element.on( 'keypress', this.keyup.bind(this)) will do the trick ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 62762] VisualEditor: Get rid of $.proxy, use native .bind()
https://bugzilla.wikimedia.org/show_bug.cgi?id=62762 --- Comment #3 from Roan Kattouw roan.katt...@gmail.com --- We don't use $.proxy() directly in the VE code base, instead we set ve.bind = $.proxy; and use ve.bind(). Yes, this.keyup.bind() exists in modern browsers. It doesn't exist in older browsers, but we don't really care because VE doesn't support browsers that old for lots of other reasons anyway. There are two ways we could approach this. I'll ask Krinkle which one he thinks is best before we proceed. #1 is to migrate uses of ve.bind( this.foo, this ); to this.foo.bind( this ); across the code base, then deprecate and later remove ve.bind(). This would be pretty laborious. #2 is to change ve.bind() to a wrapper that uses native .bind(). This will change every single function binding in the entire codebase to use native bind instantaneously. My guess it's probably best to do #2 first, then #1 later, but I'd like Krinkle to weigh in on this. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
