[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-06-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

Lydia Pintscher lydia.pintsc...@wikimedia.de changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-22 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 133286 merged by jenkins-bot:
Handle DVs that mismatch a prop's expected type

https://gerrit.wikimedia.org/r/133286

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-20 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 Whiteboard|u=dev c=backend p=5 |u=dev c=backend p=5
   |s=2014-05-06|s=2014-05-20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-14 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

--- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 133286 had a related patch set uploaded by Daniel Kinzler:
Handle DVs that mismatch a prop's expected type

https://gerrit.wikimedia.org/r/133286

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

--- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 131665 abandoned by Aude:
Handle mismatching data type / values in snak formatter

Reason:
will make more sense to sort out ExceptionLocalizer mess first and then split
this in smaller patches

https://gerrit.wikimedia.org/r/131665

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

Aude aude.w...@gmail.com changed:

   What|Removed |Added

 CC||aude.w...@gmail.com
 Depends on||64995

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

--- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 131665 had a related patch set uploaded by Aude:
Handle mismatching data type / values in snak formatter

https://gerrit.wikimedia.org/r/131665

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-05-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

Lydia Pintscher lydia.pintsc...@wikimedia.de changed:

   What|Removed |Added

 Whiteboard|u=dev c=backend p=5 |u=dev c=backend p=5
   |s=2014-04-23|s=2014-05-06

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-04-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 Blocks||62495

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-04-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

Daniel Kinzler daniel.kinz...@wikimedia.de changed:

   What|Removed |Added

 CC||daniel.kinz...@wikimedia.de

--- Comment #2 from Daniel Kinzler daniel.kinz...@wikimedia.de ---
(In reply to Adrian Lang from comment #1)
 * If expected data value type does not match actual data value type, add
 error to output (for widget html)

Thinking about it, we'll need this also for wikitext output, for use on the
client. So I suggest to make include error info a formatter option, so we can
control whether error info is inlined in each context.

 * look up formatter based on property data type if expected data value type
 matches actual data value type
 * If no formatter found, look up formatter for actual data value type
 
 Put together: Always format value, try to give error messages if there are
 mismatches.

Furthermore, if formatting of the DataValue for some other reason fails with an
exception, the ValueSnakFormatter should catch that exception, log it (probably
using wfWarn, not wfLogWarning), and optionally include it in the return value.
In that case, use an ExceptionLocalizer to generate a human readable version of
the error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-04-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 Whiteboard|u=dev c=frontend p=0|u=dev c=backend p=0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-04-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 CC||tobias.gritschacher@wikimed
   ||ia.de
Summary|A snak with a quantity  |Snak formatter should
   |property and a string value |handle mismatches between
   |is rendered normally|Snak's DataType and actual
   |instead of showing an error |type of the DataValue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-04-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 Whiteboard|u=dev c=backend p=0 |u=dev c=backend p=5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 63299] Snak formatter should handle mismatches between Snak's DataType and actual type of the DataValue

2014-04-23 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=63299

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

   Priority|Normal  |High
 Status|NEW |ASSIGNED
 Whiteboard|u=dev c=backend p=5 |u=dev c=backend p=5
   ||s=2014-04-23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l