[Bug 63979] Dirty _rtselser diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=63979 ssas...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from ssas...@wikimedia.org --- Will be deployed on Monday, Apr 21st. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63979] Dirty _rtselser diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=63979 --- Comment #4 from Gerrit Notification Bot --- Change 126854 merged by jenkins-bot: Bug 63979: Accept comments in eofl position https://gerrit.wikimedia.org/r/126854 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63979] Dirty _rtselser diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=63979 --- Comment #3 from Gerrit Notification Bot --- Change 126854 had a related patch set uploaded by GWicke: Bug 63979: Accept comments in eofl position https://gerrit.wikimedia.org/r/126854 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63979] Dirty _rtselser diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=63979 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63979] Dirty _rtselser diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=63979
--- Comment #2 from Gabriel Wicke ---
Seems to be a tokenizer issue:
echo -ne '\n:{|\n|foo\n|}' | node parse --trace
peg-tokens
trace/peg-tokens : TOKS:
[{"type":"SelfclosingTagTk","name":"meta","attribs":[{"k":"typeof","v":"mw:EmptyLine"}],"dataAttribs":{"tokens":[{"type":"COMMENT","value":"
foo
","dataAttribs":{"tsr":[0,12]}},"\n"],"tsr":[0,13]}},{"type":"TagTk","name":"listItem","attribs":[],"dataAttribs":{"tsr":[13,14]},"bullets":[":"]},"{|"]
trace/peg-tokens : TOKS:
[{"type":"NlTk","dataAttribs":{"tsr":[16,17]}},{"type":"TagTk","name":"td","attribs":[],"dataAttribs":{"tsr":[17,18]}},"foo",{"type":"SelfclosingTagTk","name":"meta","attribs":[{"k":"typeof","v":"mw:TSRMarker"},{"k":"data-tag","v":"td"}],"dataAttribs":{"tsr":[21,21]}},{"type":"NlTk","dataAttribs":{"tsr":[21,22]}},{"type":"EndTagTk","name":"table","attribs":[],"dataAttribs":{"tsr":[22,24]}}]
trace/peg-tokens : TOKS: [{"type":"COMMENT","value":" bar
","dataAttribs":{"tsr":[24,36]}},""]
trace/peg-tokens : TOKS: [{"type":"EOFTk"}]
{|
|foo
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63979] Dirty _rtselser diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=63979
--- Comment #1 from Gabriel Wicke ---
Seems to be related to the tables not actually being parsed as such. Minimal
test case:
echo -ne '\n:{|\n|foo\n|}' | node parse
{|
|foo
--
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 63979] Dirty _rtselser diff
https://bugzilla.wikimedia.org/show_bug.cgi?id=63979 Gabriel Wicke changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
