[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Blocks||70340 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 --- Comment #11 from Ryan Schmidt skizz...@gmail.com --- Patch set 3 was a rework because it broke sqlite, thus breaking every unit test. The fix is incredibly simple; change Database::factory to DatabaseBase::factory on the line mentioned in the error. I am holding off uploading a patch set for the moment as I want to fix bug 69281 at the same time and I do not have the time right now to investigate that one. If I don't have something uploaded to gerrit by next weekend, poke me on IRC as I rarely check bugzilla and bugmail gets lost in all of my emails within a day or so. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 --- Comment #10 from Andre Klapper aklap...@wikimedia.org --- Skizzerz: Could you shed some light on this and reply to comment 9, please? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 --- Comment #9 from Jeff Janes jeff.ja...@gmail.com --- The merged patch set 4 in 1.24 caused other problems under PostgreSQL: https://gerrit.wikimedia.org/r/142472 Fatal error: Class 'Database' not found in /usr/local/apache2/htdocs/wiki_git/includes/installer/PostgresInstaller.php on line 161 The proposed patch set 2 did not cause this problem. I don't know why patch sets 3 and 4 were so different from sets 1 and 2, so I don't how to investigate this further. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142472 had a related patch set uploaded by Legoktm: Set the default database schema to mediawiki so as not to break the CLI installer. https://gerrit.wikimedia.org/r/142472 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 --- Comment #7 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142472 merged by jenkins-bot: Set the default database schema to mediawiki so as not to break the CLI installer. https://gerrit.wikimedia.org/r/142472 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |ASSIGNED --- Comment #8 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- Merged into master. Skizzerz, can you prepare a backport for the REL1_23 branch? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Flags||Backport_to_Stable+ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 142472 had a related patch set uploaded by Skizzerz: (bug 64043) Set the default database schema to mediawiki so as not to break the CLI installer. https://gerrit.wikimedia.org/r/142472 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added CC||legoktm.wikipe...@gmail.com ||, skizz...@gmail.com --- Comment #2 from Andre Klapper aklap...@wikimedia.org --- CC'ing Legoktm and Skizzerz who wrote/review the patch -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Target Milestone|--- |1.23.x release --- Comment #3 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- (In reply to Jeff Janes from comment #1) Since 1.23.0 is already released with this unresolved, is this malfeature now carved in stone? No :) I'll let Skizzerz comment on the actual technical problems/solutions since I have very little experience in this area, but I marked this as a blocker for the next 1.23 release. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Ryan Schmidt skizz...@gmail.com changed: What|Removed |Added Assignee|wikibugs-l@lists.wikimedia. |skizz...@gmail.com |org | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Ryan Schmidt skizz...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 --- Comment #4 from Ryan Schmidt skizz...@gmail.com --- Leaving it at the default value of 'mediawiki' actually broke MySQL, SQLite, and all other DBMSes that did not use a schema after making the changes needed to support MSSQL, which is why the default changed to null. The Postgres installer explicitly adds $wgDBmwschema to LocalSettings.php, and has been doing so since version 1.7 (released over 8 years ago). Since it can be reasonably expected for this variable to be present in LocalSettings.php, modifying the default value shouldn't break any existing wikis. Wikis that have explicitly removed this setting should add it back to LocalSettings.php. I'll look into the CLI installer to see what it's doing later today, from a cursory glance it appears that you can explicitly pass --dbschema to the installer to set the default schema as a workaround. What is likely is that I'll end up hardcoding mediawiki as a default schema in the CLI installer in the event that it isn't given one. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 --- Comment #1 from Jeff Janes jeff.ja...@gmail.com --- Since 1.23.0 is already released with this unresolved, is this malfeature now carved in stone? The command line installer does not have a way to change the default schema and the current default does not work in postgresql. So the command line installer does not work. If we do not revert this change, what is the next best thing? Add the dbschema to the command line installer (it is already there, just commented out)? Change the parts of the code that use the schema to automatically replace NULL with 'public' for PostgreSQL? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |High Summary|change in default schema|change in default schema |complicates installation|for MSSQL complicates |with PostgreSQL |installation with ||PostgreSQL -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Jeff Janes jeff.ja...@gmail.com changed: What|Removed |Added Depends on||64067 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 64043] change in default schema for MSSQL complicates installation with PostgreSQL
https://bugzilla.wikimedia.org/show_bug.cgi?id=64043 Jeff Janes jeff.ja...@gmail.com changed: What|Removed |Added Depends on|64067 | -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
