[Bug 64721] mw.loader.store should not occupy all of localStorage

2014-09-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

--- Comment #10 from Ryan Kaldari  ---
Filed an upstream bug against Firefox at
https://bugzilla.mozilla.org/show_bug.cgi?id=1064466

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage

2014-09-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

--- Comment #9 from Ryan Kaldari  ---
Michael M.: That sounds like a good idea, but doesn't solve the underlying
issue of this bug (that mw.loader.store takes up too much of localStorage).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage

2014-09-01 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

Michael M.  changed:

   What|Removed |Added

 CC||listenle...@gmail.com

--- Comment #8 from Michael M.  ---
What about this approach?
1. Before saving a module to localStorage try to save a string of 20 KB* there.
2. If this fails, don't save the module in localStorage.
3. If it succeeds, try to save the module.
4. Whether or not putting the module in localStorage succeeds, remove the
string from step 1.

This will make sure that the modules never will occupy the last 20 KB* of
localStorage.

*) 20 KB is just the first number that came to my mind. Feel free to replace it
with any other reasonable number. I have several user scripts that make use of
localStorage, they take up 3 KB, but I know users who use them more heavily
than me, they probably end up at about 10 KB or more.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage

2014-08-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

--- Comment #7 from Andre Klapper  ---
Ori: Could you reply to comment 6 please if you have some ideas?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage

2014-08-21 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

--- Comment #6 from Ryan Kaldari  ---
Ori: Any thoughts on this? It's still a significant problem, especially for
Firefox users.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage

2014-08-04 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

Matthew Flaschen  changed:

   What|Removed |Added

 Blocks||42815

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage

2014-08-03 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

Krinkle  changed:

   What|Removed |Added

Summary|mw.loader.store should not  |mw.loader.store should not
   |occupy all of localStorage  |occupy all of localStorage
   |for itself  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage for itself

2014-07-24 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

--- Comment #5 from Matthew Flaschen  ---
(In reply to Krinkle from comment #4)
> mw.loader.store falls back to fetching from the server. However other
> features that actually use localStorage in a more visible way will lose data
> in a much worse way (e.g. users unable to store drafts, or a "hide" button
> not being remembered etc.)

Yep, as you can see from bug 65566 (thanks for marking that as a see also),
we've already had to switch to cookies for a feature due to this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage for itself

2014-07-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

Krinkle  changed:

   What|Removed |Added

   Priority|Normal  |High
   Severity|normal  |major

--- Comment #4 from Krinkle  ---
Raising priority as this will likely become increasingly more problematic as
wikis and extensions register more modules and users enable more features.

mw.loader.store falls back to fetching from the server. However other features
that actually use localStorage in a more visible way will lose data in a much
worse way (e.g. users unable to store drafts, or a "hide" button not being
remembered etc.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage for itself

2014-07-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

Krinkle  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=65566

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage for itself

2014-07-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

--- Comment #3 from Krinkle  ---
*** Bug 65364 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 64721] mw.loader.store should not occupy all of localStorage for itself

2014-07-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=64721

Krinkle  changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com
  Component|JavaScript  |ResourceLoader
   See Also|https://bugzilla.wikimedia. |
   |org/show_bug.cgi?id=65364   |
Summary|MediaWikiModuleStore should |mw.loader.store should not
   |be limited to a certain |occupy all of localStorage
   |size|for itself

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l