[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-07-07 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

--- Comment #6 from Ori Livneh  ---
(In reply to Aaron Schulz from comment #4)
> I saw lots of:
> 
> 2014-06-03 19:12:08 osmium plwiki: Could not unserialize
> ParsoidCacheUpdateJobOnDependencyChange job.
> 
> today...is that a similar issue?

Similar but not identical. I submitted a fix here:
https://github.com/facebook/hhvm/pull/3127

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-07-07 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

Ori Livneh  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-07-07 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

Ori Livneh  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-06-06 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

Ori Livneh  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED

--- Comment #5 from Ori Livneh  ---
There was another bug in the Redis client which also caused failures to
unserialize: https://github.com/facebook/hhvm/pull/2874

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-06-03 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

--- Comment #4 from Aaron Schulz  ---
I saw lots of:

2014-06-03 19:12:08 osmium plwiki: Could not unserialize
ParsoidCacheUpdateJobOnDependencyChange job.

today...is that a similar issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-05-23 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

Ori Livneh  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||o...@wikimedia.org
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-05-19 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

Andre Klapper  changed:

   What|Removed |Added

   Keywords||upstream
   Priority|Unprioritized   |Normal
Version|unspecified |1.24-git

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-05-18 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

--- Comment #3 from Tim Starling  ---
Rather, the missing numkeys was #2555, the error handling issue was fixed in
https://github.com/facebook/hhvm/pull/2603

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-05-18 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

--- Comment #2 from Tim Starling  ---
This is https://github.com/facebook/hhvm/pull/2555 (a fixed bug).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 65466] HHVM fails to unserialize() value in JobQueueRedis.php:798

2014-05-18 Thread bugzilla-daemon 
https://bugzilla.wikimedia.org/show_bug.cgi?id=65466

--- Comment #1 from Tim Starling  ---
strace shows:

sendto(9,
"*9\r\n$7\r\nEVALSHA\r\n$40\r\n46eccb844b00c898d68cb06502b13a906ff3d6a8\r\n$46\r\nfrwiktionary:jobqueue:refreshLinks:l-unclaimed\r\n$45\r\nfrwiktionary:jobqueue:refreshLinks:h-sha1ById\r\n$45\r\nfrwiktionary:jobqueue:refreshLinks:h-idBySha1\r\n$44\r\nfrwiktionary:jobqueue:refreshLinks:z-claimed\r\n$45\r\nfrwiktionary:jobqueue:refreshLinks:h-attempts\r\n$41\r\nfrwiktionary:jobqueue:refreshLinks:h-data\r\n$10\r\n1400461767\r\n",
389, 0, NULL, 0) = 389
recvfrom(9, "-ERR value is not an integer or out of range\r\n", 8192,
MSG_DONTWAIT, NULL, NULL) = 46

If an ERR response is received, Redis::evalSha() should return false and the
last error set: 



Obviously this is not being done; the error string is being returned from
evalSha() as if it were the script result. JobQueueRedis::doPop() then goes
into an infinite loop.

As for the actual server error: comparison with a valid request from phpredis
shows that the "numkeys" parameter is missing, so the first script parameter,
in this case "frwiktionary:jobqueue:refreshLinks:l-unclaimed", is interpreted
as the number of keys.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l