[Bug 68712] Re-examine OutputPageScriptsForBottomQueue hook for extension-added user modules
https://bugzilla.wikimedia.org/show_bug.cgi?id=68712 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 150445 had a related patch set uploaded by Legoktm: Revert Add OutputPageScriptsForBottomQueue hook https://gerrit.wikimedia.org/r/150445 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68712] Re-examine OutputPageScriptsForBottomQueue hook for extension-added user modules
https://bugzilla.wikimedia.org/show_bug.cgi?id=68712 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 149806 abandoned by Legoktm: Load user group modules in individual requests Reason: Not necessary. https://gerrit.wikimedia.org/r/149806 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68712] Re-examine OutputPageScriptsForBottomQueue hook for extension-added user modules
https://bugzilla.wikimedia.org/show_bug.cgi?id=68712 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 150445 merged by jenkins-bot: Revert Add OutputPageScriptsForBottomQueue hook https://gerrit.wikimedia.org/r/150445 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68712] Re-examine OutputPageScriptsForBottomQueue hook for extension-added user modules
https://bugzilla.wikimedia.org/show_bug.cgi?id=68712 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com --- I discussed this with Roan on IRC today. He pointed out that if we use addModuleStyles/addModuleScripts, the modules go through OutputPage::makeResourceLoaderLink, resulting in independent link/script tags as we want, while addModules just adds them to a mw.loader.load array. Additionally, OutputPage already special cases the 'user' group versioning, so that's taken care of. Since we no longer need the hook, I've reverted it, and updated GlobalCssJs as well. Yay! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68712] Re-examine OutputPageScriptsForBottomQueue hook for extension-added user modules
https://bugzilla.wikimedia.org/show_bug.cgi?id=68712 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 149806 had a related patch set uploaded by Legoktm: Load user group modules in individual requests https://gerrit.wikimedia.org/r/149806 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68712] Re-examine OutputPageScriptsForBottomQueue hook for extension-added user modules
https://bugzilla.wikimedia.org/show_bug.cgi?id=68712 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68712] Re-examine OutputPageScriptsForBottomQueue hook for extension-added user modules
https://bugzilla.wikimedia.org/show_bug.cgi?id=68712 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 68712] Re-examine OutputPageScriptsForBottomQueue hook for extension-added user modules
https://bugzilla.wikimedia.org/show_bug.cgi?id=68712 Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed: What|Removed |Added Target Milestone|--- |1.24.0 release -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
