[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

--- Comment #4 from Sam Reed (reedy) s...@reedyboy.net ---
(In reply to Brad Jorsch from comment #3)
 I note that something like
 api.php?format=jsonfmaction=parsetitle=MediaWiki:Common.jstext=[[Category:
 Foo]] can be used to quickly check the bug.
 
 git bisect against core turns up Gerrit change #67983 as the culprit; the
 root of the problem seems to be that the hook function enabled in Gerrit
 change #131447 doesn't bother with the special handling done for
 $wgTextModelsToParse in includes/content/TextContent.php.
 
 I'd suggest any other patches done to support 67983 should be checked for
 similar problems.

Thanks for digging into this, Brad :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

Bartosz Dziewoński matma@gmail.com changed:

   What|Removed |Added

 CC||hartman.w...@gmail.com,
   ||matma@gmail.com,
   ||soxre...@gmail.com
  Component|ContentHandler  |SyntaxHighlight (GeSHi)
Version|unspecified |master
Product|MediaWiki   |MediaWiki extensions

--- Comment #5 from Bartosz Dziewoński matma@gmail.com ---
(In reply to Brad Jorsch from comment #3)
 git bisect against core turns up Gerrit change #67983 as the culprit; the
 root of the problem seems to be that the hook function enabled in
 Gerrit change #131447 doesn't bother with the special handling done for
 $wgTextModelsToParse in includes/content/TextContent.php.

Indeed, this is only happening when the SyntaxHighlight_GeSHi extension is
installed. Changing component accordingly. Let's see how hard this is to fix…

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

--- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 150630 had a related patch set uploaded by Bartosz Dziewoński:
Parse page content using the standard parser first for link tables

https://gerrit.wikimedia.org/r/150630

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

Gerrit Notification Bot gerritad...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

--- Comment #7 from Bartosz Dziewoński matma@gmail.com ---
Ha, wasn't that hard. It's a bit silly that we have to reimplement this logic
in the extension, though.


(In reply to Brad Jorsch from comment #3)
 I'd suggest any other patches done to support 67983 should be checked for
 similar problems.

I am not aware of any changes to any other extensions related to that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

--- Comment #8 from Sam Reed (reedy) s...@reedyboy.net ---
(In reply to Bartosz Dziewoński from comment #7)
 (In reply to Brad Jorsch from comment #3)
  I'd suggest any other patches done to support 67983 should be checked for
  similar problems.
 
 I am not aware of any changes to any other extensions related to that.

Quick grep suggests that ContentGetParserOutput is only used by GeSHi :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

--- Comment #9 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 150630 merged by jenkins-bot:
Parse page content using the standard parser first for link tables

https://gerrit.wikimedia.org/r/150630

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

--- Comment #10 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 150723 had a related patch set uploaded by Legoktm:
Parse page content using the standard parser first for link tables

https://gerrit.wikimedia.org/r/150723

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

--- Comment #11 from Gerrit Notification Bot gerritad...@wikimedia.org ---
Change 150723 merged by jenkins-bot:
Parse page content using the standard parser first for link tables

https://gerrit.wikimedia.org/r/150723

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-30 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 CC||legoktm.wikipe...@gmail.com
 Resolution|--- |FIXED
   Assignee|wikibugs-l@lists.wikimedia. |matma@gmail.com
   |org |

--- Comment #12 from Kunal Mehta (Legoktm) legoktm.wikipe...@gmail.com ---
Fix deployed for 1.24wmf15 today
(https://commons.wikimedia.org/w/api.php?format=jsonfmaction=parsetitle=MediaWiki:Common.jstext=[[Category:Foo]]),
will hit all other wikis during the 1.24wmf15/16 deployment tomorrow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-29 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

Brad Jorsch bjor...@wikimedia.org changed:

   What|Removed |Added

 CC||bjor...@wikimedia.org

--- Comment #3 from Brad Jorsch bjor...@wikimedia.org ---
I note that something like
api.php?format=jsonfmaction=parsetitle=MediaWiki:Common.jstext=[[Category:Foo]]
can be used to quickly check the bug.

git bisect against core turns up gerrit change 67983 as the culprit; the root
of the problem seems to be that the hook function enabled in gerrit change
131447 doesn't bother with the special handling done for $wgTextModelsToParse
in includes/content/TextContent.php.

I'd suggest any other patches done to support 67983 should be checked for
similar problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

Krinkle krinklem...@gmail.com changed:

   What|Removed |Added

Summary|[Regression] Link tables no |[Regression] Link tables
   |longer updates on js/css|(categories, file links,
   |pages   |templates) are being purged
   ||for js/css pages

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 68757] [Regression] Link tables (categories, file links, templates) are being purged for js/css pages

2014-07-28 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=68757

--- Comment #2 from Krinkle krinklem...@gmail.com ---
en.wikipedia.org is also affected. So its probably a regression from 1.24wmf14
or 1.24wmf13.

The problem with this bug is that these links are often used to find things. So
the bug caused those signals to no longer occur. It takes a while for people to
notice it's broken (as opposed to there simply not being any signals). And past
signals (current categorisation) only slowly disappears from the database as
caches expire. This will become a bigger problem as time goes on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l