[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added CC||g...@wikimedia.org --- Comment #14 from Andre Klapper aklap...@wikimedia.org --- What is the next step to perform here, and by who? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #15 from Tisza Gergő gti...@wikimedia.org --- Since this is not really related to the original request anymore, I moved it to bug 72557. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Status|REOPENED|NEW --- Comment #13 from Tisza Gergő gti...@wikimedia.org --- tgr@terbium:~$ mwscript sql.php --wiki=commonswiki clean-mmv-user-property.sql Query OK, 17 row(s) affected Query OK, 1555 row(s) affected ... mysql:research@s4-analytics-slave.eqiad.wmnet [commonswiki] select up_value, count(*) from user_properties where up_property = 'multimediaviewer-enable' group by up_value; +--+--+ | up_value | count(*) | +--+--+ | |3 | | 1| 223 | +--+--+ 2 rows in set (0.01 sec) So, um. MV still seems to be setting '' values. Probably I should redo the optout patch properly, with $wgDefaultUserOptions['multimediaviewer-enable'] set to 1 instead of true. I'll do that once I don't have anything important to do. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Gilles Dubuc gdu...@wikimedia.org changed: What|Removed |Added CC||gdu...@wikimedia.org --- Comment #12 from Gilles Dubuc gdu...@wikimedia.org --- Query reviewed. You can go ahead and run it, Gergo. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #10 from Andre Klapper aklap...@wikimedia.org --- (In reply to Tisza Gergő from comment #8) Fixed in https://gerrit.wikimedia.org/r/#/c/156004/ , needs DB cleanup. Tisza: Who's going to do the DB cleanup (and when)? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #11 from Tisza Gergő gti...@wikimedia.org --- (In reply to Andre Klapper from comment #10) Tisza: Who's going to do the DB cleanup (and when)? Someone from the Multimedia team will do this. Probably this week, although it is not particularly urgent (functionally there is no difference between the correct and incorrect values, but it's ugly and will probably mess up stats scripts). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #8 from Tisza Gergő gti...@wikimedia.org --- The change of default caused some junk to be written in the user_properties table (details in bug 69942): select up_value, count(*) from user_properties where up_property = 'multimediaviewer-enable' group by up_value; +--+--+ | up_value | count(*) | +--+--+ | | 1560 | | 0|2 | | 1| 97 | | true | 17 | +--+--+ Fixed in https://gerrit.wikimedia.org/r/#/c/156004/ , needs DB cleanup. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #9 from Tisza Gergő gti...@wikimedia.org --- The 'toggle' preference type sets an up_value of '1' for enabled, '' for disabled, but the row is omitted if the setting is the same as the default. Commons has MediaViewer disabled as default for logged-in users, so the cleanup query is UPDATE user_properties SET up_value = '1' WHERE up_property = 'multimediaviewer-enable' AND up_value = 'true'; DELETE FROM user_properties WHERE up_property = 'multimediaviewer-enable' AND up_value IN ( '', '0' ); -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Steinsplitter steinsplit...@wikipedia.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Mark Holmquist mtrac...@member.fsf.org changed: What|Removed |Added CC||mtrac...@member.fsf.org --- Comment #7 from Mark Holmquist mtrac...@member.fsf.org --- Note: Also ran a query manually to set the opt-in preference if the user disabled the gadget. It was like 50 people. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #3 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 154396 merged by jenkins-bot: Disable MediaViewer by default for logged-in users on Commons https://gerrit.wikimedia.org/r/154396 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #4 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155443 had a related patch set uploaded by MarkTraceur: Add an option to disable by default for logged-in users https://gerrit.wikimedia.org/r/155443 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #5 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 154395 merged by jenkins-bot: Add an option to disable by default for logged-in users https://gerrit.wikimedia.org/r/154395 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #6 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 155443 merged by MarkTraceur: Add an option to disable by default for logged-in users https://gerrit.wikimedia.org/r/155443 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 154395 had a related patch set uploaded by Gergő Tisza: Add an option to disable by default for logged-in users https://gerrit.wikimedia.org/r/154395 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 154396 had a related patch set uploaded by Gergő Tisza: Disable MediaViewer by default for logged-in users on Commons https://gerrit.wikimedia.org/r/154396 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Sam Reed (reedy) s...@reedyboy.net changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Tisza Gergő gti...@wikimedia.org changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=69080 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69363] Disable Media Viewer by default for logged-in users on Wikimedia Commons
https://bugzilla.wikimedia.org/show_bug.cgi?id=69363 Andre Klapper aklap...@wikimedia.org changed: What|Removed |Added Priority|Unprioritized |Normal -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
