[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 Helder changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #27 from Bartosz Dziewoński --- The revert has been deployed now. Re comment 24, that just means that the patches are based on a slightly different version of MediaWiki. That piece of code dealing with blank pages was added in change c3fcaba0, which wasn't yet merged when the original patch was written, but was already merged when it was backported to 1.24wmf19 for deployment. Nothing to worry about :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #25 from Gerrit Notification Bot --- Change 157679 merged by jenkins-bot: Revert "Toolbar: Only show on WikiText pages" https://gerrit.wikimedia.org/r/157679 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #26 from Gerrit Notification Bot --- Change 157680 merged by jenkins-bot: Revert "Toolbar: Only show on WikiText pages" https://gerrit.wikimedia.org/r/157680 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #24 from George Orwell III --- Errr possible stupid question but please humor my ignorance just in case its not: Did we inadvertently remove some "stuff" from EditPage.php with the merging of... https://gerrit.wikimedia.org/r/#/c/156009/3/includes/EditPage.php ... instead of merging the "more reflective" current state of the file - also containing the reversion of the troublemaking code - in ... https://gerrit.wikimedia.org/r/#/c/157680/1/includes/EditPage.php ...? I only ask because if you toggle between the two, you can clearly see the part dealing with "blankPages" right after the section we're dealing with in the reversion is present in #157680 (as well as in #157679 while we're at it), but not in #156009. And, as I far as I can tell, the part dealing with "blankPages" is also present in the current .php file. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 Bartosz Dziewoński changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #23 from Bartosz Dziewoński --- You're right, the revert fixes this bug, and we should discuss how to re-implement the thing that caused it on bug 29908 (without breaking things this time ;) ). The revert hasn't been deployed on the affected wikis yet, I was confused when I wrote comment 19. It will actually be deployed tomorrow. Nevertheless let's close this bug. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #22 from George Orwell III --- Forgive my "newbie-ness" here, I know 'soap-box' like speeches are frowned up here, but if... https://gerrit.wikimedia.org/r/156009 ... is indeed the reversion of the change(s) that caused the problem reported in this bug in the first place, what else is there to actually "solve" here? Maybe I reached this conclusion because I'm in the same boat as the comments made back in #c15 - I can't keep the needed/wanted regressions separate from the pseudo-patches and/or semi-enhancements that all seem to be lumped together for no discernable good reason now. Granted, my participation here is rather recent but I assure you I've been lurking here for some time now and my observation has always been that there are too many conflicting interests at play all at once. Eventually these interests seem to 'muddy the waters' of a particular bugzilla by arbitrarily usurping some reports as duplicates without proper rationale, diffuse the focus of report by peppering the "see also" list with tangent issues made in other reports or build little self-serving cabals by making other reports blocking/dependent on what should be stand-alone issues or concerns. That said, if the above linked merge resolves the reported issue(s) then I'm of the opinion that this bug should be closed and any further changes should be taken up in the appropriate bugzillas (if they exist) or open a new one addressing whatever needs resolving/discussion. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #21 from Helder --- I believe there are only two proposed solutions: 1) Create a function shouldShowToolbar which returns true if the content model is wikitext (extensions would subclass EditPage I think): https://gerrit.wikimedia.org/r/#/c/157054/1/includes/EditPage.php,unified 2) Create a hook to allow extensions to redefined the value of the variable $showToolbar: https://gerrit.wikimedia.org/r/#/c/120357/6/includes/EditPage.php,unified -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #20 from Gerrit Notification Bot --- Change 156009 merged by jenkins-bot: Revert "Toolbar: Only show on WikiText pages" https://gerrit.wikimedia.org/r/156009 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #19 from Bartosz Dziewoński --- Should have poked someone about it. I +2'd the revert (jenkins seems stuck though) and scheduled it from SWAT deployment today in about an hour (https://wikitech.wikimedia.org/wiki/Deployments#Near-term). Now, can somebody summarize the proposed solutions and their corresponding patch groups, and preferably also say which one is the best and should be merged? :D -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #18 from Gerrit Notification Bot --- Change 157680 had a related patch set uploaded by Bartosz Dziewoński: Revert "Toolbar: Only show on WikiText pages" https://gerrit.wikimedia.org/r/157680 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 --- Comment #17 from Gerrit Notification Bot --- Change 157679 had a related patch set uploaded by Bartosz Dziewoński: Revert "Toolbar: Only show on WikiText pages" https://gerrit.wikimedia.org/r/157679 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 69447] [regression] Unable to get old toolbar in namespace Page: whatsoever the preference request for the old toolbar and break the wikieditor toolbar
https://bugzilla.wikimedia.org/show_bug.cgi?id=69447 Helder changed: What|Removed |Added Keywords||code-update-regression Summary|Unable to get old toolbar |[regression] Unable to get |in namespace Page: |old toolbar in namespace |whatsoever the preference |Page: whatsoever the |request for the old toolbar |preference request for the |and break the wikieditor|old toolbar and break the |toolbar |wikieditor toolbar -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
