[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-11 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

--- Comment #6 from WikidataBugzilla  ---
Commit pushed to statements at
https://github.com/wmde/WikibaseInternalSerialization

https://github.com/wmde/WikibaseInternalSerialization/commit/3186f093d04b5c1a06fedb9193c5e2c1d4c7217e
Normalize claim serialization on Items and use LegacyStatementDeserializer

Problem is that Items might have Claims (e.g. missing 'rank' and 'refs' keys).
Deserializing these now fails on Items. The serialization needs to be
'normalized'
as a Statement to deal with this potential inconsitency in old data.

@todo more tests and clean up of LegacyClaimDeserializer

Bug: 70613

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

--- Comment #5 from WikidataBugzilla  ---
Commit pushed to statements at
https://github.com/wmde/WikibaseInternalSerialization

https://github.com/wmde/WikibaseInternalSerialization/commit/64bbf1c2ab79026765536c7e7a2af2c1a35761e2
Normalize claim serialization on Items and use LegacyStatementDeserializer

Problem is that Items might have Claims (e.g. missing 'rank' and 'refs' keys).
Deserializing these now fails on Items. The serialization needs to be
'normalized'
as a Statement to deal with this potential inconsitency in old data.

@todo more tests and clean up of LegacyClaimDeserializer

Bug: 70613

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

--- Comment #4 from Aude  ---
btw, I do not know yet how much this is an issue in Wikidata, but likely

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

--- Comment #3 from Aude  ---
The Item that fails deserializing has Claims on Items. (e.g. no 'rank' in the
serialization)

the LegacyClaimDeserializer deserializes it as Claim and then does
Item::addClaim() --- horrible deprecated method, btw -- which then does
addStatement() and *boom*, it's not a Statement and the item explodes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-10 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

--- Comment #2 from WikidataBugzilla  ---
Commit pushed to statements at
https://github.com/wmde/WikibaseInternalSerialization

https://github.com/wmde/WikibaseInternalSerialization/commit/fa15e5a3f0f18aa0a080d70001573c36e4000a45
Normalize claim serialization on Items and use LegacyStatementDeserializer

Problem is that Items might have Claims (e.g. missing 'rank' and 'refs' keys).
Deserializing these now fails on Items. The serialization needs to be
'normalized'
as a Statement to deal with this potential inconsitency in old data.

@todo more tests and clean up of LegacyClaimDeserializer

Bug: 70613

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

tobias.gritschac...@wikimedia.de changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 Status|NEW |ASSIGNED
 CC||tobias.gritschacher@wikimed
   ||ia.de
 Whiteboard||u=dev c=backend p=5
   ||s=2014-09-09
   Severity|normal  |major

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 70613] InvalidArgumentException from line 339 of Item.php

2014-09-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=70613

--- Comment #1 from Aude  ---
I was trying to run refreshLinks and there is issue with unserializing content
in my database.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l