[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #21 from Gerrit Notification Bot --- Change 166585 abandoned by Gilles: [DONTMERGE] Role to reproduce 71354 Reason: No need for that to repro the bug anymore https://gerrit.wikimedia.org/r/166585 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #20 from Gilles Dubuc --- What's the process to package a new version? Oddly enough it seems like your fix predates the time the latest package (the one being used by vagrant) was put together: http://apt.wikimedia.org/wikimedia/pool/main/p/php-luasandbox/ -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 Brad Jorsch changed: What|Removed |Added Component|Scribunto |General Version|master |unspecified Product|MediaWiki extensions|MediaWiki-Vagrant --- Comment #19 from Brad Jorsch --- Ok, I managed to downgrade vagrant far enough to avoid bug 71878 and reproduce this. It turns out the bug is already fixed by Gerrit change 159757,[1] but the version of php-luasandbox available to vagrant doesn't include that change. So the action needed here is that the php-luasandbox package used by vagrant needs updating. [1]: Specifically, the lack of the #include is causing the compiler to assume pthread_self() returns an int rather than an unsigned long int, so the value gets truncated and pthread_getcpuclockid() crashes on the incorrect value. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #18 from Gilles Dubuc --- Same for running directly without the mwscript wrapper: vagrant@mediawiki-vagrant:/vagrant/mediawiki/maintenance$ php importDump.php /vagrant/puppet/modules/role/files/multimedia/template/ISOdate.xml Segmentation fault (core dumped) The crash is identical as before, strace segfaults at the exact same spot. I think it's mildly concerning that mwscript doesn't report anything other than its exit code, because the segfault is invisible to someone running mwscript manually from the command line. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #17 from Gilles Dubuc --- Hah, it turns out that the apparent success in the regular command line was misleading: it segfaults in there just the same and doesn't import the template. Thus, the repro steps are a lot easier and don't involve puppet at all. Get the XML dump of a template using lua from my patch posted above and do this: mwscript importDump.php --wiki=wiki /vagrant/puppet/modules/role/files/multimedia/template/ISOdate.xml echo $? 139 I'm pretty sure that this would happen with any dump of a template using lua. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #16 from Gilles Dubuc --- These are the shortest repro steps I was able to put together. Apply the patch I've just added above. - Make sure that the "zend" and "scribunto" roles are both provisioned (this has to be provisioned beforehand in order to avoid #71901 ). Zend might not be necessary, but since hhvm tends to be guilty until proven otherwise these days... - Enable and provision the "luacrash" role -> The crash should happen during the provision run and you should find the strace in /tmp/stracetemplate_isodate I'm not sure if the repro steps can be simplified further, considering that the command will only crash when run inside puppet. The exact same command run from vagrant ssh runs fine. Enjoy! You clearly know more about making sense of that strace than I do :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 Gilles Dubuc changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 Gerrit Notification Bot changed: What|Removed |Added Status|NEW |PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #15 from Gerrit Notification Bot --- Change 166585 had a related patch set uploaded by Gilles: [DONTMERGE] Role to reproduce 71354 https://gerrit.wikimedia.org/r/166585 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #14 from Brad Jorsch --- (In reply to Gilles Dubuc from comment #12) > Repro steps would be to import a template that needs the luasandbox via > "mwscript importDump.php" inside puppet. It would be really nice if you could figure out repro steps that don't require a complex puppet run. (In reply to Gilles Dubuc from comment #11) > It's a segfault coming from writing to the wrong pointer. I.e. the pointer > passed as the second argument to clock_gettime probably isn't malloced > properly. A typical day in C, I guess :) That doesn't seem supported by the strace you posted. If it segfaulted in the middle of clock_gettime, it wouldn't be indicating that clock_gettime returned successfully. It's not impossible that such an strace could be output by a bad pointer causing clock_gettime to clobber the stack or heap, but it seems unlikely here considering that every call is taking the address of an already-existing struct timespec. (In reply to Gilles Dubuc from comment #13) > I guess the one value that helps narrow down which clock_gettime is the > culprit is "2" for the first parameter. That "2" isn't the first parameter, it's the tv_sec member of the struct timespec that was written by the clock_gettime call. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #13 from Gilles Dubuc --- The strace of a crash: https://phabricator.wikimedia.org/P14 I guess the one value that helps narrow down which clock_gettime is the culprit is "2" for the first parameter. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #12 from Gilles Dubuc --- Repro steps would be to import a template that needs the luasandbox via "mwscript importDump.php" inside puppet. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 Gilles Dubuc changed: What|Removed |Added CC||bjor...@wikimedia.org, ||gdu...@wikimedia.org, ||jackmcbarn+w...@gmail.com, ||tstarl...@wikimedia.org, ||vasi...@gmail.com Component|General |Scribunto Version|unspecified |master Product|MediaWiki-Vagrant |MediaWiki extensions --- Comment #11 from Gilles Dubuc --- I've managed to track down the crash, it's coming from the first clock_gettime in timer.c of luasandbox being called (I can't tell which clock_gettime call, though, strace doesn't give me enough info). The crash only happens when the import command is run inside puppet. The exact same mwscript command running from the vagrant vm's command line works fine. It's a segfault coming from writing to the wrong pointer. I.e. the pointer passed as the second argument to clock_gettime probably isn't malloced properly. A typical day in C, I guess :) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #10 from dan --- yes, i agree. i did try to find a common denominator, by trying to narrow down a common template in the included De.xml and Nl.xml dumps and removing it, but wasn’t able to narrow down a situation where removing a combination of the same templates allowed for the importDump.php script to succeed properly. i also tried troubleshooting the importDump.php script directly, but it calls many methods, which don’t provide any insight if there’s an issue. i’ll continue to troubleshoot when i get time. thanks for your feedback and thinking with me! -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 --- Comment #9 from Bryan Davis --- From the latest log file: Error: mwscript importDump.php --wiki=wiki /vagrant/puppet/modules/role/files/gwtoolset/template/En.xml returned instead of one of [0] That lack of a return code indicates a crash in the import script. Is there anything in common between the various dumps that fail to load that differentiates them from the dumps that do load? Maybe some dependency on an installed extension or puppet module that is missing at the time you provision the VM? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 71354] mwscript importDump.php fails to properly import some valid xml exports
https://bugzilla.wikimedia.org/show_bug.cgi?id=71354 dan changed: What|Removed |Added Summary|Failure to provision|mwscript importDump.php |role::gwtoolset due to |fails to properly import |scrubunto dependency|some valid xml exports -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
